Patch Detail
Show a patch.
GET /api/patches/18079/?format=api
{ "id": 18079, "url": "https://patchwork.libcamera.org/api/patches/18079/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18079/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221229225435.36569-1-Rauch.Christian@gmx.de>", "date": "2022-12-29T22:54:35", "name": "[libcamera-devel] qcam: Show string representation of pixel format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dbc66ed8093cae32648275c67837e3abd94b8a04", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18079/mbox/", "series": [ { "id": 3695, "url": "https://patchwork.libcamera.org/api/series/3695/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3695", "date": "2022-12-29T22:54:35", "name": "[libcamera-devel] qcam: Show string representation of pixel format", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3695/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18079/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18079/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12921C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 29 Dec 2022 22:54:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 733FA625CF;\n\tThu, 29 Dec 2022 23:54:39 +0100 (CET)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4ED861F12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Dec 2022 23:54:37 +0100 (CET)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Hdq-1p8Gdb0aMc-002rx5;\n\tThu, 29 Dec 2022 23:54:37 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672354479;\n\tbh=xJYGKLed6j0laiJFFx+xh5JK+lqURK4mYk+c9SNr/b8=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Sx6nI+JNwhSFp6ppo2JieGEhAgqbt9RkNCwB8JpffTE+UYI5gzyG7vti89f6Vq5WJ\n\tbxdvfMHchK3ipwWcGP9BVfVsqBLOHkYvrYxh+6LoehSCEddsoNlZFGaVk1owDci6Ek\n\tHgrBn2n+1Eu3+LmTn7nGrN5+j4t3OuzR67pqbQ+1+41KFJWUxvhThY2ZF/2ehEMf5F\n\tfrHKYeC29ohmqTHkS+RZTels+qVwaVcjUg5ttIynejNU0XnpZnLCYupYeyoXcTt/gj\n\tIqKjZTLvO0ju4Dzfizq6nj9XY15WRWj2x86ALV/90z07GrtRvA2Jq+3SSiJtSO/sQj\n\tIeagIs/EjiDDg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1672354477; bh=xJYGKLed6j0laiJFFx+xh5JK+lqURK4mYk+c9SNr/b8=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=D3qegSI5nfU3I1g+u58YLjUNgtNCh9tOwzWZnQ1Yph2PrWfjVrXQvcgBH3skwiD+L\n\tq0yBMi9EMFAuYicFvUzkfnRCcQjEWCg2k4wbHcNwsaGqfZKCwS71n4jkHu8qmW3UV0\n\t5kHLIfO5M3jza8VRcaZu0H2Q6IVXcxidR3t3NYTs1n0Mv2IJc6CDm8pKqmx8Z5bEiW\n\twI09eWx73zZ+Wsnc1+8rkEG9NYgSQ3ZqC+QOZ98hTfyGs4AelJBK8Hiu9oFSCPKdns\n\t1bwTQGJCQpQuZ0CFqJHECZZY0lIntEIde/VrVJa3pdyKq+uvyP0mUDmpLwjd9ILFga\n\tDyI8W2ifp6SHA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"D3qegSI5\"; dkim-atps=neutral", "X-UI-Sender-Class": "724b4f7f-cbec-4199-ad4e-598c01a50d3a", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 29 Dec 2022 23:54:35 +0100", "Message-Id": "<20221229225435.36569-1-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:zEzvozvU7N7a2UIoILttfpCr279o8lu/8yb65EDu6BkwdyDsm7H\n\tasq3TL9bFoc0SLug2cqQ5fHVT7erDPyHN/o69dMHAU+AYLj2EuvvIeDfoagWWprZxMKe6+9\n\tPFSfFIOWHjzqndDrd3JTdrup1xBFy1GhrzbpkShR7O82Crlg646jT3s2iKp3OGQkW9mxrEF\n\tMZxnKe8h5vbzfCnEWRThw==", "X-Spam-Flag": "NO", "UI-OutboundReport": "notjunk:1; M01:P0:q3Leg+m2s0Q=;\n\t0ehVT3amTW9IIUXufvy39z7WxGF\n\te3xSrGR4QH8OMezBFQHLEy5uymP3TGbOkwdYIztJ7PaHeeM2RBUKPLxgagVuBiG/vpqDmBRmK\n\tVB7Co+rEROPrQyvkAHBAKNfEcBRHLqbrv1nMrkn4vryJllb9lB5NH9x6NomXJ3TWeUq52/lyE\n\tKaUS7JybzSN/X0UTINZOI7gNgMhMq2ie1Jq4y0MTp4VZdw+X0W5vONGN8c4e5T/TtLNtfKK8R\n\t1zS9g9PRnf9NFPQB+u/YELH7gQqdOaZFsUlnOlCv65dR+ByDACDgZNN2NuOTtmAZU7TlEAeHs\n\toSR32onh7KLPivrq7SBGSczLILDDQzJY2B1oDKWkiO7Eh5rWBG7C2wETjHhmL+/jLkzHuBfTY\n\tEc1H2xUVJDQQkrEYXmOjmh7TIWPjVpN0eGhczOhgGrl/GWkKCav8GRY1roPb80tOi4Q4jinKz\n\t/3LSgg4/ayqtHC++fG/vZpVPJ9bVdZzaTScSw+t3CgpgJtt9LpMVLKBneNAyJXb4LlJKsNDjx\n\t2xXltHg6gqL8MPdwNDTq/ZF4dtx4XgtzSZZuDXQqmfdF1PE2EENQ+DMXdOd0C+BGhtX+ve+GT\n\twF20LV7MYbFjQcgP2BL9MvHuA7jlK6EFPYnYVVkhAjytU0fUtkSY5Scqw94srmbW1mdTNUZAD\n\tkokkYwJ9Twkimd54JqbW4Or99Pp0JCcrUMqMzOR/dd+4wg73oJIeglYeq80zjvI0EH3EaVwT4\n\tnoocNKvDdI5VR9QZV+1ZI0MOEqcjLPQtSofQ6+9Wisx2caS+fHf9DvvGL6VV2pO9B7/Gy7L3V\n\tMnQGbkbUL0ENoX/nmiMlSj6LV9t1iy992aJPWwHkXWM9SO7r7F6FBv6ItGBza30bFMCnNzghu\n\tvsro5zrnJr4Zwxnpkq3RbYoXd5izAE09Pj+dxy68wPNQqMd92VcbwhqOoyQXWO6U71sL0BZZb\n\tX3wXgfO8OjzVE7XiNDUk11WjJzM=", "Subject": "[libcamera-devel] [PATCH] qcam: Show string representation of pixel\n\tformat", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The raw pixel format in form of the fourcc integer is not easily readable.\nUse the string representation instead for easier debugging.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n src/apps/qcam/viewfinder_qt.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.34.1", "diff": "diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\nindex a7482bea..dcb7acdf 100644\n--- a/src/apps/qcam/viewfinder_qt.cpp\n+++ b/src/apps/qcam/viewfinder_qt.cpp\n@@ -71,7 +71,7 @@ int ViewFinderQt::setFormat(const libcamera::PixelFormat &format, const QSize &s\n\n \t\timage_ = QImage(size, QImage::Format_RGB32);\n\n-\t\tqInfo() << \"Using software format conversion from\" << format;\n+\t\tqInfo() << \"Using software format conversion from\" << format.toString().c_str();\n \t} else {\n \t\tqInfo() << \"Zero-copy enabled\";\n \t}\n", "prefixes": [ "libcamera-devel" ] }