Patch Detail
Show a patch.
GET /api/patches/18053/?format=api
{ "id": 18053, "url": "https://patchwork.libcamera.org/api/patches/18053/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18053/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221223082229.2559907-1-javierm@redhat.com>", "date": "2022-12-23T08:22:29", "name": "[libcamera-devel] meson: Only build pipeline handlers needed in the host architecture", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a23f4646007e039d2fed58d8b8f662a9799ace97", "submitter": { "id": 95, "url": "https://patchwork.libcamera.org/api/people/95/?format=api", "name": "Javier Martinez Canillas", "email": "javierm@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18053/mbox/", "series": [ { "id": 3688, "url": "https://patchwork.libcamera.org/api/series/3688/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3688", "date": "2022-12-23T08:22:29", "name": "[libcamera-devel] meson: Only build pipeline handlers needed in the host architecture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3688/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18053/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18053/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9CFC1BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Dec 2022 08:23:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 093C7633AC;\n\tFri, 23 Dec 2022 09:23:02 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EE9E6339D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Dec 2022 09:22:59 +0100 (CET)", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id\n\tus-mta-44-jCLkjBYWNlyj4pAsDFcG6Q-1; Fri, 23 Dec 2022 03:22:49 -0500", "by mail-wm1-f69.google.com with SMTP id\n\tm8-20020a05600c3b0800b003d96bdce12fso202769wms.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Dec 2022 00:22:49 -0800 (PST)", "from minerva.home (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\tc4-20020a5d4f04000000b002365cd93d05sm2464672wru.102.2022.12.23.00.22.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 23 Dec 2022 00:22:47 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671783782;\n\tbh=qjs8tI5yV+o4xnfE6oiPZys/CEGMhXyprZMB/4QOBZc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=g/dJzjxhiXSzTgHTtmI74AFy6nXu/1LGriN9ANBQOIj37wTT8bhL+z/VMCfc0ZE1f\n\tN20sE/rYWlReVEH/jwdiSiUnWEik649yYtilwcVpgMJVhHJtaVurP3iB8ax28W2lKC\n\tl054xZnz+1DFPi9BqOoMZVfuwI6Q3kr3AHr9hUGcVDfAy5Mn1FhT/HFtmKlgoZ+tRf\n\th21Wjf1MQUZkEnAhAVJ0kiWPwZ0sMsuTXPkXp4j1BFZC32mHSfas7jDbFkzL029FMC\n\tvbHRFC6qrYHmy2MChB94eVLotvMRSIs49YU6BVcQv4stT1mJab3X8UQynp5w4gD2of\n\tZ0IYJdsseLcCg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1671783778;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=F7RSiprDs5BAPOtNBMZDFJDd+c8Lsho3AqYziGvxrGE=;\n\tb=UXTXU2khFZwUMFVUcVbtXFnFdfGmncZAO+g1OjgCkNKdsVFJAL02pZLuz02gqBnNsl8a3s\n\tHepXkchc9imoLPKjr+bZDIyeUvpZ55pvTJZy3JbRmPBiv16gLHH+0ZHl/PsHQAfZVzyXtT\n\tWsZzoR4UKQxUyFVVKtk2CwSIV2RkUq0=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"UXTXU2kh\"; \n\tdkim-atps=neutral", "X-MC-Unique": "jCLkjBYWNlyj4pAsDFcG6Q-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=F7RSiprDs5BAPOtNBMZDFJDd+c8Lsho3AqYziGvxrGE=;\n\tb=M4hwSK0bq9wRdOM3dMTNuBCs1Udq7PpfvcWUdqky3xRFCkxE1Szu+QqfyGP9gjxV/C\n\t7YiiGHtwNVpOaaXUaI5F+nD97WIWxTmVWQbITNEAT3JjZ5DwlFjq7qBfOMRiSHQK3D24\n\tCK/uM3x7ZC/RoPgsX5yEUxl+z2wtt+BT8zxFiQ96xWOMBkgXvuIYNQ6O3tbc6GpLdKq1\n\t7S2UdM2fgbk9+hdqMUeZHgh94VYq0lQv5xwp5hPnovSXSjMdjAP2lAxWjWWARB3fhZRa\n\tXevdQrcbktP8xzU+S+Yluh/CZVYXUR0d3XoJoXA14b14NIT8qOBe9k1m7E3aCK6ldoPY\n\tB0Fw==", "X-Gm-Message-State": "AFqh2kq00mmoxpovqQolPcy3oP1zXWDybhHAe8uT76n+iSLPyzSX9Gv9\n\tT7VvTnuE5zc9anbkjiQyVi4iO1zLUt610+Aa8pGFPqA/Uc2OrC6UFxMoCJ+yqEMdZCuk1BmH8GS\n\toQ68Uti3fx7B6jmZaESfc/lAZkJhSTVghYSxRZYPBQecmL8xAV9gPciy6OtyEkmcsVTLAIBxxAq\n\tpRtPvOvBJw", "X-Received": [ "by 2002:adf:cf04:0:b0:242:3be9:71c5 with SMTP id\n\to4-20020adfcf04000000b002423be971c5mr4740968wrj.54.1671783768617; \n\tFri, 23 Dec 2022 00:22:48 -0800 (PST)", "by 2002:adf:cf04:0:b0:242:3be9:71c5 with SMTP id\n\to4-20020adfcf04000000b002423be971c5mr4740953wrj.54.1671783768293; \n\tFri, 23 Dec 2022 00:22:48 -0800 (PST)" ], "X-Google-Smtp-Source": "AMrXdXs/tA3ZS0bVwZCzCrhRHlkd6lvYn8ICzIsIOMXF5B2AfHgRwnlJBQYSWDJkOdK71s5t+yHyIw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Dec 2022 09:22:29 +0100", "Message-Id": "<20221223082229.2559907-1-javierm@redhat.com>", "X-Mailer": "git-send-email 2.38.1", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH] meson: Only build pipeline handlers\n\tneeded in the host architecture", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Javier Martinez Canillas via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Javier Martinez Canillas <javierm@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "By default all pipeline handlers are built, regardless on whether these\nare needed in the host architecture or not. It makes more sense to build\nonly the pipeline handlers that will be used for the given architecture.\n\nLet's do that by default now, but still allow to build the other pipeline\nhandlers if needed, by using the `pipelines` meson option. For example:\n\n $ meson build\n ...\n Configuration\n Enabled pipelines : ipu3\n simple\n uvcvideo\n Enabled IPA modules : ipu3\n ...\n\n $ meson build -Dpipelines=\"ipu3,raspberrypi,rkisp1\" -Dtest=true\n ...\n Configuration\n Enabled pipelines : ipu3\n raspberrypi\n rkisp1\n vimc\n Enabled IPA modules : ipu3\n raspberrypi\n rkisp1\n vimc\n ...\n\nSuggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>\n---\n\n meson.build | 14 ++++++++++++++\n meson_options.txt | 6 ++++--\n 2 files changed, 18 insertions(+), 2 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex d02f9917965c..fc1023326ed3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -164,6 +164,20 @@ liblttng = dependency('lttng-ust', required : get_option('tracing'))\n # are enabled.\n pipelines = get_option('pipelines')\n \n+if pipelines.contains('auto')\n+ host_cpu = host_machine.cpu_family()\n+ if host_cpu == 'x86' or host_cpu == 'x86_64'\n+ pipelines = ['ipu3']\n+ elif host_cpu == 'aarch64'\n+ pipelines = ['imx8-isi', 'ipu3', 'raspberrypi', 'rkisp1']\n+ elif host_cpu == 'arm'\n+ pipelines = ['raspberrypi']\n+ endif\n+\n+ # Always include the simple and uvcvideo pipeline handlers.\n+ pipelines += ['simple', 'uvcvideo']\n+endif\n+\n if get_option('test') and 'vimc' not in pipelines\n message('Enabling vimc pipeline handler to support tests')\n pipelines += ['vimc']\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 1ba6778ce257..23505805de41 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -37,8 +37,10 @@ option('lc-compliance',\n \n option('pipelines',\n type : 'array',\n- choices : ['imx8-isi', 'ipu3', 'raspberrypi', 'rkisp1', 'simple', 'uvcvideo', 'vimc'],\n- description : 'Select which pipeline handlers to include')\n+ value : ['auto'],\n+ choices : ['auto', 'imx8-isi', 'ipu3', 'raspberrypi', 'rkisp1', 'simple', 'uvcvideo', 'vimc'],\n+ description : '''Select which pipeline handlers to build. If this is set to auto, all\n+ the pipelines applicable to the target architecture will be built.''')\n \n option('qcam',\n type : 'feature',\n", "prefixes": [ "libcamera-devel" ] }