Patch Detail
Show a patch.
GET /api/patches/18038/?format=api
{ "id": 18038, "url": "https://patchwork.libcamera.org/api/patches/18038/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18038/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221219132029.2228553-1-kieran.bingham@ideasonboard.com>", "date": "2022-12-19T13:20:29", "name": "[libcamera-devel,v2] Expose the Request Sequence Number in Python Bindings", "commit_ref": "3c70cae5e501ea2e74dc5813b58298c6cb28ac74", "pull_url": null, "state": "accepted", "archived": false, "hash": "5030681f12f09aec17e77f78cbbc05a9562fd5d6", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18038/mbox/", "series": [ { "id": 3678, "url": "https://patchwork.libcamera.org/api/series/3678/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3678", "date": "2022-12-19T13:20:29", "name": "[libcamera-devel,v2] Expose the Request Sequence Number in Python Bindings", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3678/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18038/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18038/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D0D3C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Dec 2022 13:20:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DB30633A2;\n\tMon, 19 Dec 2022 14:20:35 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2509C61508\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Dec 2022 14:20:34 +0100 (CET)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56417825;\n\tMon, 19 Dec 2022 14:20:33 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671456035;\n\tbh=4uvPApkjwSp6alv92lFawGO7SZRis7GhDLdUb/VNv9A=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=dV/yiq9xFn6m0mOrWY1VNPF6ccBmIXZnk7dntK3k87Z0vg6YI4WaLZLIuzzeZbH8h\n\t/tM+5sJN6JKIAFc5aZ7Z9bSE/caMepuodcxMI38FI3zDpeWG5Y/WW65Z89Ucv8bpmw\n\tNLC/r1X3ky5jPt2FO81KQVz4MqL5i52JWw4RWiNIAgtpnAERjzZYyAG9zNL9DsZQoa\n\tZEBobxhko16kpSrG4/GeYbK/3Lfshdqx1MgWOTPKoi/aFCVOapFJabrxQeb6rHdHa+\n\teIXb6tTFb5ulHh+Ve/Uo5A2CM7l2876RDlxiDMicYF3qktLPdWutxikL0dIjvUvoAy\n\tlYcxSZmePBa2Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671456033;\n\tbh=4uvPApkjwSp6alv92lFawGO7SZRis7GhDLdUb/VNv9A=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jh+Dc098/orNGy94q2zqZxErChbVGj/zhjXE+x9Ufu+7OYAxtAhjLacpXv5t7hdgN\n\tGr3xFe8tifluJpP5cSqfjEFN3iCbNqL3eL+Qm5IP0qrYOVMVsIGS5cnhOFDPjBAJZI\n\tGNw32NUgvWWCyRUEbcLris0WMFDHRkZArs136Xo4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jh+Dc098\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 19 Dec 2022 13:20:29 +0000", "Message-Id": "<20221219132029.2228553-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] Expose the Request Sequence Number in\n\tPython Bindings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Matthew Goodman <matt@exclosure.io>\n\nThe python bindings are missing the ability to read the sequence number\nof the Request object from the public API.\n\nExpose the objects sequence number on the pybind11 surfaces to support\napplications reading this value.\n\nSigned-off-by: Matthew Goodman <matt@exclosure.io>\n[Kieran: Revised commit message]\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv2:\n - Revised commit message.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n src/py/libcamera/py_main.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 75947889f7b1..d14e18e25f3f 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -335,6 +335,7 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.def_property_readonly(\"status\", &Request::status)\n \t\t.def_property_readonly(\"buffers\", &Request::buffers)\n \t\t.def_property_readonly(\"cookie\", &Request::cookie)\n+\t\t.def_property_readonly(\"sequence\", &Request::sequence)\n \t\t.def_property_readonly(\"has_pending_buffers\", &Request::hasPendingBuffers)\n \t\t.def(\"set_control\", [](Request &self, const ControlId &id, py::object value) {\n \t\t\tself.controls().set(id.id(), pyToControlValue(value, id.type()));\n", "prefixes": [ "libcamera-devel", "v2" ] }