Patch Detail
Show a patch.
GET /api/patches/18013/?format=api
{ "id": 18013, "url": "https://patchwork.libcamera.org/api/patches/18013/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18013/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221214161656.436083-1-xavier.roumegue@oss.nxp.com>", "date": "2022-12-14T16:16:56", "name": "[libcamera-devel] utils: checkstyle.py: Check new header file on new and renamed meson.build files", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ef45cb46aa3437c60923146e62ed6a5b95abc425", "submitter": { "id": 107, "url": "https://patchwork.libcamera.org/api/people/107/?format=api", "name": "Xavier Roumegue", "email": "xavier.roumegue@oss.nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18013/mbox/", "series": [ { "id": 3674, "url": "https://patchwork.libcamera.org/api/series/3674/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3674", "date": "2022-12-14T16:16:56", "name": "[libcamera-devel] utils: checkstyle.py: Check new header file on new and renamed meson.build files", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3674/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18013/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18013/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6960C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Dec 2022 16:17:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 197EA63354;\n\tWed, 14 Dec 2022 17:17:17 +0100 (CET)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur04on2087.outbound.protection.outlook.com [40.107.7.87])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3389C61F23\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Dec 2022 17:17:15 +0100 (CET)", "from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)\n\tby AM0PR04MB7025.eurprd04.prod.outlook.com (2603:10a6:208:19c::19)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11;\n\tWed, 14 Dec 2022 16:17:12 +0000", "from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::14d3:8e4:cf07:810d]) by\n\tPAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::14d3:8e4:cf07:810d%3]) with mapi id 15.20.5880.019;\n\tWed, 14 Dec 2022 16:17:12 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671034637;\n\tbh=r+3+fkgxlKofrTOQWKQsrtZa4cGKE7LeY8DXGRppktw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=EZKyTz9UTABqHa4CkzsEaWsKdhQKuJR9XaDlUegNgMmIIIen6/1kfBPhIIBCWPAEq\n\t73UgsqiEtKvOWq7Az9goidPvqe39wS3K5/dkh9mdjMIE68OZ9baKpdyHVFWfPIi0xq\n\t6ae7mwstHjBHjulKLAt488eCVi3Dtd17Hp5dDCP6/JLhRK2EuO+z4DFl0GtfEkVGnh\n\tNpcK+DGgGpi2saWAsqCKG8ZIML9SB6zL1uPTy0A2go3jkYvUie1LCLgJGFl8jhLcyh\n\tIHCW2TzJF7SMxWvU+0a/IAZHyGgpoYHLNn8wvQl5Eoh77oGpvWa66Ri+ekGAtuHy1j\n\t1/0xJN8vWdRBw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n\ts=selector2-NXP1-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=1LIcf1y5eI+3FW13iNYdBuCp5yR5wdnXerEuD9m3fS8=;\n\tb=ELj3fOZhyW7XL5s+JG7eYchl++IbPCvwBusFVyt8zAXP1shcDxK3rDUlCsexc4Pa8XW8zUgn+FeqVYBPDgxeOaYj3fGS/UfnIbteHUCkCQglLbc/RTl+I1je4iwRcyg4yIWHk5rChDqwZGg7ibt53LmuSZCs6nuGCkyaBLwqAZk=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=NXP1.onmicrosoft.com\n\theader.i=@NXP1.onmicrosoft.com\n\theader.b=\"ELj3fOZh\"; dkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=oss.nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=OWmMqWGIYEW7BJ7a5Uy3HQX/kZwmIZC1EibDtLvt3MvGnoumWMj7v+NAd1YoekrL3ITYyN4oSaklIZ+QhFy96IOVfj3D9YPfo2rbbp7NezpP106RKs4oSPaT/BpOrnG0o+7WBrjLYhg3E7XmkzxtWlh7yaWoyk6p+bjvTu8ldrsh1gAJtD6de4N1ywJ1IwJaCPx32nNVCCNhiUJ0ZG0Jx7bdY3fyLowd0GgLoGpmeOMmYVamTTla/hmduagXAyxGRLcKhbao4hfTglpPpT/7P0oYFrLo6YPtTu7Hx6fbwDhqoVq3fIr8QzPo8gIPue+XwVbmVIoapIMAa/Zm/9fKxA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=1LIcf1y5eI+3FW13iNYdBuCp5yR5wdnXerEuD9m3fS8=;\n\tb=LNVLixQFHRN7mLLNCcrL6xHHppSazMDPVyLmlG2CRkg+FYwLE9/x1ahbsxOLcdcO1jxKOwhYGLOGh+D2fnYcDJHS2d7MUJatihK6ShhTOuSkHjRbRRxLMHgD0vE2qgTGoAwOwijaTGtFejj9FpzldeJrScpsc3VigtTupp23waakLpNo+V3gteJTUIrXaYUdeOpHidR9+iVKGufBWYuiYrTHCBBU1b+OmC4UH2vkOf4MBvovW1+zWa0dzvJFFgwt6BUDEMET1lpwmXfzRZEQb/8PeAw4anD2eDNvrTO5YSREt2vlMxuuJ2MmWI2GduoIre7CAtiEmBOCmdTWY4RwcA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=oss.nxp.com;\n\tdmarc=pass action=none header.from=oss.nxp.com; \n\tdkim=pass header.d=oss.nxp.com; arc=none", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 14 Dec 2022 17:16:56 +0100", "Message-Id": "<20221214161656.436083-1-xavier.roumegue@oss.nxp.com>", "X-Mailer": "git-send-email 2.38.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "PA7P264CA0104.FRAP264.PROD.OUTLOOK.COM\n\t(2603:10a6:102:348::20) To PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB8703:EE_|AM0PR04MB7025:EE_", "X-MS-Office365-Filtering-Correlation-Id": "edfaa6cc-40f4-4240-95f6-08daddeea814", "X-MS-Exchange-SharedMailbox-RoutingAgent-Processed": "True", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "zjevbiwiiOPxcuLOcy5uxorwSzUNtNntNIN/1qciPnJ8uCyL1b7oSALRSvEEeD/nXS8YwptVUsHJGiK9zznH6NiAOII1RFA9xe1xA6/ZrQ1sSOZwCU+o8v82T06aclJNco1Oahhkira5SI1jIdiWc2/LMx23wevB3pmhX99QQB3arSYBrt8Vh8DnVp957ZqBpN4HbTBi9SCuKkTwFDgU4a0DCag8cE/eScaFrafakNvJV79TWe5BxZ7GikSRzQOYU5saNxeXBjpmN7OPEKG8qlmg0BeGwHJ8SYgbfU6KVWo3/0HvnypZXt0dOV4Ua8Pfbo0o20cZibOKsDJF0otnk7unuHGm72Q33X1RXGg5bO0jzF1JsrWL5V+H5ZAkmkr7y9HNXm234Q2S0jb4cRRrkx14Ai33RMaNrP6RmGF9HNe1fUTb/RnW4DzSYSSdsvCZxj2hsUi5rivOxjDamqV0hkf8tMYF/UDU+3G31wi/c3f6wKa0JyzyPVpDDyh2WmkJXdzeO343Jgk++WndxFr0v0OseE0U3gSiENxP0o9B4hOG+H9wjHgoRMEo8FrW39D/VGWFQHIuYpazOkADO6IKNNh/1WGgVDdH59mfcXlDGwYvpVd5mv4X4GqAdbAAPP7IqMYT/1cfCFog6neKMzpxsQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8703.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(2616005)(83380400001)(1076003)(86362001)(316002)(478600001)(6916009)(186003)(38100700002)(6666004)(6506007)(52116002)(6512007)(4744005)(2906002)(44832011)(6486002)(41300700001)(8936002)(8676002)(66946007)(4326008)(66476007)(66556008)(5660300002);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "Mhgzl/+R8IooRKFM5y7m+SbF34GJyJ6GzW0upKk3p6rmjYjmSn1/M5yLqy3T6iG8jSooKBhRXf6LC+KR6Z1RhIvNV/KevFnqgvB6WopvuCeLaFxF3ptn2ivd17f25/mZzHIndh8b8F6HguPVKxPQK+GiBNqP/ZCxqe5Qf41rHp0KsPmBpvih2isazCoB07mlO3sB8hfrd3YRbK+1mNDXRtI1N+AzIh4VmO0D2k+nXm6UiTIZAb+vIYQ0s9nwHRBusH7Xq8Hmp9GdCV+E+kPuAg4ca3FBfpQOr0yB6MLhvkbqf9ACYk0BJSu/7W39IVBlsXBcPiueRgPEaUyyC6vupg3Nm2IJ/gUIkt9LMExxyehMElHG4ELBCMT0EV2AeXJDjCJSgZLAUnT1+Md93nad8WUBUPmP1SaVXKo7t+zopIv4cLBnxPAAO4Ftg0SPEcPL1+14IgVT5yzSfkYIalvUJztlZEOMPxPCUoat6ZgIJgKuB/ik2CY0VYJAmb17/bma0jSOD+5sRaIHxzk5cxhWV0NEulu4T11+6cOZxZ34jTRqGhsRg9T4sCuYVNFFIw3QRfcAmmrmlE9KcJWxumSpJzkuxcesbL8dRKxjZATz/rTmEFzyTRLqrLpi7+GSjRGp8eMVHdkI/87GGHrl4Spmmm1EHZdc03tS9OpDZSeZjra563n45AbErO5kj1wyToi1K/11Dg9d7z3mlixfvUqzwhsFfpkuM+e41D9/4cpcLrGJ9vSLx04OWSLv5uIv6W65m0edd6J99sIqa5mIwVPzdcvyST24hwiff/0PAtBb21lG/EIcOA8HUEo4fng0K4t0oDnHyjpH0q3eFEdhXwNJ0NBg8kFY+/SOn0/YS8uPyORirtBWXVoLhIR3CtfzDTMrQQ8sZhhQ/fgw4z22Hd2qKpmklRbON7Uq5/cUFtdVCIRgz6oMiVTWDNEWRcncAiZby5/d7MFgzYaLkqsUAvvrGHq24Iuz5wjNc5TchA4ALFUoqmT7Oya8x0UUwM8/1OHaVHL/HUu4TaZsUhyjSsri59/ExPCa7dp/kaVHRDz8iyLBWjkdeaQgrVM17rivIl4ojO49WWMbJ4dSGRP0PyVJ1/DW/nRS6QdPW0+zWlIsLq0k+8xnbWvOX+O1rgsESi4tQ/E8d+qDp7hXkVmAkqiHT3WQjWnPb7ly9zr/viNJ4sZ9wSGiX4EDqBgLaub8F/I+yKAvU/YS3y40MRIQW7V+6VVNoz9NLuQg/0SNTMthedj4/JYPpHltm8gBSW9nwwfgtXgdjWS+eCf50yzRs6bJwrBUcqVKdvtXNTkV5ZmnKX1cImiJ9fKaGCpkqlOmoDmyA0urn/oPN00kXdu9mr+enJK2cvZc/WikDkg9PwdtoCN7+zTc63d7DATIlVJeplxc2/ZExzAsLg/3oMJggupwSfHRbTi+o1ST8vBGPipWVmihbcTDkwGJ67lYSwftySIXjXlnU8WHN11LWmK9TbYEJX+O3c4gDLUoLseZASLI8WMOjozXqhO8LUsXZ7OvFXNFeigYN6qHIotp+S1GDtyU8zV3ef30CJY4VF+VDuLTlEEF7kryXaLSpvJStwXvoxE+Mh13Q5m9o/9nnDzkgfZMlvFAfGN7gwvE8Xc1X3PitBFrfKUrrAff5GYp8uJuSb3QdoRtbVhppX0zR7DfuZqriQ==", "X-OriginatorOrg": "oss.nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "edfaa6cc-40f4-4240-95f6-08daddeea814", "X-MS-Exchange-CrossTenant-AuthSource": "PAXPR04MB8703.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Dec 2022 16:17:12.3221\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "TSB1ocIuaoq3RSQtyEy7Mo8xPyA5eFJ3AlV0NaLEMTJuzzIC/1hMxUhxTO2FDE6PcmbyRuVvvKtnjOlLccaWcw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB7025", "Subject": "[libcamera-devel] [PATCH] utils: checkstyle.py: Check new header\n\tfile on new and renamed meson.build files", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Xavier Roumegue via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Xavier Roumegue <xavier.roumegue@oss.nxp.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Declaration of new header file to the build system are only checked against\nmodified meson.build file. Therefore, this raises a false positive warning in\ncase the meson.build is added or renamed.\n\nAdd the new and renamed meson.build files to the list of files to check header\nfile inclusion.\n\nSigned-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>\n---\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex f0248d65..64dcf5ed 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -313,7 +313,7 @@ class HeaderAddChecker(CommitChecker):\n def check(cls, commit, top_level):\n issues = []\n \n- meson_files = [f for f in commit.files('M')\n+ meson_files = [f for f in commit.files('AMR')\n if os.path.basename(f) == 'meson.build']\n \n for filename in commit.files('AR'):\n", "prefixes": [ "libcamera-devel" ] }