Patch Detail
Show a patch.
GET /api/patches/18002/?format=api
{ "id": 18002, "url": "https://patchwork.libcamera.org/api/patches/18002/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18002/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221214093330.3345421-2-chenghaoyang@google.com>", "date": "2022-12-14T09:33:24", "name": "[libcamera-devel,v8,1/7] Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1824248175cc997dd16eac279826e130593ec312", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18002/mbox/", "series": [ { "id": 3671, "url": "https://patchwork.libcamera.org/api/series/3671/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3671", "date": "2022-12-14T09:33:23", "name": "Add CrOS JEA implementation", "version": 8, "mbox": "https://patchwork.libcamera.org/series/3671/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18002/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18002/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE718C328D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Dec 2022 09:33:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9554563354;\n\tWed, 14 Dec 2022 10:33:38 +0100 (CET)", "from mail-pf1-x436.google.com (mail-pf1-x436.google.com\n\t[IPv6:2607:f8b0:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FE2663354\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Dec 2022 10:33:37 +0100 (CET)", "by mail-pf1-x436.google.com with SMTP id n3so4020359pfq.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Dec 2022 01:33:37 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(46.165.189.35.bc.googleusercontent.com. [35.189.165.46])\n\tby smtp.gmail.com with ESMTPSA id\n\td206-20020a621dd7000000b0056bc742d21esm9331190pfd.176.2022.12.14.01.33.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Dec 2022 01:33:35 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671010418;\n\tbh=E2m7QffPxm8qYVlVx57pZSYUeDiX2bTpVnCJ7pyvUN8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QH4R3ojtkQm4yOC8Nm8qqkzVeGVY0GsjkikXmKBA3JocD2z/TEqoteJaka1Ww6l3d\n\toKJ7NMJ3762/GSw5VFZ8TbMrpAndfAvBBPLwZk1ia6g1k+c0xAILfNHCXQGU/3bQAt\n\tFvIPzTCKBoclQBqP+g9LsDNVNYrgGCSAhZ/kuOAL66svULUNm8QdfJebj8WQIymIw4\n\t9VZAkekivxhcqK10ZopdRRCvi3utrILi/cgV2MvIO4bz+x9CHKefi5UYawOh6dYR0U\n\t4uJ+35EQbdskjjcAwVoUufdFW0lGXoBWc007nEBwKmxxww+kRWQtuiTGgI7HJPZoEZ\n\thTJKCujmR31/g==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BCX1ICp7HjraiuyI8JwLhhuX3e6nM3XCIN0/+nJsM8c=;\n\tb=JWutsoK+N7Z68aabs37nzlAV/hxEKh05aPwa3MIeNYDCnQQWrvi6MOrXFBxRiUARKj\n\t2sS6U3F7fsDA7JAzkOi3vNBbG8+7yi7yEYJ4v7NdZbOmJasDQYuw4wE+8gehvSW9KR8F\n\t2Q0tvkHNqmPvHsyFC7Ak/TSQ6oIvNegT2sLbA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"JWutsoK+\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=BCX1ICp7HjraiuyI8JwLhhuX3e6nM3XCIN0/+nJsM8c=;\n\tb=j3qK1DMbL6zEX4gvJZdcVkDjA9fI4A4c/qQ7zlg8kztSeQ31B7TOonAe+l4/ro9rzn\n\tGVrPGjfbZsdtRMhnpsjgj6g/B2Vp/CeD4cxjYoasU/3r/jriK1E3lByJL1LofRFAqy1D\n\tlRedKr15RqYXi0riWCWqS6EYBS7QjfXGH7ZzHlGLtm4BwixEZeUmlFrDC6hg8aV9xmjd\n\t17UOIbI+sz3heTn3OLFvgGWGsi2OMlIrPhOXQyxKiuytvPq6mSkR6qPAtYGttQ5SdgYC\n\t/0O7EJlJC8KwJNJTwxJ+XR+gEnJq7wklN/NnZRT2WidqT9cpuDasIMlWXsuZnKehTqPB\n\t6PZg==", "X-Gm-Message-State": "ANoB5pnHiGvT3vLlEYgFeMVveMf0qw1bcSyfvRMCVXxwaaRRkn20EAyi\n\tfIrwRLtt7U8g5QlXreilFp4tMOTGwr3Qcb1h", "X-Google-Smtp-Source": "AA0mqf66qSmj8p3TcBXbmP0YNwoocucOVZM06VuhN93hL+8onhrzur98mEZzBu+6BhOtLuViFb8tDQ==", "X-Received": "by 2002:aa7:9e02:0:b0:578:f60:6fac with SMTP id\n\ty2-20020aa79e02000000b005780f606facmr21443703pfq.26.1671010415786; \n\tWed, 14 Dec 2022 01:33:35 -0800 (PST)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 14 Dec 2022 09:33:24 +0000", "Message-Id": "<20221214093330.3345421-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.39.0.rc1.256.g54fd8350bd-goog", "In-Reply-To": "<20221214093330.3345421-1-chenghaoyang@google.com>", "References": "<20221214093330.3345421-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v8 1/7] Allow inheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 69553999..61244829 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -60,6 +60,7 @@ public:\n \n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const;\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v8", "1/7" ] }