Patch Detail
Show a patch.
GET /api/patches/17997/?format=api
{ "id": 17997, "url": "https://patchwork.libcamera.org/api/patches/17997/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17997/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221213114836.15473-3-naush@raspberrypi.com>", "date": "2022-12-13T11:48:33", "name": "[libcamera-devel,v3,2/5] ipa: raspberrypi: histogram: Add a constructor for an empty histogram", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "27b12163633a8456e8ccb38ccf6f0a9c93f77d4f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17997/mbox/", "series": [ { "id": 3670, "url": "https://patchwork.libcamera.org/api/series/3670/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3670", "date": "2022-12-13T11:48:31", "name": "Raspberry Pi: Generalise statistics", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3670/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17997/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17997/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60643BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Dec 2022 11:48:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B61663362;\n\tTue, 13 Dec 2022 12:48:53 +0100 (CET)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64E7063340\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Dec 2022 12:48:49 +0100 (CET)", "by mail-wr1-x433.google.com with SMTP id h7so15316231wrs.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Dec 2022 03:48:49 -0800 (PST)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tj8-20020a5d4528000000b0024287d9d4a8sm11574541wra.74.2022.12.13.03.48.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 13 Dec 2022 03:48:48 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670932133;\n\tbh=ma9szNikYEmGctrJ31Ey01v3NafeZYa8iuiY1l8LTwQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rcSXn2TzwO1vD9vE9E/6VlSzLAOEYoDNwS1Tt9TwSPG4+wmadMel9lcw7df3Ew/El\n\tLVkwyNCX10DEFlw5VoGaRfX03AI+AC8px+eqdwY65BHofsUpGau6lokOJRQ2vZbJSn\n\tuB668ZF9EdA31v+yNbVabjPOCOJbY0l+VyF5D8PZs2LGAgY5TCT+jQmKemYKCIpGys\n\tJicZP6hHqPeT4gGbJRyfxtBylLktXHDr289FKmy5/o3sUpDtQUIsquA0B2xwNDptIk\n\tXISk0IGegnk6L3WVSHpMlTABLbNr4vQ9bSPjcZ1mZrdIQRjEAZT4bgimi5Y8NfcdjZ\n\t3yFSSyjSkeseA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Oz62LSxuhaQPLtvLBoBKpt4oVpu0W2M+xPyY7uBTRX0=;\n\tb=seXBmToy2BJzXhxPyODicg1DeEJDr4nGeX78SSQVwYM/DnHHgOipXPlQXgh7sji62S\n\tCd6hAqjusDdwAMqk1urvi/AwD6HB+5O6P5DRLeiO2LqvXcLwigCyXUDJK0VXd3PZLGGI\n\t4+6gyrLXZPJljdYYEKHD/HJXmmygHuqgEkPKhQIRd+kKj0Nkxkhk+CjT5rR8daBJBIBW\n\tStPO82p/7mrU1USAlFKN5LHmZWq4phZwkplnb5ortABVSJmyJPjpGIVycy/vGRJ+Kt4e\n\t+Lvg0squjvacHM3OpBwnfG4PcO+ZmhWkcWakggX35CHdS05ixQwwmhMnVnjc+o+f3Hft\n\t4fCA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"seXBmToy\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Oz62LSxuhaQPLtvLBoBKpt4oVpu0W2M+xPyY7uBTRX0=;\n\tb=a5+FnXUwVW50kX6/V4D0Qi+83K011Ps0WcMvvffKS6aFgMgMdqi3O+uJ0KEGlbZ+tF\n\tBJezflCa++KZxZpPODrMmvRYg6Vutfk8mgdUJPkKt/6tDppWHi0K3Snym/J7QzqGFjif\n\tCPvBalVYy2y7yLReN4/ORJJ/3MaV5UNwh1SU/fPsQ6PwdNM8Cy9ytZx51MBujNCAfCv1\n\trqm6c05QILqKkbOF5GPV9iHCwYDUGOGwoZ1SJBVjJZFAb7tJqdtLptiRccDwviR81LP7\n\tJB1JFHom5CrXzXLavJoOfJM4sKCfWObWS6bUk00PNEbuGFNkLbtdX7O0R31oZPTjiLUF\n\tjbVQ==", "X-Gm-Message-State": "ANoB5pmwaeK5t/hlK80vehctmlEzLm52HUq9YUoWQMara7oVOPFdl4c9\n\tqd+Q0zdq/IqBEMolD7xYD7epOGUNQriuGJqj", "X-Google-Smtp-Source": "AA0mqf702/BAWQyzB7P80fCnQQu70XzTWtFXYd6yJadG5KvtIoSS728OZXFXjajKqx12AtP/u8rfpw==", "X-Received": "by 2002:a5d:6045:0:b0:242:24a7:c7f2 with SMTP id\n\tj5-20020a5d6045000000b0024224a7c7f2mr11822147wrt.58.1670932128681; \n\tTue, 13 Dec 2022 03:48:48 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Dec 2022 11:48:33 +0000", "Message-Id": "<20221213114836.15473-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221213114836.15473-1-naush@raspberrypi.com>", "References": "<20221213114836.15473-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/5] ipa: raspberrypi: histogram: Add a\n\tconstructor for an empty histogram", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a default constructor to the RPiController::Histogram class that creates\nan empty histogram. Since this is a cumulative histogram, push a value of 0 into\nthe first (and only) bin to signify this.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/histogram.h | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h\nindex 66a68b087964..6b3e3a9e68e4 100644\n--- a/src/ipa/raspberrypi/controller/histogram.h\n+++ b/src/ipa/raspberrypi/controller/histogram.h\n@@ -20,6 +20,11 @@ namespace RPiController {\n class Histogram\n {\n public:\n+\tHistogram()\n+\t{\n+\t\tcumulative_.push_back(0);\n+\t}\n+\n \ttemplate<typename T> Histogram(T *histogram, int num)\n \t{\n \t\tassert(num);\n", "prefixes": [ "libcamera-devel", "v3", "2/5" ] }