Patch Detail
Show a patch.
GET /api/patches/17918/?format=api
{ "id": 17918, "url": "https://patchwork.libcamera.org/api/patches/17918/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17918/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221130001044.651663-1-nfraprado@collabora.com>", "date": "2022-11-30T00:10:44", "name": "[libcamera-devel] lc-compliance: Fix segfault on request destruction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "391face6df13af06f87a410e7a6d2a51f96a9ab9", "submitter": { "id": 84, "url": "https://patchwork.libcamera.org/api/people/84/?format=api", "name": "Nícolas F. R. A. Prado", "email": "nfraprado@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17918/mbox/", "series": [ { "id": 3648, "url": "https://patchwork.libcamera.org/api/series/3648/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3648", "date": "2022-11-30T00:10:44", "name": "[libcamera-devel] lc-compliance: Fix segfault on request destruction", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3648/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17918/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17918/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55983BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 30 Nov 2022 00:10:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E2616333F;\n\tWed, 30 Nov 2022 01:10:51 +0100 (CET)", "from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ADCE63334\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Nov 2022 01:10:49 +0100 (CET)", "from notapiano.myfiosgateway.com (unknown\n\t[IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id 5941666025DF;\n\tWed, 30 Nov 2022 00:10:48 +0000 (GMT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669767051;\n\tbh=aOd8veRb1Ej8z+GpmUNUWw/89RFGdG6QiSynm8IEMWE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=PsyoZOydJEhAmzUKG4/e0EajI+pIkJwUGllnRByrRIgZTdSOK8vZDzN1wGSObG/m9\n\t9dNKvKhF8DyjHAgDL1kDuWqtlqcm4fqdSS87lHLX52YVLUYheTX8Lf/p4NCKLDvEfn\n\t6Qm4pJ1ydZYlXMmCoOyP2PtcjqtHbNEjRWCnys6uVYIQXoYpDeUSxXuWcPAjdl0oI8\n\t72qgrgjmGrxmxMUut22f5gnOvJW8XFBgeg2FRgE8uLp6pm/eyUWyEL1/1bwTADtCDq\n\tEIJ1wVPuqyIt61KdP64eTj2SmDCb+uFogQ5QKaD06PEaf0tkEnLDjveKlYHc8OTEjN\n\tzQo9z3gHC4+6w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1669767048;\n\tbh=aOd8veRb1Ej8z+GpmUNUWw/89RFGdG6QiSynm8IEMWE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TrgxXU2KhjvbeB2UMkkAcOHKV83ss32ERXAjFsFgW7cg9nIC0U53R9wk1OJvgq+H4\n\t+Z7BHNf7F8lYxWgLP4gpZlNZnPwxeh434h0MPk7DXRmYq98sW1Ub3s+xpFRr1iNVlm\n\twB50IP0LtfL58VEO/rHGb/A7V8be1I+EUccY8ixyXV6fYKyHqZUwgEcefuO//jDh2d\n\teDD7ZywP7pMBlyFZSy2rExnkYJeA9Uv5EOcfBfagbf7tDgkB17Se/IgKvrHC60BSnt\n\tuOB84J+ekI8t92f2/AMG+RspJsuc9OpLNI34d33BUiAldWduKzcQTpHdcjjEo2U1tg\n\txKHWOhn5QEebw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"TrgxXU2K\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Nov 2022 19:10:44 -0500", "Message-Id": "<20221130001044.651663-1-nfraprado@collabora.com>", "X-Mailer": "git-send-email 2.38.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] lc-compliance: Fix segfault on request\n\tdestruction", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "=?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?=\n\t<nfraprado@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Request destructor cancels all associated framebuffers, and\ntherefore assumes they are all still valid. The SimpleCaptureBalanced\nand SimpleCaptureUnbalanced classes that run the capture sessions on\nlc-compliance however were freeing the framebuffers before the requests,\nstored in an automatic variable, were destroyed. This resulted in a\nsegfault when running lc-compliance.\n\nSolve the issue by moving the requests vector to the SimpleCapture class\nand making sure we clear it on stop() before freeing the framebuffers.\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n\n---\n\n src/apps/lc-compliance/simple_capture.cpp | 8 ++++----\n src/apps/lc-compliance/simple_capture.h | 1 +\n 2 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\nindex ab5cb35c11f2..d02c7b45f180 100644\n--- a/src/apps/lc-compliance/simple_capture.cpp\n+++ b/src/apps/lc-compliance/simple_capture.cpp\n@@ -64,6 +64,8 @@ void SimpleCapture::stop()\n \n \tcamera_->requestCompleted.disconnect(this);\n \n+\trequests_.clear();\n+\n \tStream *stream = config_->at(0).stream();\n \tallocator_->free(stream);\n }\n@@ -95,7 +97,6 @@ void SimpleCaptureBalanced::capture(unsigned int numRequests)\n \tcaptureLimit_ = numRequests;\n \n \t/* Queue the recommended number of reqeuests. */\n-\tstd::vector<std::unique_ptr<libcamera::Request>> requests;\n \tfor (const std::unique_ptr<FrameBuffer> &buffer : buffers) {\n \t\tstd::unique_ptr<Request> request = camera_->createRequest();\n \t\tASSERT_TRUE(request) << \"Can't create request\";\n@@ -104,7 +105,7 @@ void SimpleCaptureBalanced::capture(unsigned int numRequests)\n \n \t\tASSERT_EQ(queueRequest(request.get()), 0) << \"Failed to queue request\";\n \n-\t\trequests.push_back(std::move(request));\n+\t\trequests_.push_back(std::move(request));\n \t}\n \n \t/* Run capture session. */\n@@ -156,7 +157,6 @@ void SimpleCaptureUnbalanced::capture(unsigned int numRequests)\n \tcaptureLimit_ = numRequests;\n \n \t/* Queue the recommended number of reqeuests. */\n-\tstd::vector<std::unique_ptr<libcamera::Request>> requests;\n \tfor (const std::unique_ptr<FrameBuffer> &buffer : buffers) {\n \t\tstd::unique_ptr<Request> request = camera_->createRequest();\n \t\tASSERT_TRUE(request) << \"Can't create request\";\n@@ -165,7 +165,7 @@ void SimpleCaptureUnbalanced::capture(unsigned int numRequests)\n \n \t\tASSERT_EQ(camera_->queueRequest(request.get()), 0) << \"Failed to queue request\";\n \n-\t\trequests.push_back(std::move(request));\n+\t\trequests_.push_back(std::move(request));\n \t}\n \n \t/* Run capture session. */\ndiff --git a/src/apps/lc-compliance/simple_capture.h b/src/apps/lc-compliance/simple_capture.h\nindex fd9d2a97fd8d..2911d6019923 100644\n--- a/src/apps/lc-compliance/simple_capture.h\n+++ b/src/apps/lc-compliance/simple_capture.h\n@@ -32,6 +32,7 @@ protected:\n \tstd::shared_ptr<libcamera::Camera> camera_;\n \tstd::unique_ptr<libcamera::FrameBufferAllocator> allocator_;\n \tstd::unique_ptr<libcamera::CameraConfiguration> config_;\n+\tstd::vector<std::unique_ptr<libcamera::Request>> requests_;\n };\n \n class SimpleCaptureBalanced : public SimpleCapture\n", "prefixes": [ "libcamera-devel" ] }