Patch Detail
Show a patch.
GET /api/patches/17863/?format=api
{ "id": 17863, "url": "https://patchwork.libcamera.org/api/patches/17863/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17863/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221124103832.6172-3-naush@raspberrypi.com>", "date": "2022-11-24T10:38:29", "name": "[libcamera-devel,v2,2/5] ipa: raspberrypi: histogram: Add a constructor for an empty histogram", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "27b12163633a8456e8ccb38ccf6f0a9c93f77d4f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17863/mbox/", "series": [ { "id": 3635, "url": "https://patchwork.libcamera.org/api/series/3635/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3635", "date": "2022-11-24T10:38:27", "name": "Raspberry Pi: Generalise statistics", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3635/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17863/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17863/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ED46BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Nov 2022 10:38:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2059463321;\n\tThu, 24 Nov 2022 11:38:44 +0100 (CET)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9366363316\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Nov 2022 11:38:41 +0100 (CET)", "by mail-wr1-x42f.google.com with SMTP id q7so961182wrr.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Nov 2022 02:38:41 -0800 (PST)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ts16-20020adff810000000b002368a6deaf8sm995103wrp.57.2022.11.24.02.38.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 24 Nov 2022 02:38:40 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669286324;\n\tbh=ma9szNikYEmGctrJ31Ey01v3NafeZYa8iuiY1l8LTwQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3wvZ/tVkFn7rlHhqoOsm5z9iiUXN9u0tNj7Agmyoi3RmyFmvML5lWYVBgVbDjAM7Q\n\tryqtzYMdl7qpNC6apsulQbDKORPRjrtpz2bAIYIRz69B6pAdPagh/+PIqZT2x2Zkge\n\tO9WU2X/eUvld4UA/dbQMLHjbf+K3hCIFHhs8dBMPjqukR/6gpPP6z5cRYlHG0LdsxF\n\tnN0c0h7h5AWQ4YFmGjKrOwL4uSYjkS+4C1fYUsZicJcgEkQoaWeProjTBq+5i5wSfJ\n\tWse64w1UsNFcZ/LR/gB6tUij6469lCT9IxndRowbO/Vlff1ac5z18SIl1Fe1mA8VWM\n\tgD/dHsuF1Ya8Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Oz62LSxuhaQPLtvLBoBKpt4oVpu0W2M+xPyY7uBTRX0=;\n\tb=F0PlEgh7jJBm5RP+QgTLgVIQQr6li6qeh8AX6e843o7xvocib8sOx5ANGxvDVUAZg1\n\tX2k96ubQthWl81TTJQTcN1HQfG4+ayfCU2aVeFvXK679KImjgifBigumNi9dkVs1t8S1\n\t6HRwtg6SIcvnpwmnhbSj7OgN8FkWGhT0qqij4SgKl1Phac0wj9/YdyByxP7Kf2LEX5zP\n\tbfRLYWvSieKxgCAPYwU/6deEKV9Qt0iZKmZOf+/jtqqOc3fRhl6zsE49PbL7pxKt1EnW\n\t9iKUmolXKRQPiSmi30IdgDx0AQ8durxrTYPYp9vTJJPGGmU0u1f61FsotJFN40JF6W2N\n\tpc3A==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"F0PlEgh7\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Oz62LSxuhaQPLtvLBoBKpt4oVpu0W2M+xPyY7uBTRX0=;\n\tb=ulVWP71CIPhmPEQ7ymBbrXDnDEWKOHK0OUffbje8qa/GlV4I5iu56DmKBhOzftB0oA\n\tvEg1dERQyTvom9fUFVC/hpr6pKsabvdZMKe0twExyATk2s4tK6uFROw60IXHxLP0o0zf\n\tdSVjRMCOuHVdZDOHYoGJrTHGA5zsEKIfAqFwrQF4WMnikg1QrROw3R7zmFQt+Rvp/kka\n\td1xrmhjhJ3wrirvtQefymHo99h9WQBdQCn30DgleQJDQRgxbClHqz4SeQYW9meXkDrI5\n\tJvpP0UVN3NaHeeU0qndu/6yiEK9a4IVqFBayoZP/HeE1KE7tVMD/lAYL+1hUIx0653Wo\n\trtXA==", "X-Gm-Message-State": "ANoB5pmkyikbGhw7kbFlyL3dfSWF2LwdD8IDJGQC0WVTO/FcxqkcveQK\n\tpv0UtQ/xu91jNknzlGxXpliED3KTpEj5yA==", "X-Google-Smtp-Source": "AA0mqf43A1Nlhg4Rt+SPFOQakbKLUgOccGZZb+2XUykGEBWMUU/8d5TF+JEkEIc1Oz6udp80cre/AA==", "X-Received": "by 2002:a5d:620e:0:b0:241:e32f:8371 with SMTP id\n\ty14-20020a5d620e000000b00241e32f8371mr7003104wru.156.1669286320979; \n\tThu, 24 Nov 2022 02:38:40 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Nov 2022 10:38:29 +0000", "Message-Id": "<20221124103832.6172-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221124103832.6172-1-naush@raspberrypi.com>", "References": "<20221124103832.6172-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/5] ipa: raspberrypi: histogram: Add a\n\tconstructor for an empty histogram", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a default constructor to the RPiController::Histogram class that creates\nan empty histogram. Since this is a cumulative histogram, push a value of 0 into\nthe first (and only) bin to signify this.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/histogram.h | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h\nindex 66a68b087964..6b3e3a9e68e4 100644\n--- a/src/ipa/raspberrypi/controller/histogram.h\n+++ b/src/ipa/raspberrypi/controller/histogram.h\n@@ -20,6 +20,11 @@ namespace RPiController {\n class Histogram\n {\n public:\n+\tHistogram()\n+\t{\n+\t\tcumulative_.push_back(0);\n+\t}\n+\n \ttemplate<typename T> Histogram(T *histogram, int num)\n \t{\n \t\tassert(num);\n", "prefixes": [ "libcamera-devel", "v2", "2/5" ] }