Patch Detail
Show a patch.
GET /api/patches/17815/?format=api
{ "id": 17815, "url": "https://patchwork.libcamera.org/api/patches/17815/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17815/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221118200046.51305-1-Rauch.Christian@gmx.de>", "date": "2022-11-18T20:00:46", "name": "[libcamera-devel] kms: void-cast 'request' to avoid 'unused-parameter' warnings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d4b5ae8627fd3f4235f41550a38def26f4c35e1f", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17815/mbox/", "series": [ { "id": 3619, "url": "https://patchwork.libcamera.org/api/series/3619/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3619", "date": "2022-11-18T20:00:46", "name": "[libcamera-devel] kms: void-cast 'request' to avoid 'unused-parameter' warnings", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3619/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17815/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17815/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62F2ABD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Nov 2022 20:01:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEAB06309B;\n\tFri, 18 Nov 2022 21:01:00 +0100 (CET)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FB936308D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Nov 2022 21:00:59 +0100 (CET)", "from voyager ([46.183.103.17]) by mail.gmx.net (mrgmx105\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1Mf0BG-1pSSY71qv4-00gadd;\n\tFri, 18 Nov 2022 21:00:58 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668801660;\n\tbh=nKPVRAUJvvV/4HBSbquVAuEJb89mvtupVMegkqgrDGA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=uzBrWZ/a8HpHKHGajweeSiu5O3ZtQ5F1jE3F6+ZnEUumupO1BPaP773Ha39vn8QT+\n\tinRdd63I62zGWhU7B+rKkB7vRHTXZ1Xo2EUYAVdyOyP1vPJ3Lh1hMpjahoqwXZxE5h\n\t4R8Caf/lK0cK1qeIQ28mYIpf9Agiw0fIqhJ8m2H6ish2FUHwT6Rss/vnpqri25MFmG\n\tDthvGYHXK3McoxtPrpWQdZn5bgFdIW+hSZMVo6ZrH8kRXsam6oVt/3lUf0q/5SaqPV\n\tEUnW+QcERne0pC6ypKtZG2pIOQsSOMeIsKo+vWdJ7rlJqKd5E9Kxlgk7p1PQbe2BDS\n\tQWyPWTVXanEHw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1668801658; bh=nKPVRAUJvvV/4HBSbquVAuEJb89mvtupVMegkqgrDGA=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=TedsBK3zsULdKAXg3JoBNX0KBsSZ+01egjifkvE9gmmM+n0ex7ucOgV/CQK5hBIUx\n\txQCHfFh+MtuEg1QlVmBCsfBH8DAOHD3WJiYCTa3yqPAaVVYkG3EXbT2TfXg9ndueXM\n\tE1oSE0ZfgvwkHpsaTCSVKyAk2EtKfvYTG1SRZcOvYLxNmuQR1/o34aYBrxHAI+jOfI\n\tV7MbgIsRn0F7spXjpfy83rgf7wvf4xPByI6cRc7cMTDI5qWqnZiSD28swKHDZ6acu+\n\t28cdHDfUYQMx8al/VqiwDDo44sCcwoao6BGQ5KqkNxQz0tmVkO0tA1J+4qll2V2/FY\n\tH3BVs0V6eUlUg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"TedsBK3z\"; dkim-atps=neutral", "X-UI-Sender-Class": "724b4f7f-cbec-4199-ad4e-598c01a50d3a", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Nov 2022 21:00:46 +0100", "Message-Id": "<20221118200046.51305-1-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:vyGmDHmjGVJnRiszKj0p71iFLrDNFXWvN/m87O5PbzdpL0wy4Ji\n\tXc/td5jtUEtf0I1VFBGZ8e8c2IyffdYvbhHOmZoO5NMQOR/aAC2Vrd285tamLp1YzERY5aN\n\tbdYm+gIcy9OY+ay+bPFvADhsBzEY7uQP8fROBwPW4/jMpsCy38jGUFzwOAN9GJigtX9PLn9\n\t7lEKYsVlwqqgake8+rY4Q==", "X-Spam-Flag": "NO", "UI-OutboundReport": "notjunk:1; M01:P0:KMafKLR4IvQ=;\n\tGrifxkzVC7KuEpZjGcHM99S7qEe\n\t7XxpIvg1LX8g1bnnP8FGYGiSaB+K0Q1qqwEViQcmqaqjIdwgpr3wVaVmzQ/njiHEio+t0pgq1\n\tvqVrcuBiWGQKwx25Ya2qQhev0Ni+/46E1nti9NM2EOMh1aAv/6iOInS40Ae9LVkZTDrZOwmHG\n\tw3ovoMasrLIDSYaGOGC0LgXAihe0d5G+r2zRNgSopUeE4VKYj6CpM0pWRQBRGdQJl87hJiTi/\n\tidUC4bcGttzFgRjOU8lTMP+haDcvldjiEtCprkorZRLodtjqW54Kah6xAYj7OPqIZeedIuzOU\n\tMmnx3wwEPXpKRXKfwhkP4UsVfPkPuhIApN+dhzc9tygsrR0+xydevrKqdyMA8P/LyYnFhtfb9\n\t2rljEMHhSdjZmdr6t8wjNFhcq4CfUlgwCvymn+k+rNzzl7UOuC1f4NHpLPM9qIUlNU4b4KcVb\n\tk0PAFXSMoSVObJ3Vhg7yAPeCGxEw7TzSLut2UI/mFtd1ws+Nyy3jitVhVc/HJuyU4xo7U0V+o\n\t3eiFHFXZimtSPvt7b6ztMl2Gr2QJ0JPqVF4PQGKPwyzK4a6kpGifvTbSv236y9YsLu/bhRES/\n\t1tdLcVB10BgRJ8+3lMJPEG9mIlUMiBWJfifBALmOh6d1kVbxRfhfsQrSTnvVi4sFMnq4Ccttp\n\t6f/aLSk+cPja/xt7mYUMKTFTCBs8rDwK9F5Lmc2Sm554iId82WV12OLhiHmII8DQlr8jdNj7g\n\tzOkHlnEtvikzXkwiotqfooiAU9j/HTXvHRpWeh9wEYek7Zhj82yR47s3De4OHboDXLfJXB19b\n\tnY5QtlHAFGwepevj0Z0quqCJygJTmw10NbnQJ8JzcOUUl71c84OOMUHQenGgHKaXEyxLd+498\n\tQYntdsw42tS+YuB9ysdfJmdTE8ce0ZX/VDAq64D3yHSj0moPUtxqgOXEFTubr0CAy+UVc3hmK\n\tDNvRmQ==", "Subject": "[libcamera-devel] [PATCH] kms: void-cast 'request' to avoid\n\t'unused-parameter' warnings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The parameter 'request' is only used in an assert. assert is only defined\nfor debug builds and release builds will not use the parameter, resulting\nin warnings messages only for non-debug builds.\nFix this by a no-op void cast.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n src/apps/cam/kms_sink.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n--\n2.34.1", "diff": "diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\nindex 754b061e..de0af51e 100644\n--- a/src/apps/cam/kms_sink.cpp\n+++ b/src/apps/cam/kms_sink.cpp\n@@ -521,6 +521,7 @@ void KMSSink::requestComplete(DRM::AtomicRequest *request)\n {\n \tstd::lock_guard<std::mutex> lock(lock_);\n\n+\t(void) request;\n \tassert(queued_ && queued_->drmRequest_.get() == request);\n\n \t/* Complete the active request, if any. */\n", "prefixes": [ "libcamera-devel" ] }