Patch Detail
Show a patch.
GET /api/patches/17814/?format=api
{ "id": 17814, "url": "https://patchwork.libcamera.org/api/patches/17814/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17814/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221118164035.23740-1-jacopo@jmondi.org>", "date": "2022-11-18T16:40:35", "name": "[libcamera-devel] libcamera: imx8-isi: Enumerate supported stream formats", "commit_ref": "f8e998a4c19e66b6a9ba5dc864ac6f6556c87937", "pull_url": null, "state": "accepted", "archived": false, "hash": "dc3117118674830c5639f45f5622c6136df7ac22", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17814/mbox/", "series": [ { "id": 3618, "url": "https://patchwork.libcamera.org/api/series/3618/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3618", "date": "2022-11-18T16:40:35", "name": "[libcamera-devel] libcamera: imx8-isi: Enumerate supported stream formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3618/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17814/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17814/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FDD3BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Nov 2022 16:40:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C13986308F;\n\tFri, 18 Nov 2022 17:40:43 +0100 (CET)", "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC3086308D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Nov 2022 17:40:41 +0100 (CET)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5CD0340005;\n\tFri, 18 Nov 2022 16:40:41 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668789643;\n\tbh=v6YPX9tbKNAm8wiL4sUZIBCwCcVh53GutQv+FLM3XdM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=vMcJlcfqvMuReLqkN5czO6pf92DbodBpuyCCn6dzS7j+rRcUNIuR0n4x75MdDm+pO\n\tULxighNHKmvD0r1XxEGIF7muMbOx3i18gj0kznOl/bLFQlOna2BUvtqT92VklrEYNB\n\ty4pG1fIW+poHQG2suOYcabkU4F2eSFLK4PiOykkssiWAQfJkOrDkn679LHhVIBXfyC\n\tT5Thvuoq1laiOQHkFD/lAvWEzo1SxgpyncAbkRzpRN5O/t7ocXtbhrqWksdDgCPujO\n\t9SKVGbwms3uqMQXeLpjDrspRJ6xVHG6enw4IPipWC/CZcHqsrGG3sS3HcxitSfeGnj\n\t56nrnLGa/+kcQ==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Nov 2022 17:40:35 +0100", "Message-Id": "<20221118164035.23740-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.38.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: imx8-isi: Enumerate supported\n\tstream formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add to the formats map all the supported ISI video capture\nstream formats.\n\nThis allows to populate the list of stream formats for all the non-RAW\nuse cases, as the ISI can perform colorspace conversion between YUV and\nRGB.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 62 +++++++++++++++++++-\n 1 file changed, 59 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex 14d699b7a42b..a3dfd3fc529c 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -188,11 +188,51 @@ const ISICameraConfiguration::FormatMap ISICameraConfiguration::formatsMap_ = {\n \t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n \t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n \t},\n+\t{\n+\t\tformats::AVUY8888,\n+\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n+\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n+\t},\n+\t{\n+\t\tformats::NV12,\n+\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n+\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n+\t},\n+\t{\n+\t\tformats::NV16,\n+\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n+\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n+\t},\n+\t{\n+\t\tformats::YUV444,\n+\t\t{ MEDIA_BUS_FMT_YUV8_1X24,\n+\t\t MEDIA_BUS_FMT_UYVY8_1X16 },\n+\t},\n \t{\n \t\tformats::RGB565,\n \t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n \t\t MEDIA_BUS_FMT_RGB565_1X16 },\n \t},\n+\t{\n+\t\tformats::BGR888,\n+\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n+\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n+\t},\n+\t{\n+\t\tformats::RGB888,\n+\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n+\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n+\t},\n+\t{\n+\t\tformats::XRGB8888,\n+\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n+\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n+\t},\n+\t{\n+\t\tformats::ABGR8888,\n+\t\t{ MEDIA_BUS_FMT_RGB888_1X24,\n+\t\t MEDIA_BUS_FMT_RGB565_1X16 },\n+\t},\n \t{\n \t\tformats::SBGGR8,\n \t\t{ MEDIA_BUS_FMT_SBGGR8_1X8,\n@@ -546,6 +586,7 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n \t\treturn nullptr;\n \t}\n \n+\tbool isRaw = false;\n \tfor (const auto &role : roles) {\n \t\t/*\n \t\t * Prefer the following formats\n@@ -553,6 +594,7 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n \t\t * - ViewFinder/VideoRecording: 1080p YUYV\n \t\t * - RAW: sensor's native format and resolution\n \t\t */\n+\t\tstd::map<PixelFormat, std::vector<SizeRange>> streamFormats;\n \t\tPixelFormat pixelFormat;\n \t\tSize size;\n \n@@ -614,6 +656,9 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n \t\t\tsize = data->sensor_->resolution();\n \t\t\tpixelFormat = rawPipeFormat->first;\n \n+\t\t\tstreamFormats[pixelFormat] = { { kMinISISize, size } };\n+\t\t\tisRaw = true;\n+\n \t\t\tbreak;\n \t\t}\n \n@@ -622,9 +667,20 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n \t\t\treturn nullptr;\n \t\t}\n \n-\t\t/* \\todo Add all supported formats. */\n-\t\tstd::map<PixelFormat, std::vector<SizeRange>> streamFormats;\n-\t\tstreamFormats[pixelFormat] = { { kMinISISize, size } };\n+\t\t/*\n+\t\t * For non-RAW configurations the ISI can perform colorspace\n+\t\t * conversion. List all the supported output formats here.\n+\t\t */\n+\t\tif (!isRaw) {\n+\t\t\tfor (const auto &[pixFmt, pipeFmt] : ISICameraConfiguration::formatsMap_) {\n+\t\t\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixFmt);\n+\t\t\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n+\t\t\t\t\tcontinue;\n+\n+\t\t\t\tstreamFormats[pixFmt] = { { kMinISISize, size } };\n+\t\t\t}\n+\t\t}\n+\n \t\tStreamFormats formats(streamFormats);\n \n \t\tStreamConfiguration cfg(formats);\n", "prefixes": [ "libcamera-devel" ] }