Patch Detail
Show a patch.
GET /api/patches/17722/?format=api
{ "id": 17722, "url": "https://patchwork.libcamera.org/api/patches/17722/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17722/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221028031726.4849-11-nicholas@rothemail.net>", "date": "2022-10-28T03:17:26", "name": "[libcamera-devel,v5,10/10] android: libcamera: add useful debug prints", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "52f3202ca9315c73b2296c0a72b689fa500f6d97", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17722/mbox/", "series": [ { "id": 3583, "url": "https://patchwork.libcamera.org/api/series/3583/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3583", "date": "2022-10-28T03:17:17", "name": "[libcamera-devel,v5,01/10] ipa: workaround libcxx duration limitation", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3583/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17722/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17722/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FFE6C3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Oct 2022 03:17:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 226ED62FD8;\n\tFri, 28 Oct 2022 05:17:46 +0200 (CEST)", "from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com\n\t[IPv6:2607:f8b0:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 215D762FC1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Oct 2022 05:17:38 +0200 (CEST)", "by mail-oi1-x22c.google.com with SMTP id s206so4940364oie.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Oct 2022 20:17:38 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:293a:90ce:6463:244d])\n\tby smtp.gmail.com with ESMTPSA id\n\tfp19-20020a056870659300b0013626c1a5f6sm1527738oab.10.2022.10.27.20.17.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 27 Oct 2022 20:17:36 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666927066;\n\tbh=E2M2gE8AdzSxU0S2gGSqFrwSOir8BrV38NvTiVWiZDo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pKbMVbAvErYF1cZRlrbM8d02t3UwvxGdyc4KSagfsqPWAaNF4zPP0kLY3YHH6PemG\n\tl2gxn/Oh/QZTPjYf2SmxTY+adHCIvgodG8TWhYZ4/CEKBVS5xbzyhGGAwTbrl7PUfx\n\t7UDzObvNeEJfG/uymVf7UfavStVxUHNkLJm0/Qgk//d1FXq56dU5dBHefE3FerMRzp\n\tS9OknsFKWMwtWD4aNzWRWrC9DbrOUz+x3rCtmZpkAtZ0kCU4dlmIEwiknUA7MveTS8\n\tinDqHRrxelBv/Gy7HA7KuWsjn+sjxSM6o51hFi3eaq6AYRZeJ+SGL2Y5kopGBkGSGI\n\t2uVMQijSdjpEw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=6K1PGdxqOtEtfDSAankUdXcm6R3lz9nnSvzIKD/QrHE=;\n\tb=G0ZYeWyjriyowYFISGtueEhWmh7Aa6afJ8YAMnQH8bLrxKE8KzPkl73qVNrzJ+gypi\n\tIRkGxVV496jvuA4rifpv1y8bCpAM9JNguP6Yu3sr/PQqoaa92xn+OEdbnGH5o9GklL1Q\n\t3IMRN40miVeNV6H7V5U6nhthA3W9SxUnbdl1ZPMnLZmltlqX5e/QO3rgTjRgNE5xHKRw\n\t15G1AzNn15KJ80OlD9KraCJtEkW217z82rv6ZtgnviBuqLi+Tvhnb6KUTX4GDRSuKkB2\n\tJAa2KzV1wFGfVHscRsR8oy8SOy9ChIL5veDEeTsMvB5Z9dgYqsYcFEeapTSV7QG/EzA1\n\tksSA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"G0ZYeWyj\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=6K1PGdxqOtEtfDSAankUdXcm6R3lz9nnSvzIKD/QrHE=;\n\tb=IMQP9gp25C/GOgeB+GJX/XkgaKk/U5mVG3o5F+PAXoOYCfuzCMezZtXj9XOiM68GtS\n\t8UpBBatswebXTgFdbA1lOBACQU9omYm166ahOa1pMAW5NLu5wE8gfMuJuxaI4pAoLdqC\n\tJJ8pQuQmw0TDImyQJmb6stuwGKho8BXgurNv4m1aDTbICbwhpvvAwvXwnXlo1cvFnjpn\n\tCF3b2rLqs0OoxrHkE78JJpZU53gg1MJXdqPNRWa1V/mhHfKkxLvvTlGV7INgXkxPjMeB\n\tQsPZoAs2K6sTCI/GyzXVkMrONxdlbeZoGYUQV6bwGzW5UOqGG0FgVFLepYHyCBw2Fob9\n\t3aiQ==", "X-Gm-Message-State": "ACrzQf3Bw8ssbhorf8QVcfHm+/AeneWHS91586FaqhIRJlxY0sXp+IrM\n\todmzlNDOnZHB6gU+pwrc676U7nJSMFc9ai+8HGk=", "X-Google-Smtp-Source": "AMsMyM4VBniTC3qa91E45hMqewZ4I8MQA+E+4m5arVS1SoTrRlAoHGr4IBf3ksrAo0NZqOtG0dprdA==", "X-Received": "by 2002:a05:6808:1a21:b0:355:2173:7975 with SMTP id\n\tbk33-20020a0568081a2100b0035521737975mr7150380oib.116.1666927056485; \n\tThu, 27 Oct 2022 20:17:36 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Oct 2022 22:17:26 -0500", "Message-Id": "<20221028031726.4849-11-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221028031726.4849-1-nicholas@rothemail.net>", "References": "<20221027224135.348115-1-nicholas@rothemail.net>\n\t<20221028031726.4849-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 10/10] android: libcamera: add useful\n\tdebug prints", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\nI identified opportunities to make libcamera's log output easier to\nunderstand while working to get it working on my Android device as a\nHAL. These additional logging statements came out of that and will\nhopefully prove useful to Android distribution maintainers with the same\ngoal as mine and to users who attempt to debug tools like Waydroid.\n\nSigned-off-by: Nicholas Roth <nicholas@rothemail.net>\n---\n src/android/camera_capabilities.cpp | 12 +++++++++---\n src/android/camera_hal_manager.cpp | 3 ++-\n 2 files changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 64bd8dde..ef0d10d0 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -374,14 +374,20 @@ void CameraCapabilities::computeHwLevel(\n \tcamera_metadata_enum_android_info_supported_hardware_level\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;\n \n-\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR))\n+\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR)) {\n+\t\tLOG(HAL, Info) << noFull << \"missing manual sensor\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n-\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING))\n+\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING)) {\n+\t\tLOG(HAL, Info) << noFull << \"missing manual post processing\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n-\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE))\n+\tif (!caps.count(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE)) {\n+\t\tLOG(HAL, Info) << noFull << \"missing burst capture\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n \tfound = staticMetadata_->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry);\n \tif (!found || *entry.data.i32 != 0) {\ndiff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 7512cc4e..b229e2d5 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -140,7 +140,8 @@ void CameraHalManager::cameraAdded(std::shared_ptr<Camera> cam)\n \t */\n \tif (!isCameraExternal && !halConfig_.exists()) {\n \t\tLOG(HAL, Error)\n-\t\t\t<< \"HAL configuration file is mandatory for internal cameras\";\n+\t\t\t<< \"HAL configuration file is mandatory for internal cameras.\"\n+\t\t\t<< \" Camera \" << cam->id() << \"failed to load\";\n \t\treturn;\n \t}\n \n", "prefixes": [ "libcamera-devel", "v5", "10/10" ] }