Patch Detail
Show a patch.
GET /api/patches/17719/?format=api
{ "id": 17719, "url": "https://patchwork.libcamera.org/api/patches/17719/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17719/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221028031726.4849-8-nicholas@rothemail.net>", "date": "2022-10-28T03:17:23", "name": "[libcamera-devel,v5,07/10] libcamera: make libdl optional when provided", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2824cd2c43efbe4028db7916dffbe688716e947d", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17719/mbox/", "series": [ { "id": 3583, "url": "https://patchwork.libcamera.org/api/series/3583/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3583", "date": "2022-10-28T03:17:17", "name": "[libcamera-devel,v5,01/10] ipa: workaround libcxx duration limitation", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3583/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17719/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17719/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BCD3C3286\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Oct 2022 03:17:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0A9862FD3;\n\tFri, 28 Oct 2022 05:17:43 +0200 (CEST)", "from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com\n\t[IPv6:2607:f8b0:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4964462FA6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Oct 2022 05:17:36 +0200 (CEST)", "by mail-oi1-x22d.google.com with SMTP id s125so4430956oib.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Oct 2022 20:17:36 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:293a:90ce:6463:244d])\n\tby smtp.gmail.com with ESMTPSA id\n\tfp19-20020a056870659300b0013626c1a5f6sm1527738oab.10.2022.10.27.20.17.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 27 Oct 2022 20:17:34 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666927063;\n\tbh=DdOeO4Y73eQfxf8oqth1QoKEXEDG56YIYNMB+7UXQco=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GJLiHkNKDYDwAnUtInU9Wnf+AzAcKiEFDEtEWYOzYOloqa7W9RZDR8dPVy26C9FpZ\n\tBd/5Ct7JDBsnL778Cts/6plT/+yE+jCmqSsy1lNEO9mXuTuU6Ek27HBeUVejH4Q75f\n\t+BLXVMQIIvilNFrXtqFsboWiz/+rKYJmSGxPAfaJooJATYwGdEyxxf51LdLE+bR8n6\n\tn6AzffBdghY6d7wICyti1lDwYdEfT5EulfonLtpJHaGLKVwYSKDyRWF5uXnhJdZlAq\n\t4cgPQcwBfFYITfEPyfUjGoP5M33Rq50nCQkuYbBPzGVB73i6DARXW8OvVgot4qITuD\n\t+q6+q7QJDhv8g==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=53GjDLX02zSG1mRkq78FTX8/GBMkyCcDPMdpbL8fvGw=;\n\tb=2L9GeHNWaiXwoVHke/WHjBiSvTVLmvtpDNHFlECU/hK982l0J7yJq6RPKNh2kmTcf6\n\tfi1Hpt5ifw6g2HuqdLEBzRlnYVMfq5NCjTjP+lmxw+XJz5Grmsd2TZInfRWFNx+5bMjV\n\thNyijwwhXvc76PErsian/bggAvsbMOXKdZhj+enUE6Q3hDky4lBCcWfGw3HQGN4Wt4Aw\n\t5iNs+y54i6JD21rYTM2Dxc7uvSjcAl06pL7PO8w9+BcY0ZHrp3hKL//h4QX3q8BfG/3L\n\tW8UpAE3xaK2y2DDXoV8+/xzJ1dF+ytKnlKZJ7LjCI8QwuLAuNIR/JxRLo8A1lerg9XoK\n\tg2VQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"2L9GeHNW\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=53GjDLX02zSG1mRkq78FTX8/GBMkyCcDPMdpbL8fvGw=;\n\tb=zBDi3nrWVsHJcyIydpKh+nuHEAPkUOMJGKgLz1/Nx0G+08XVudmo7ybEYK2pCAnRdl\n\tzKzVcFagFADCWKvdqhondLmA4Q6zB4RPFu9342Zg8+/wXYaRXTjKWUbPHtSkjAcxrTWf\n\tBfEwUvke9kb7POntjAK4PlTPUuQ6HH7Tam3KGmPEOLNfpFoo9hl40bitzryrk00tkcv3\n\t1Fw7JPHmRjOd8bDRBdh4+PkWlZGHricm8BFr8l8KedPuDa0CUWKk4ZfT4jlFvkkT7JaZ\n\tOCCC1F+xwappq+22uP+cHi48gv+wSPgq+hfNIh4/7pgMUHYKrGITJ4POjVsoMf+Eodc9\n\tMc8w==", "X-Gm-Message-State": "ACrzQf2I8Vu8yhkuS90TQjRzxEFEIyZUelTAwTm6AbaA/e5ObIsvTOQo\n\tB7cE0q7RulgPZez+dGf489RyPx5Ws4ZYxNxuUbw=", "X-Google-Smtp-Source": "AMsMyM5sL5j5fycTQW+6i46MhQ3txIljRJf7h8iIm6eBSlbPiVzC/ytn2VlA6Addc5Ea8z7rvwg0Aw==", "X-Received": "by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id\n\tj6-20020a056808118600b00353b77aa481mr6804390oil.199.1666927054513; \n\tThu, 27 Oct 2022 20:17:34 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Oct 2022 22:17:23 -0500", "Message-Id": "<20221028031726.4849-8-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221028031726.4849-1-nicholas@rothemail.net>", "References": "<20221027224135.348115-1-nicholas@rothemail.net>\n\t<20221028031726.4849-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 07/10] libcamera: make libdl optional\n\twhen provided", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\nCurrently, libdl is always required. Sometimes, the C++ runtime includes\na dynamic loader, which is the case for Android. Additionally, Android\n11 does not have libdl. This fix allows libcamera to build on Android.\n\nSigned-off-by: Nicholas Roth <nicholas@rothemail.net>\n---\n src/libcamera/meson.build | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 5f39d2e2..0494e808 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -65,7 +65,12 @@ subdir('ipa')\n subdir('pipeline')\n subdir('proxy')\n \n-libdl = cc.find_library('dl')\n+null_dep = dependency('', required : false)\n+\n+libdl = null_dep\n+if not cc.has_function('dlopen')\n+ libdl = cc.find_library('dl')\n+endif\n libudev = dependency('libudev', required : false)\n libyaml = dependency('yaml-0.1', required : false)\n \n", "prefixes": [ "libcamera-devel", "v5", "07/10" ] }