Patch Detail
Show a patch.
GET /api/patches/17716/?format=api
{ "id": 17716, "url": "https://patchwork.libcamera.org/api/patches/17716/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17716/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221028031726.4849-5-nicholas@rothemail.net>", "date": "2022-10-28T03:17:20", "name": "[libcamera-devel,v5,04/10] ipa: libcamera: add support for ov8858 sensor", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3956f0ba305d7437f2f80ccb601b307e33480587", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17716/mbox/", "series": [ { "id": 3583, "url": "https://patchwork.libcamera.org/api/series/3583/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3583", "date": "2022-10-28T03:17:17", "name": "[libcamera-devel,v5,01/10] ipa: workaround libcxx duration limitation", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3583/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17716/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17716/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F789C3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Oct 2022 03:17:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBE9B62FC5;\n\tFri, 28 Oct 2022 05:17:39 +0200 (CEST)", "from mail-oa1-x34.google.com (mail-oa1-x34.google.com\n\t[IPv6:2001:4860:4864:20::34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5348962FB8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Oct 2022 05:17:34 +0200 (CEST)", "by mail-oa1-x34.google.com with SMTP id\n\t586e51a60fabf-13be3ef361dso4957316fac.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Oct 2022 20:17:34 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:293a:90ce:6463:244d])\n\tby smtp.gmail.com with ESMTPSA id\n\tfp19-20020a056870659300b0013626c1a5f6sm1527738oab.10.2022.10.27.20.17.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 27 Oct 2022 20:17:32 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666927059;\n\tbh=daE6WY54HAjKlN885/mrlKW4bKHReC2Ox9JTDd8H68w=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=s3F3WCxfZbXxcpfB3WjGUFAbzwYVPSjxfcGjL+ynqCoXMd4e16dDNnSwrosf43pUU\n\tgwpCy2n9wE/B6BkKr0yrTt7rlelyQmsvwn6v/6vCAb1C3dmupto6GEU8wf6VpJM/Q9\n\tTLZpHQTMAd+ryUEZ6USPfIL5EegZHeY4Oc0j4GaA1/6QMG7Defpzo6x2CBuNPIvNll\n\tAHkyQEI2inakyi70cuITRtIcXiDJJ8Z0LK/uHsmLwEQ+lzPlHQkiSmeA8XiEnFNjej\n\tX0fLi5N096QPO0S8oq2aBCHz2LwKD7CpwbGuBpwIxBI8IEjfO5CxbL6gKT0BJf3zli\n\tngRfPYP96XZJQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=Nx/vHY66gELOXMwShEVVfeaHqV/OVGT2Ylh4eoO+CP8=;\n\tb=idayZRA8Oo+H5eNFz26dCSPThYo2A9FORMsjbhBU//WoPlwuplGrZ3YIP2/4EfvOm+\n\tvRxGv7AyeMsP+KzTqjjzsIp7Lvt/zqpWN9BGoRugZ10pofPqd/VQBVyCTkWI3+dEq4cQ\n\tXxP8HtnNdqaFekg68VhYbRrUsZN0PONXm4sOfgjVvoPVjneOfw1+dpjJUJaRYII5CYT5\n\taohosSS9lYOabU9oIJhvCcZbvGkYEgkyLAdtcqKn0n/4CgocKqS+4z7di7BWBwa2qoVu\n\tOMYUJBvvlSIJrbhKqY5Bs+hKJI0/in92+08zVnUYzx8K6q3Yvk+c+15u+hSIpo45roGz\n\tu/cA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"idayZRA8\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Nx/vHY66gELOXMwShEVVfeaHqV/OVGT2Ylh4eoO+CP8=;\n\tb=jI3vfJp2zPApW88nLryqkqZRFb09dSQj/kjb0zlt4eVcvv96Y1fR94Gr6vO2YM+P1z\n\tmCNkJulEdxjpxzwvyu6djxGI8OE5iRtzKXdLN2+CblI0Saiy/RG1gcoZ8UkNmdeapIxa\n\totS0H5bymEyQ068xctkrlaG8+uf/qMgfBo7nABZ7qIR9QzdNPPeoBSSu4WeZrQwSFKmY\n\tzGEp5K7EaZU28GTSf3WJAFDIdAfJ2ZWt3l1zRM9VszbsNDKgQric2XTbQkK3Kancph7C\n\tFf0bGYDJqu3bXARMLpuIgODlFME1gROW16GXEjygrWtIGK4LxYWDp3N1aiEE1n0fpymm\n\t0jog==", "X-Gm-Message-State": "ACrzQf16D5Z4lccE1u1NFVAdM+ByCABtpnTi7dAqJ4t/U5kOhZYOQV7K\n\tyTkdyZEfYSOr+qpp1DVBg4Z6bntmGYqVVpf0P0I=", "X-Google-Smtp-Source": "AMsMyM68lCamEXyqvEojEV0UgHjrMM7PGQuFyrJEu77I9ShQb8SR3klQ8l9LkP6EnrBnJLWI9VFm2g==", "X-Received": "by 2002:a05:6870:c0d5:b0:13a:fb98:713d with SMTP id\n\te21-20020a056870c0d500b0013afb98713dmr7665311oad.199.1666927052589; \n\tThu, 27 Oct 2022 20:17:32 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Oct 2022 22:17:20 -0500", "Message-Id": "<20221028031726.4849-5-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221028031726.4849-1-nicholas@rothemail.net>", "References": "<20221027224135.348115-1-nicholas@rothemail.net>\n\t<20221028031726.4849-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 04/10] ipa: libcamera: add support for\n\tov8858 sensor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\nCurrently, libcamera does not have information for the ov8858 sensor\nused in the PinePhone Pro, a phone designed to run Linux.\n\nThis commit adds metadata, especially that sensor gain is reported and\nset in 1/16 discrete increments.\n\nFor more information, see \"5.8 manual exposure compensation/ manual\ngain compensation\" in [0] and the driver in [1].\n\n[0] http://www.ahdsensor.com/uploadfile/202008/55322e75316871.pdf\n[1] https://github.com/megous/linux/blob/orange-pi-5.19/drivers/media/i2c/ov8858.c\n\nSigned-off-by: Nicholas Roth <nicholas@rothemail.net>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n 2 files changed, 25 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 35056bec..f2040cbd 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -476,6 +476,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n \n+class CameraSensorHelperOv8858 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv8858()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"m00_f_ov8858\", CameraSensorHelperOv8858)\n+\n class CameraSensorHelperOv8865 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex e5f27f06..d0757c15 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -146,6 +146,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"m00_f_ov8858\", {\n+\t\t\t.unitCellSize = { 1200, 1200 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t/*\n+\t\t\t\t * No best corresponding test pattern for:\n+\t\t\t\t * 1: \"Vertical Color Bar Type 1\",\n+\t\t\t\t * 2: \"Vertical Color Bar Type 2\",\n+\t\t\t\t * 3: \"Vertical Color Bar Type 3\",\n+\t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov8865\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "libcamera-devel", "v5", "04/10" ] }