Patch Detail
Show a patch.
GET /api/patches/17687/?format=api
{ "id": 17687, "url": "https://patchwork.libcamera.org/api/patches/17687/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17687/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221024055543.116040-4-nicholas@rothemail.net>", "date": "2022-10-24T05:55:35", "name": "[libcamera-devel,03/11] Adds rkisp1 metadata required for the Android HAL to use it.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6aa0a180d461b636224e0c9690792db4a44a5264", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17687/mbox/", "series": [ { "id": 3575, "url": "https://patchwork.libcamera.org/api/series/3575/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3575", "date": "2022-10-24T05:55:33", "name": "[libcamera-devel,01/11] Fixes Bug 156, which breaks libcamera on Android < 12.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3575/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17687/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17687/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAE6BC3287\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Oct 2022 05:56:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8390562F1E;\n\tMon, 24 Oct 2022 07:56:09 +0200 (CEST)", "from mail-oi1-x232.google.com (mail-oi1-x232.google.com\n\t[IPv6:2607:f8b0:4864:20::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5118C62F16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Oct 2022 07:56:05 +0200 (CEST)", "by mail-oi1-x232.google.com with SMTP id o64so9808925oib.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Oct 2022 22:56:05 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:7bc3:aed3:676f:10a0])\n\tby smtp.gmail.com with ESMTPSA id\n\tx15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.55.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 23 Oct 2022 22:55:53 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666590969;\n\tbh=1rE44FJQZfuZwwcQV9s/JuDpAcNkLpfV5OTqSPkqhtk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WEz0L1xLvC5MSm8jvJuSp6d4GkaIW6/pOAbmGMva2QWjSQS8yYyWd72IJaj2Zc7I3\n\tN90wXeymU65XxeuSz4YyLP6YoWTTZfMQ/UAfx2HiDqdeBY2G1/NMDwZYp7q4NDQV6E\n\tDg8yeOHDlac2yb/c91o4sJ/DAgGYuA+UJlWNOhfw4z8Q/aUmAmswQFVNwfxdHw/z4D\n\t8PKtikMLQLGrzwH+YnDvt13GoigTy8YJ5y+4cnImYWcAg1GPl95xQtZcsmt7FVtzKJ\n\tAjUho00bZss+YwNr+zZSSRNTBBfQ3QCo1zY2KwcSM0gE4EoSyTF74t0bxQy3q7xjwz\n\tJTfww8Qu95TmA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=TV8/l+1UakKHPjAiAmlj9NPWzyQA9lh6hT9yNy15JWM=;\n\tb=HK9b27pvieJR0l5aGVdIY0Vim0ejSTK7u05ISW+9wkJENc6QqRbzT6+I4v8HgfWbIP\n\tBMswSKDAa7CkOT1enh4pE+QRr0E98jVSc9onnD0ih3sMiqM9gqh2adf39/7q209BhRHq\n\tJVRV/h9UlDZiT5R3DEndBFHU8SQBX3gGbrHCKpwd1OK2Paz1CrUX8oLsTX4A9E/BYLTw\n\thOfK/Z3cvzLXLKn+I368HVnXkw/Z4FUx1+6v6hpvv7A6v1rxDnB+RaasUP586UNYTPsD\n\t2peLBEkjwlLdSTwijD7Q/roj6MWA81lYQvHhsDkA6Iy33XP+MLB5wNIWHHh0amksrhak\n\thqKg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"HK9b27pv\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=TV8/l+1UakKHPjAiAmlj9NPWzyQA9lh6hT9yNy15JWM=;\n\tb=K7bknSuuWACTUidDQKhhWhEPqh5kv2dvP5fEhBpIaQsHVBAESoSXFK/lDuJz4FkfAv\n\tY7O5XKc0gnufQ49NvQZtfpOji1D4qrppkybQJytI6tkSC2UBzERKlsIH5ZKaOCLQL0FQ\n\tR2zoaw2qnUXqry/Tl9Mo5lVUlhCDpmvQmE9aZ7xHwrYXGHlDz5nlAtjrQDlmPMLiv6Bc\n\t6Z2K19vh9qglZRgZppmKFccR8TRbOIE5E9WPv13eKtDSqe72sB6jdGqLMq5VGsWSDuMg\n\tpr+Tk2CJ5/klfZKDBUOAFzivo52Bl72cHy3ojtAD5DvPqfh2Q2h3TFtUdD0VhZk+Y13+\n\tasRg==", "X-Gm-Message-State": "ACrzQf25eD3KHJTabHQ0U0ltKab+53eUWk8olkR5K8qYol7DEbdcPAjl\n\ttlPISbD8DutL+sR5yJ7CCJqUL6f8Rbg70P5s", "X-Google-Smtp-Source": "AMsMyM5jiEi5zcqhOPS1gBu9XINwIAjfx9nskIAhR26caPwuEvYuxOwLuOw+pxK1eX9EKhD2zpY0QQ==", "X-Received": "by 2002:a05:6870:b407:b0:13a:f0b9:7c13 with SMTP id\n\tx7-20020a056870b40700b0013af0b97c13mr13159590oap.212.1666590953808; \n\tSun, 23 Oct 2022 22:55:53 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Oct 2022 00:55:35 -0500", "Message-Id": "<20221024055543.116040-4-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221024055543.116040-1-nicholas@rothemail.net>", "References": "<20221024055543.116040-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/11] Adds rkisp1 metadata required for\n\tthe Android HAL to use it.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\n---\n src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex ba3c547e..c536852c 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -100,6 +100,13 @@ const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n+\t/* libcamera requires a fixed value for minimum frame duration,\n+\t * but this depends on the frame size and the rkisp1 device datasheets\n+\t * measure this in pixels per second. Neither the datasheets nor the driver\n+\t * specify a maximum. The minimum below is for 1920x1920. The maximum\n+\t * corresponds to two seconds. */\n+\t{ &controls::FrameDurationLimits, ControlInfo(48505, 2000000) },\n+\t{ &controls::draft::MaxLatency, ControlInfo(0) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n };\n \n", "prefixes": [ "libcamera-devel", "03/11" ] }