Patch Detail
Show a patch.
GET /api/patches/17683/?format=api
{ "id": 17683, "url": "https://patchwork.libcamera.org/api/patches/17683/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17683/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221024055543.116040-9-nicholas@rothemail.net>", "date": "2022-10-24T05:55:40", "name": "[libcamera-devel,08/11] Removes code to force using libc++ instead of libstdc++ if available.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0b0abef34dce284f4324db4135959a2e24afad8b", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17683/mbox/", "series": [ { "id": 3575, "url": "https://patchwork.libcamera.org/api/series/3575/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3575", "date": "2022-10-24T05:55:33", "name": "[libcamera-devel,01/11] Fixes Bug 156, which breaks libcamera on Android < 12.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3575/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17683/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17683/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DC2FBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Oct 2022 05:56:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18E5162F14;\n\tMon, 24 Oct 2022 07:56:05 +0200 (CEST)", "from mail-oa1-x32.google.com (mail-oa1-x32.google.com\n\t[IPv6:2001:4860:4864:20::32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76D3862EF6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Oct 2022 07:56:00 +0200 (CEST)", "by mail-oa1-x32.google.com with SMTP id\n\t586e51a60fabf-13b6336a1acso5277829fac.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Oct 2022 22:56:00 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:7bc3:aed3:676f:10a0])\n\tby smtp.gmail.com with ESMTPSA id\n\tx15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.55.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 23 Oct 2022 22:55:58 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666590965;\n\tbh=mvpp/AXcH55Ihc+1iO4nWkuuHc7yyAOzRS0UYe/7Ntg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uiysZaaJFD/RqoaKrjiXBD70xEHP9SJDTsNyD/Dp7ndD8eboZCiK9rD2Ivfly9XzV\n\tvj3wGWok6HYSEsCqF7Z0EFtwdGVqgW3tmwAM0jqCvuiPzrQYuSGpNOWzkaJknBoesV\n\t0v5IU0Xv3A879plqGRK/bVXAXOQVCsqHO7+P6xRevYf8lIZAnSX7ed4W6gllL0xEb2\n\toXhNEaLj5Or3q00mzFvJFohZDFIRQOrLqAeWZMIs6dmPqL+K5ZQN8c2QZHjR1KYxbc\n\tc5tOsTned8XItgqWISvU3/v6hYXC5Bo7uc4vfHjIMCR5y9+9xolENSfUGvg9e5XwI5\n\ttGJFiA6Jmbj6w==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=bFCDFBN6Gu/UE2X3RBv2GIgJlscealx/uenvhEnHRRg=;\n\tb=kFRE5TUDKLUYYct2WCwYa+rOP5d7zVb7hh04RSf1g6amQUZXbbEw4dHaQO+2aPLYO9\n\tGTvBenbLA6cnGgNgdE3D/xAsrCQW6+uXuI8/Hx9jDlaTqkcCEmElM8GqT0Sc5bXvsa0g\n\tCnLLyiYWL11ZXMYiubiaWFQn2LQsXc+/FbcntzOR6SoFKbbPJVQ9OFMuoFU4lvXGCCoS\n\tJr28pDEIytjJnMvxfpB+EUYhuyD9YmbIO6VKIPH1cT0WVBawsYEsBlgGNviP5/dFSTmM\n\taY0m3Guhzjfs8aWR57q2mBHa7iWcbny20mK9Fqgsd46v45SvtvTS6QAvmMkkbg0pC3E/\n\t02XQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"kFRE5TUD\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=bFCDFBN6Gu/UE2X3RBv2GIgJlscealx/uenvhEnHRRg=;\n\tb=VPjQHwu1K92XWLyds6bRlzBwh7fib5wwxrRvr11wMC/fFwkL2C1fAw//pE1lalrzAO\n\tNhkbgYv1h9XXnvu6T6tAQdHpKrdZtmD4czpvaxzngKB79So7nNMSfZ/Xe05L7LiR4NQR\n\tfnSqXC8u8q0l7qPjbG/kbrHVaXP/bPAXKPo94FyDvYu1cAU8GTgLG1QOAK2gp6HDaXRX\n\tAV4+nGCzjq9UAtmkQoSYeJa+opiobJR+dbGU12wtnGNtyYTyYZtjICP6DXAqzjKhPu9Y\n\tNS+9yu84cXIbjNduoIYKYeVlO3WyRCvQFgOOjCEmCX9N6jBgqfIC4Xr7iNmCdm3GmPmq\n\tzoNQ==", "X-Gm-Message-State": "ACrzQf3wicIU5Lo3FdgP2ypFXksAcUDGUyhmJEynuLI4/J0q6G4vNovW\n\tww7BGSKxvuImlE5TfaXkxNRbsJNY3LYjw35/", "X-Google-Smtp-Source": "AMsMyM6RXbC4ki2SgoM9C4K+U4UlNT/NZSm60XmDS/9A5lSxRdIiiI4MRq/G71ZO7110MdIG67WW7w==", "X-Received": "by 2002:a05:6870:c147:b0:136:90c4:ee84 with SMTP id\n\tg7-20020a056870c14700b0013690c4ee84mr19875058oad.295.1666590958766; \n\tSun, 23 Oct 2022 22:55:58 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Oct 2022 00:55:40 -0500", "Message-Id": "<20221024055543.116040-9-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221024055543.116040-1-nicholas@rothemail.net>", "References": "<20221024055543.116040-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 08/11] Removes code to force using libc++\n\tinstead of libstdc++ if available.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\nThis breaks during cross-compilation when this is not true for the\nmeson-cross cross-compiler target.\n\nError:\nclang++: error: argument unused during compilation: '-stdlib=libc++' [-Werror,-Wunused-command-line-argument]\n---\n meson.build | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 56910698..7d0588d2 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -95,14 +95,6 @@ if cc.get_id() == 'clang'\n ]\n endif\n \n- # Use libc++ by default if available instead of libstdc++ when compiling\n- # with clang.\n- if cc.find_library('libc++', required: false).found()\n- cpp_arguments += [\n- '-stdlib=libc++',\n- ]\n- endif\n-\n cpp_arguments += [\n '-Wextra-semi',\n '-Wthread-safety',\n", "prefixes": [ "libcamera-devel", "08/11" ] }