Patch Detail
Show a patch.
GET /api/patches/17649/?format=api
{ "id": 17649, "url": "https://patchwork.libcamera.org/api/patches/17649/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17649/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221019231537.26880-6-laurent.pinchart@ideasonboard.com>", "date": "2022-10-19T23:15:36", "name": "[libcamera-devel,v1,5/6] apps: Move libtiff dependency to src/apps/meson.build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "66a26052265c28b6163bd2ce0a02de2e0dc66977", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17649/mbox/", "series": [ { "id": 3571, "url": "https://patchwork.libcamera.org/api/series/3571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3571", "date": "2022-10-19T23:15:31", "name": "apps: Avoid duplicate compilation of common code", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17649/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17649/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9414FC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 23:16:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 492B462E8D;\n\tThu, 20 Oct 2022 01:16:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 784BE62E7D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:12 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 149CF8BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:11 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666221376;\n\tbh=vtw9zoSqNVO395XdNhpi1zojOF0HCncIvVluewn+jWM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=01rMaOXUT/guaAEal/snFy3IUK7Izsa2H9gmI26rJxrubHEJFoYpF9uzOxtwSnwh2\n\tiacmKnSy0qYFtb3v4b7i5rkSQ4dJGvBPgeD7/FTlmieXt6txmoKYcuBEDWf8XQ0ImI\n\toB38RXTzmuyCJ5OIwEYgqdjaTu6xa9talH5k9CXCyT/13as7upO7QqUcduwZzjVmem\n\txjtVtrBoQr+Hrzgnpyb+DiQ074bpFfXOwaPp7cSwoWehBMDMxcFT3qvk4X3jMKQ4zz\n\tJ1gT+La4SIqsRlaxwnyp/koN9xhhBX0sL9cmSrUL6xxMn+MrixsDUpVoG/zWTvkLUL\n\t469YsUycN6DeA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666221372;\n\tbh=vtw9zoSqNVO395XdNhpi1zojOF0HCncIvVluewn+jWM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=LhBTwT/u2Q36R76gppwsc0tm0arPd7leTJAf8u8NXoLP2GAGQsYYyt6DJHbVpHtH2\n\t2/2PVtUg60GWbkiaJR+gm69hmHUY/uz/L161Cuj9h5/Ox5UPn+19mGbaP67ZEHNRy3\n\tiTGQcVfRKIhggs6syqpvdGInpS3SA+Ux34b5omM8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LhBTwT/u\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 20 Oct 2022 02:15:36 +0300", "Message-Id": "<20221019231537.26880-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.3", "In-Reply-To": "<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>", "References": "<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 5/6] apps: Move libtiff dependency to\n\tsrc/apps/meson.build", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libtiff is a shared dependency between cam and qcam, move it to\nsrc/apps/. The shared dependency will be used to condition compilation\nof source files in an upcoming application static library.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/cam/meson.build | 1 -\n src/apps/meson.build | 2 ++\n src/apps/qcam/meson.build | 5 ++---\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\nindex 4b6099ddab63..297de64fbdd9 100644\n--- a/src/apps/cam/meson.build\n+++ b/src/apps/cam/meson.build\n@@ -24,7 +24,6 @@ cam_cpp_args = []\n libdrm = dependency('libdrm', required : false)\n libjpeg = dependency('libjpeg', required : false)\n libsdl2 = dependency('SDL2', required : false)\n-libtiff = dependency('libtiff-4', required : false)\n \n if libdrm.found()\n cam_cpp_args += [ '-DHAVE_KMS' ]\ndiff --git a/src/apps/meson.build b/src/apps/meson.build\nindex 159deb0b7fc2..95f1f5190c7a 100644\n--- a/src/apps/meson.build\n+++ b/src/apps/meson.build\n@@ -8,6 +8,8 @@ if not libevent.found()\n libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n endif\n \n+libtiff = dependency('libtiff-4', required : false)\n+\n subdir('lc-compliance')\n \n subdir('cam')\ndiff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\nindex d5916d0df532..e298101e2c43 100644\n--- a/src/apps/qcam/meson.build\n+++ b/src/apps/qcam/meson.build\n@@ -38,8 +38,7 @@ qcam_resources = files([\n \n qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n \n-tiff_dep = dependency('libtiff-4', required : false)\n-if tiff_dep.found()\n+if libtiff.found()\n qt5_cpp_args += ['-DHAVE_TIFF']\n qcam_sources += files([\n '../cam/dng_writer.cpp',\n@@ -77,7 +76,7 @@ qcam = executable('qcam', qcam_sources, resources,\n dependencies : [\n libatomic,\n libcamera_public,\n+ libtiff,\n qt5_dep,\n- tiff_dep,\n ],\n cpp_args : qt5_cpp_args)\n", "prefixes": [ "libcamera-devel", "v1", "5/6" ] }