Patch Detail
Show a patch.
GET /api/patches/17648/?format=api
{ "id": 17648, "url": "https://patchwork.libcamera.org/api/patches/17648/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17648/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>", "date": "2022-10-19T23:15:35", "name": "[libcamera-devel,v1,4/6] apps: Move libevent dependency to src/apps/meson.build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "24b09ea1f7ab34efebd76a7e5f6ffb721cd1f7df", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17648/mbox/", "series": [ { "id": 3571, "url": "https://patchwork.libcamera.org/api/series/3571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3571", "date": "2022-10-19T23:15:31", "name": "apps: Avoid duplicate compilation of common code", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17648/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17648/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28E98C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 23:16:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D408162E88;\n\tThu, 20 Oct 2022 01:16:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC3B562E85\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:10 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05191570\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:09 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666221372;\n\tbh=JgLFQNzIPIcxyqgtZh5197RCEK8oDH5JtjYJET0ajaA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=kzyvjoReY8wa/NHR8eyPMQDfs9mA1pZEdDyrLnsrUt3Xx/u7W5rMRKFdE859u6nIa\n\tYkoHPfZz6NJC/EDI+aOxVOiOuOH1cu04lwRTUmyoKpxH5JkKzv76u5qdexgJDB5Cbr\n\t+9WuBX4Rm+hSXoEZ/AIkYMw7NM7HjzSzOo7fQ/ysyWIrxdegl1ugp4SxoEPw+T6Dzi\n\tCX3Lu4quhoCMYoiNVI5DqOkooj1SivT0c03PplshDw+E3d7UEavNVMo3QHucKnknKN\n\thSmMtTtj5h9J2XUdMfyoP8kvCfio7+sjJGJvxWvW9DMd8uKty77cchujb6QNyMGGBo\n\tNkbSbVKItG31A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666221370;\n\tbh=JgLFQNzIPIcxyqgtZh5197RCEK8oDH5JtjYJET0ajaA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=b04G2RFfKCh9oXRFqqkZgYIltCxecVW3Rucac5KjHbiSdzVovujJowAH5gBrVtpCQ\n\tP+Y1nvH5vupEJ6Vo7a1kDQaUHTPRZ7Un2AG+hPQFQq0qNXXUcYrnp57rrnw2fkfDkk\n\tZB14TbqF+ijtrWxDFicylCyxhr3DsMgLBu95LK6Q=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"b04G2RFf\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 20 Oct 2022 02:15:35 +0300", "Message-Id": "<20221019231537.26880-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.3", "In-Reply-To": "<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>", "References": "<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 4/6] apps: Move libevent dependency to\n\tsrc/apps/meson.build", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libtiff is a shared dependency between cam and lc-compliance, move it to\nsrc/apps/. The shared dependency will be used to condition compilation\nof source files in an upcoming application static library.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/cam/meson.build | 4 +---\n src/apps/lc-compliance/meson.build | 3 +--\n src/apps/meson.build | 8 ++++++++\n 3 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\nindex 06dbea0645b7..4b6099ddab63 100644\n--- a/src/apps/cam/meson.build\n+++ b/src/apps/cam/meson.build\n@@ -1,8 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-libevent = dependency('libevent_pthreads', required : get_option('cam'))\n-\n-if not libevent.found()\n+if opt_cam.disabled() or not libevent.found()\n cam_enabled = false\n subdir_done()\n endif\ndiff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\nindex 8b57474be2b2..05d622be0a40 100644\n--- a/src/apps/lc-compliance/meson.build\n+++ b/src/apps/lc-compliance/meson.build\n@@ -1,10 +1,9 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n libgtest = dependency('gtest', required : get_option('lc-compliance'),\n fallback : ['gtest', 'gtest_dep'])\n \n-if not (libevent.found() and libgtest.found())\n+if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n lc_compliance_enabled = false\n subdir_done()\n endif\ndiff --git a/src/apps/meson.build b/src/apps/meson.build\nindex 9e4388bd7881..159deb0b7fc2 100644\n--- a/src/apps/meson.build\n+++ b/src/apps/meson.build\n@@ -1,5 +1,13 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+opt_cam = get_option('cam')\n+opt_lc_compliance = get_option('lc-compliance')\n+\n+libevent = dependency('libevent_pthreads', required : opt_cam)\n+if not libevent.found()\n+ libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n+endif\n+\n subdir('lc-compliance')\n \n subdir('cam')\n", "prefixes": [ "libcamera-devel", "v1", "4/6" ] }