Patch Detail
Show a patch.
GET /api/patches/17638/?format=api
{ "id": 17638, "url": "https://patchwork.libcamera.org/api/patches/17638/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17638/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221019114143.479093-1-paul.elder@ideasonboard.com>", "date": "2022-10-19T11:41:43", "name": "[libcamera-devel] utils: raspberrypi: ctt: Fix alsc green averaging", "commit_ref": "c8e6b114f023595595d52098bc01bcfca279295d", "pull_url": null, "state": "accepted", "archived": false, "hash": "e56065262a086eef12fa700400c64f79cbc44649", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17638/mbox/", "series": [ { "id": 3568, "url": "https://patchwork.libcamera.org/api/series/3568/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3568", "date": "2022-10-19T11:41:43", "name": "[libcamera-devel] utils: raspberrypi: ctt: Fix alsc green averaging", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3568/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17638/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17638/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A011C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 11:42:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C512C62DFA;\n\tWed, 19 Oct 2022 13:41:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6785A62DFA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Oct 2022 13:41:58 +0200 (CEST)", "from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE0145A4;\n\tWed, 19 Oct 2022 13:41:56 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666179719;\n\tbh=F1Gkgb7lvFUF2jwLCrk43RD7/k0Fqqk3uMaTgeRwmM8=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=sZSMukAwcdT/5xBkMSN4kCvwheZprYDzlt/C4av8ZZo9RoPI8uEyJkM0XUaoB9yP2\n\td3Xt4VgiH2GvaE95rARd4LaFDboMAUccy7bmo8bX1n/o2YSzFbZ3b7n9XyVOQMbIFn\n\tn5Zs7VFAPcj4/2+T8RzbWNRmiY04C5SJ7o4kA6My8Jx89dhiGCpc8/5uUsXhs/36Bm\n\thZY9Mz6NN/3+k3KVfZ2pgKvQxQD2vkbEd6U8Pr2PhJHgrMb58xtXTQrZmT7z+/XfOu\n\t0nA/y4O3iW16apR91TjXtihZ2gmG8NsdeWKi7yDbyIlK8hgLQcGMeUcY+hE/faBhkq\n\tJ5PKXP4XgI2gw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666179718;\n\tbh=F1Gkgb7lvFUF2jwLCrk43RD7/k0Fqqk3uMaTgeRwmM8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Xxni9UsXP4yj3D9Wa2gAFwZ1lv9y6xPGQ493GywMTrqnGq5BUJu8uQyVY0nM9LZPy\n\tw6rk0IhpGIp5pR40tpyC4rZeea6BsAZGuCqsG7YDe6nGjpy5VF3/o/MqKUid+NJ0ip\n\tjEjURYmQmz5I9SgmqHYqGt8CqwLwu1UE+eCgnm20=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Xxni9UsX\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 19 Oct 2022 20:41:43 +0900", "Message-Id": "<20221019114143.479093-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] utils: raspberrypi: ctt: Fix alsc green\n\taveraging", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The alsc component of ctt meant to average the two green channels into\none, but used incorrect indexing resulting in only the first green\nchannel being used. Fix this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n utils/raspberrypi/ctt/ctt_alsc.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/raspberrypi/ctt/ctt_alsc.py b/utils/raspberrypi/ctt/ctt_alsc.py\nindex c0ba7b63..e51d6931 100644\n--- a/utils/raspberrypi/ctt/ctt_alsc.py\n+++ b/utils/raspberrypi/ctt/ctt_alsc.py\n@@ -132,7 +132,7 @@ def alsc(Cam, Img, do_alsc_colour, plot=False):\n \"\"\"\n average the green channels into one\n \"\"\"\n- av_ch_g = np.mean((channels[1:2]), axis=0)\n+ av_ch_g = np.mean((channels[1:3]), axis=0)\n if do_alsc_colour:\n \"\"\"\n obtain 16x12 grid of intensities for each channel and subtract black level\n", "prefixes": [ "libcamera-devel" ] }