Patch Detail
Show a patch.
GET /api/patches/17622/?format=api
{ "id": 17622, "url": "https://patchwork.libcamera.org/api/patches/17622/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17622/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221018093449.3165709-1-paul.elder@ideasonboard.com>", "date": "2022-10-18T09:34:49", "name": "[libcamera-devel] ipc: ipa_data_serializer: Use cend() in deserializers", "commit_ref": "ca247829c3feea28d65b181fd0a5f76ff7120a15", "pull_url": null, "state": "accepted", "archived": false, "hash": "48d091d52cfb57b6bafda31a79ab6de4093d95f8", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17622/mbox/", "series": [ { "id": 3563, "url": "https://patchwork.libcamera.org/api/series/3563/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3563", "date": "2022-10-18T09:34:49", "name": "[libcamera-devel] ipc: ipa_data_serializer: Use cend() in deserializers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3563/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17622/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17622/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E43FBC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Oct 2022 09:35:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 499E662E16;\n\tTue, 18 Oct 2022 11:35:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 421B862DD1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Oct 2022 11:34:58 +0200 (CEST)", "from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D59AF6F3;\n\tTue, 18 Oct 2022 11:34:56 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666085700;\n\tbh=8XrFa1Qx3T+LO+RGxcaw/IFr36pdTXJQ+0A8zP9UWFc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Spk8a4YCamLmCapBI2m+7JdOAqw4DSDm+0ffn0yN722V3Z6z+sUdSPs8P3hUlXDgs\n\t7WL9p0GABCvgTyRv1AKTNEFyvjql0MO0oh/SlVF4Ij0wEB7jySbao5AgUCNHAgODbp\n\t+dxATliddtT8BmkjMtcY/gI7B+l7QVVWhhl29E76tbeqHbh3Lgvf3lrwRizcidkVgw\n\t7ngJ68n6fvpJy3fD3d0hofKxZyCMZv2m9P7j/WTUUAkabx6Q49kCaEH1/zvHu3/+EB\n\tKN7rrcPTLTLIhX69hGjEPd1EI58rNh6I1hYHP3vJa2IuSuPCB2Rtc9V1D7h2XFeJJz\n\tNnKRlDAhtBDKg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666085697;\n\tbh=8XrFa1Qx3T+LO+RGxcaw/IFr36pdTXJQ+0A8zP9UWFc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=fnsOGz7kjoIAuglpgSS2hVk4PliPS+K5uPnUpSMhHZ54eSJrCP0o/YGAQkOLtrwig\n\tmu2qwv2EdoJowPGR13yIRyndSsbCuFWj6nfJWofR/cIX+Wyqz3TmnAKJT6blNhEVWW\n\tZd/CCpQpE156qdC8OWF4otFNRyxWL+gA64gxqne8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fnsOGz7k\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 18 Oct 2022 18:34:49 +0900", "Message-Id": "<20221018093449.3165709-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipc: ipa_data_serializer: Use cend() in\n\tdeserializers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The overloaded deserializers functions that called the main deserializer\nfunction using iterators used cbegin() but end() instead of cend(). Make\nall of these use cend() instead.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/ipa_data_serializer.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 30bdaebc..54895b87 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -134,7 +134,7 @@ public:\n \n \tstatic std::vector<V> deserialize(std::vector<uint8_t> &data, ControlSerializer *cs = nullptr)\n \t{\n-\t\treturn deserialize(data.cbegin(), data.end(), cs);\n+\t\treturn deserialize(data.cbegin(), data.cend(), cs);\n \t}\n \n \tstatic std::vector<V> deserialize(std::vector<uint8_t>::const_iterator dataBegin,\n@@ -142,13 +142,13 @@ public:\n \t\t\t\t\t ControlSerializer *cs = nullptr)\n \t{\n \t\tstd::vector<SharedFD> fds;\n-\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.end(), cs);\n+\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.cend(), cs);\n \t}\n \n \tstatic std::vector<V> deserialize(std::vector<uint8_t> &data, std::vector<SharedFD> &fds,\n \t\t\t\t\t ControlSerializer *cs = nullptr)\n \t{\n-\t\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n+\t\treturn deserialize(data.cbegin(), data.cend(), fds.cbegin(), fds.cend(), cs);\n \t}\n \n \tstatic std::vector<V> deserialize(std::vector<uint8_t>::const_iterator dataBegin,\n@@ -240,7 +240,7 @@ public:\n \n \tstatic std::map<K, V> deserialize(std::vector<uint8_t> &data, ControlSerializer *cs = nullptr)\n \t{\n-\t\treturn deserialize(data.cbegin(), data.end(), cs);\n+\t\treturn deserialize(data.cbegin(), data.cend(), cs);\n \t}\n \n \tstatic std::map<K, V> deserialize(std::vector<uint8_t>::const_iterator dataBegin,\n@@ -248,13 +248,13 @@ public:\n \t\t\t\t\t ControlSerializer *cs = nullptr)\n \t{\n \t\tstd::vector<SharedFD> fds;\n-\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.end(), cs);\n+\t\treturn deserialize(dataBegin, dataEnd, fds.cbegin(), fds.cend(), cs);\n \t}\n \n \tstatic std::map<K, V> deserialize(std::vector<uint8_t> &data, std::vector<SharedFD> &fds,\n \t\t\t\t\t ControlSerializer *cs = nullptr)\n \t{\n-\t\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n+\t\treturn deserialize(data.cbegin(), data.cend(), fds.cbegin(), fds.cend(), cs);\n \t}\n \n \tstatic std::map<K, V> deserialize(std::vector<uint8_t>::const_iterator dataBegin,\n", "prefixes": [ "libcamera-devel" ] }