Patch Detail
Show a patch.
GET /api/patches/17613/?format=api
{ "id": 17613, "url": "https://patchwork.libcamera.org/api/patches/17613/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17613/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221017171741.3803909-2-paul.elder@ideasonboard.com>", "date": "2022-10-17T17:17:39", "name": "[libcamera-devel,1/3] qcam, cam: Move DNGWriter from qcam to cam", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "82451ff4ed5896d120941b07ab0ffb7e6a611ce4", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17613/mbox/", "series": [ { "id": 3559, "url": "https://patchwork.libcamera.org/api/series/3559/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3559", "date": "2022-10-17T17:17:38", "name": "cam: Add DNG support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3559/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17613/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17613/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12238BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Oct 2022 17:17:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA3F462E06;\n\tMon, 17 Oct 2022 19:17:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D95BC62DF7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Oct 2022 19:17:55 +0200 (CEST)", "from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 618071056;\n\tMon, 17 Oct 2022 19:17:54 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666027077;\n\tbh=Dynt4aSTrF/HPAJjzwj+8JFdVMDMnt0Iv/0JnnaSnPE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0mdu2ALML+xwEVgeDMEyLtawsjBbSIqfz1JHZXTY5EP8MiJ8sC8sMF1h/hDkSMLlR\n\tY27V+Z7pYwuxrRF5ehuNtlwL+PAB+tkxIFfkPPWm3t5d9d6Cc0jRbR77L8RdirqwKz\n\treexLUgKZNB9U0VcQlfH5QKjr9JChwJDQpOtw1TRvAO1kg56tuUe1QkNA1vdItw4/B\n\tJBcwg+cha/bwRODHLrKFEejy11rbXZ23TRUIcZiKcl6qWGqNarvKEqFtEPa503frZ/\n\trHkCupV5onaqZgia8U3dWEGfjFAQJHvVWWCeIFIoqlaBzLnJs0m192bq2a+/7lQvSk\n\t/xjFEWqcLa3ug==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666027075;\n\tbh=Dynt4aSTrF/HPAJjzwj+8JFdVMDMnt0Iv/0JnnaSnPE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mRwWkaJ3evt19j2hszmi5ZBlSQXLrFH0QE3V87pv9Gmj5i3WCNFt8wyQGgrAl5nPA\n\tBlfakBZpMAkBaMwPyLOxnptTbfxfrpNOjy+x7ByV/1V/KKngYgHIDBcD7X9oDVCV0y\n\typYuJSVQCtmzq13UvWrDySxo4gumZUTL5zOmn6So=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mRwWkaJ3\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 18 Oct 2022 02:17:39 +0900", "Message-Id": "<20221017171741.3803909-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221017171741.3803909-1-paul.elder@ideasonboard.com>", "References": "<20221017171741.3803909-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] qcam,\n\tcam: Move DNGWriter from qcam to cam", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for adding DNG support to cam, move DNGWriter from qcam to\ncam so that we only have inclusions from qcam to cam and not the other\nway around.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/{qcam => cam}/dng_writer.cpp | 0\n src/{qcam => cam}/dng_writer.h | 0\n src/cam/meson.build | 9 +++++++++\n src/qcam/main_window.cpp | 2 +-\n src/qcam/meson.build | 2 +-\n 5 files changed, 11 insertions(+), 2 deletions(-)\n rename src/{qcam => cam}/dng_writer.cpp (100%)\n rename src/{qcam => cam}/dng_writer.h (100%)", "diff": "diff --git a/src/qcam/dng_writer.cpp b/src/cam/dng_writer.cpp\nsimilarity index 100%\nrename from src/qcam/dng_writer.cpp\nrename to src/cam/dng_writer.cpp\ndiff --git a/src/qcam/dng_writer.h b/src/cam/dng_writer.h\nsimilarity index 100%\nrename from src/qcam/dng_writer.h\nrename to src/cam/dng_writer.h\ndiff --git a/src/cam/meson.build b/src/cam/meson.build\nindex 8259239f..06dbea06 100644\n--- a/src/cam/meson.build\n+++ b/src/cam/meson.build\n@@ -26,6 +26,7 @@ cam_cpp_args = []\n libdrm = dependency('libdrm', required : false)\n libjpeg = dependency('libjpeg', required : false)\n libsdl2 = dependency('SDL2', required : false)\n+libtiff = dependency('libtiff-4', required : false)\n \n if libdrm.found()\n cam_cpp_args += [ '-DHAVE_KMS' ]\n@@ -51,6 +52,13 @@ if libsdl2.found()\n endif\n endif\n \n+if libtiff.found()\n+ cam_cpp_args += ['-DHAVE_TIFF']\n+ cam_sources += files([\n+ 'dng_writer.cpp',\n+ ])\n+endif\n+\n cam = executable('cam', cam_sources,\n dependencies : [\n libatomic,\n@@ -59,6 +67,7 @@ cam = executable('cam', cam_sources,\n libevent,\n libjpeg,\n libsdl2,\n+ libtiff,\n libyaml,\n ],\n cpp_args : cam_cpp_args,\ndiff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex e0e5092e..f553ccb0 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -26,10 +26,10 @@\n #include <QToolButton>\n #include <QtDebug>\n \n+#include \"../cam/dng_writer.h\"\n #include \"../cam/image.h\"\n \n #include \"cam_select_dialog.h\"\n-#include \"dng_writer.h\"\n #ifndef QT_NO_OPENGL\n #include \"viewfinder_gl.h\"\n #endif\ndiff --git a/src/qcam/meson.build b/src/qcam/meson.build\nindex 61861ea6..9f5759ff 100644\n--- a/src/qcam/meson.build\n+++ b/src/qcam/meson.build\n@@ -49,7 +49,7 @@ if tiff_dep.found()\n qt5_cpp_args += ['-DHAVE_TIFF']\n qcam_deps += [tiff_dep]\n qcam_sources += files([\n- 'dng_writer.cpp',\n+ '../cam/dng_writer.cpp',\n ])\n endif\n \n", "prefixes": [ "libcamera-devel", "1/3" ] }