Patch Detail
Show a patch.
GET /api/patches/17607/?format=api
{ "id": 17607, "url": "https://patchwork.libcamera.org/api/patches/17607/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17607/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221014164630.2847301-1-kieran.bingham@ideasonboard.com>", "date": "2022-10-14T16:46:30", "name": "[libcamera-devel] meson: Rewrite .replace usage", "commit_ref": "02518e598e8f057b76a08940e1bc8a99d879fad6", "pull_url": null, "state": "accepted", "archived": false, "hash": "98c53de10253ef340796aeb33827d19cc4c3617f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17607/mbox/", "series": [ { "id": 3556, "url": "https://patchwork.libcamera.org/api/series/3556/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3556", "date": "2022-10-14T16:46:30", "name": "[libcamera-devel] meson: Rewrite .replace usage", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3556/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17607/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17607/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6D76C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 14 Oct 2022 16:46:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04A5B62DC2;\n\tFri, 14 Oct 2022 18:46:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B196662D8E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Oct 2022 18:46:34 +0200 (CEST)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12A856DE;\n\tFri, 14 Oct 2022 18:46:34 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665765996;\n\tbh=EQfA1JafmskkUdereEO/M+gJCaboYN9SrrfEdH1WRzc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=ZKCWOBD8y2B3BlJvfYy0AYVhQX4UUiaaRm5lisZ0+sDBh7K2vVnjaex3fpk5f2o88\n\tabNy0T5loI+3NsrnWlIuxbxcSUEJnydlv/tVrjtxJz1q8K7fgfXEqMf3yetZ0Wc4g+\n\tmdUY1FbWO/b3aFhz7rYenvuUF3Od+VEoq0M695/Kk9DWdNtWvJq6WvFGDfABGqLWpc\n\tZCfn4tQumQ3KlfzJeovVRIcVOglRp7O3KguE5eD43TbTyKBRkJZGYgr1oSmfzeu2Jg\n\trpAMm9vFcm/90Dtwc8qL6BxncD/1/wLOHTPmPxw6v3UdxqFvmUiQA5x6SSh/a632kd\n\tUzU2gw5I5BEcA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665765994;\n\tbh=EQfA1JafmskkUdereEO/M+gJCaboYN9SrrfEdH1WRzc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=KOuSAn4TAV5A5WIQ1p6AHcStwl0BaNJyLJ/H6/ce3SCMbnHCMpLApHKEmIEsAQovF\n\tsi/cw8bo9lxs3WEMoxU3EtHDWwobOphj1gOymC/V7bZN/8xaZ/Fk3pIlNHcyu8z9sm\n\tM+AnL75PGstdtSbS4Am0KQhr8eZz2BUdNc0ltqEw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KOuSAn4T\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 14 Oct 2022 17:46:30 +0100", "Message-Id": "<20221014164630.2847301-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] meson: Rewrite .replace usage", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Meson introduces a .replace() method in version 0.58.0. However we aim\nto restrict ourselves to 0.56 meson features, as released by Debian\nstable.\n\nThe recent introduction of release management infrastructure makes use\nof the .replace() method to fix up the version string when there is a\nmis-match between the release version and any (lack) of tags in the git\nversion description. This breaks when built on systems with only meson\n0.56.\n\nRefactor this to use a concatenation of the project version and a\nstripped git version to regenerate the full source version string that\nwill be reported by libcamera.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n meson.build | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 56910698988d..f218b8c2b296 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -38,8 +38,10 @@ if libcamera_version != meson.project_version()\n },\n bool_yn : true, section : 'Versions')\n \n- libcamera_git_version = libcamera_git_version.replace(libcamera_version,\n- meson.project_version())\n+ # Replace the version components reported by git with the release version,\n+ # but keep all trailing information supplied by git.\n+ libcamera_git_version = (meson.project_version() +\n+ libcamera_git_version.strip(libcamera_version))\n libcamera_version = meson.project_version()\n \n # Append a marker to show we have modified this version string\n", "prefixes": [ "libcamera-devel" ] }