Patch Detail
Show a patch.
GET /api/patches/17574/?format=api
{ "id": 17574, "url": "https://patchwork.libcamera.org/api/patches/17574/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17574/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221010173214.3547133-3-kieran.bingham@ideasonboard.com>", "date": "2022-10-10T17:32:11", "name": "[libcamera-devel,v3,2/5] meson: Shared Object version handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a85c7860f72d1388dbf12b03273e3f3b207ea85", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17574/mbox/", "series": [ { "id": 3550, "url": "https://patchwork.libcamera.org/api/series/3550/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3550", "date": "2022-10-10T17:32:09", "name": "Add release infrastructure", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3550/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17574/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17574/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A53BFC3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Oct 2022 17:33:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A4B562D78;\n\tMon, 10 Oct 2022 19:33:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C201F62D6B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Oct 2022 19:33:23 +0200 (CEST)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C78EBB0;\n\tMon, 10 Oct 2022 19:33:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665423205;\n\tbh=pitq57k3xQLLB3p0hzEY5XESU1yZjwMqr/stW6Su0iI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=zYKVc62nNOdULaVOZOY/O7lilTDyF9Rn65w/xZFX8PzLqMVMiTSsbV0qU1dYL7QL1\n\tpjQAm9dHCNnfF9NZARQggF57REQVTP5nDGyjaLXNwCvNWfaUbiJcQbyAKy84NThGot\n\tvxb92ioM0ohQhOplNG2HuRybzvX+/HgIlQZzZF7YQuSp2zkB3nwfAt7uTTgRQQLqTz\n\t5joc/KKJvpYeAy/4u1PwBhBoEnJEO1QJvFQaczYxn6aM4OA+xXm+xV2FjPacJ6w0Eh\n\tU3GRuUUo9GJLCTTpHtBNVpmB1g4aTDBmdY8+MXq4BoLZlG0vMnxdRlc29CupsQH86u\n\tj5rThsfhlr9/g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665423203;\n\tbh=pitq57k3xQLLB3p0hzEY5XESU1yZjwMqr/stW6Su0iI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Dk/3nu9H1V3Ebrg5xvPUozEtqSczbNtyEElkyRJAeVmWS1AxYZyuR/4QW+aq658yj\n\tR6p2859vEXkSUL86lRQsDa+J1dVOURfHFzkXULu4P1vL5lrvvQ8QuOu/qbkuaT2btj\n\t3rauhbYK1FQfyb+/8gzgFc6TwzHk3K7TxdMyPZIs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dk/3nu9H\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 10 Oct 2022 18:32:11 +0100", "Message-Id": "<20221010173214.3547133-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221010173214.3547133-1-kieran.bingham@ideasonboard.com>", "References": "<20221010173214.3547133-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/5] meson: Shared Object version\n\thandling", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera project is not yet ready to declare ABI nor API stability,\nbut it will benefit the community to be able to provide more regular\nrelease cycles to determine 'versioned' points of history.\n\nIdeally, these releases will be made at any ABI breakage, but can be\nmade at arbitary time based points along the way.\n\nTo support releases which may not be ABI stable, declare the soversion\nof both the libcamera and libcamera-base library to be dependant upon\nboth the major and minor component of the project version.\n\nAs part of this, introduce a new 'Versions' summary section to highlight\nthe different version components that may become apparent within any\ngiven build.\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv3:\n - fix typo\n - Use libcamera_version directly for SONAME.\n - Fix ordering of EXCLUDE_PATTERNS\n - Use meson.project_version() in the event the git versions\n are incorrect.\n - No need to present libcamera_version anymore\n - Guaranteed to be the same as 'project_version'\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n Documentation/Doxyfile.in | 4 +++-\n meson.build | 23 +++++++++++++++++++++++\n src/libcamera/base/meson.build | 1 +\n src/libcamera/meson.build | 1 +\n 4 files changed, 28 insertions(+), 1 deletion(-)", "diff": "diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\nindex 88dfcddaebf6..e87bb2b42c5e 100644\n--- a/Documentation/Doxyfile.in\n+++ b/Documentation/Doxyfile.in\n@@ -51,7 +51,9 @@ EXCLUDE_PATTERNS = @TOP_BUILDDIR@/include/libcamera/ipa/*_serializer.h \\\n @TOP_BUILDDIR@/include/libcamera/ipa/ipu3_*.h \\\n @TOP_BUILDDIR@/include/libcamera/ipa/raspberrypi_*.h \\\n @TOP_BUILDDIR@/include/libcamera/ipa/rkisp1_*.h \\\n- @TOP_BUILDDIR@/include/libcamera/ipa/vimc_*.h\n+ @TOP_BUILDDIR@/include/libcamera/ipa/vimc_*.h \\\n+ @TOP_BUILDDIR@/src/libcamera/libcamera.so* \\\n+ @TOP_BUILDDIR@/src/libcamera/base/libcamera-base.so*\n \n EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n libcamera::BoundMethodBase \\\ndiff --git a/meson.build b/meson.build\nindex 2c6173b4f97e..3e2bcc0de2c3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -26,6 +26,29 @@ endif\n \n libcamera_version = libcamera_git_version.split('+')[0]\n \n+# A shallow clone, or a clone without a reachable tag equivalent to the\n+# meson.project_version() could leave the project in a mis-described state.\n+# Produce a warning in this event, and fix to a best effort.\n+if libcamera_version != meson.project_version()\n+ warning('The sources disagree about the version: '\n+ + libcamera_version + ' != ' + meson.project_version())\n+\n+ libcamera_version = meson.project_version()\n+ libcamera_git_version = libcamera_version + '+' + libcamera_git_version.split('+')[1]\n+ summary({'Source version override': true}, section : 'Versions')\n+endif\n+\n+# Until we make ABI compatible releases, the full libcamera version is used as\n+# the soname.\n+libcamera_soversion = libcamera_version\n+\n+summary({\n+ 'project': meson.project_version(),\n+ 'sources': libcamera_git_version,\n+ 'soname': libcamera_soversion,\n+ },\n+ section : 'Versions')\n+\n # This script generates the .tarball-version file on a 'meson dist' command.\n meson.add_dist_script('utils/run-dist.sh')\n \ndiff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\nindex 7a75914ab2a8..7a7fd7e4ca87 100644\n--- a/src/libcamera/base/meson.build\n+++ b/src/libcamera/base/meson.build\n@@ -51,6 +51,7 @@ libcamera_base_args = [ '-DLIBCAMERA_BASE_PRIVATE' ]\n libcamera_base_lib = shared_library('libcamera-base',\n [libcamera_base_sources, libcamera_base_headers],\n version : libcamera_version,\n+ soversion : libcamera_soversion,\n name_prefix : '',\n install : true,\n cpp_args : libcamera_base_args,\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 7fcbb2ddc9e7..5f39d2e2c60a 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -161,6 +161,7 @@ libcamera_deps = [\n libcamera = shared_library('libcamera',\n libcamera_sources,\n version : libcamera_version,\n+ soversion : libcamera_soversion,\n name_prefix : '',\n install : true,\n include_directories : includes,\n", "prefixes": [ "libcamera-devel", "v3", "2/5" ] }