Patch Detail
Show a patch.
GET /api/patches/17560/?format=api
{ "id": 17560, "url": "https://patchwork.libcamera.org/api/patches/17560/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17560/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221008111500.40661-1-Rauch.Christian@gmx.de>", "date": "2022-10-08T11:15:00", "name": "[libcamera-devel] libcamera: Release all devices on shutdown", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2d7478d9c0f88fe9e66ea4aa87249dd1b8e4ff3f", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17560/mbox/", "series": [ { "id": 3542, "url": "https://patchwork.libcamera.org/api/series/3542/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3542", "date": "2022-10-08T11:15:00", "name": "[libcamera-devel] libcamera: Release all devices on shutdown", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3542/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17560/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17560/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4472FBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 8 Oct 2022 11:15:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8252E62D48;\n\tSat, 8 Oct 2022 13:15:03 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 843A760A83\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 8 Oct 2022 13:15:02 +0200 (CEST)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx004\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MMGN2-1oR6qO0JjK-00JNjt;\n\tSat, 08 Oct 2022 13:15:02 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665227703;\n\tbh=agyeuMjyoa+Rpn/yw+NcCBKbE6uAEy2tNMo/2rwQqFU=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=xTkUs4u9E6few9Bi3Jm3rAEFbNk3Y9f2q/FxQyxGXcEa40rZtCVwpyYH8SVRsu804\n\tudkiYc9bw1t3l2d7tRk1UnDLvyCzNl221kH2c0ubUXC+ZHX6JbdFiMugAePJCxyZBc\n\tDhLk9NJg8bW6NBkSN5VAesTw13Zj3JiaBnova+8t45ZbVF7TILbFAM3eYzu8rXMLs8\n\tNMed02K6vkbR0sZFSXg0yMCBUShlCgwLRIGLaeErOi2tLKZBbo/0meQ98DPFIPzMnU\n\tOZ/Jy04Pgm5jvLQUpnn6KF1UqQCQJol4MBSr2xc9bbkNuGaO2bFj6Bf83twSA8nMX8\n\toqB01DgJgZOEg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1665227702;\n\tbh=agyeuMjyoa+Rpn/yw+NcCBKbE6uAEy2tNMo/2rwQqFU=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=SMWcvaeMqW5Mc/+kZ80UXEznMvmfuAFE0RLXEnytLP6OodGWf1eYKUZGQFwmL5nBC\n\tWaUcKBqMzkFunZA1GaZiUZXAal3BH79nOaZ3epMAPhxxqLSriEMQAQcdDP2CW0MteD\n\tWuzIrqdnas3AyLDZWMfb3N8zs9xRo29lwDY/Oh3I=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"SMWcvaeM\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 8 Oct 2022 13:15:00 +0200", "Message-Id": "<20221008111500.40661-1-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:EfsC1huuSzj+YfgftT2jRITD+Yr9kR/8+U3kLrag+GpPi9NzUKL\n\tcI0UQdrDC5MgbLb33QW6PAvRm2WEvm9U0sfR7upGPi625WzpSqSIGU5/lRn5XVzEvoaztul\n\tC1uazEg6047nQ8lDzTXYlajJ6kwB1UdZsnyMc13xSqGslWyQGkkv7sdP5Gdb30RsQJ900hI\n\tJsClEkFPV0U3IQpwexxNA==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:FFanUgNsarE=:+DKPgOvjGNmbPGQSg6C3lb\n\t96FRLYLjSX1TbjQayJAkTcE3zUhdwxHztbYaKrFZ9KU8yZO7b1ax9z5dc+G+J5qK9pRJYlfiN\n\tTkreoIAtcypSWniiRJ0VxNBmn+1Wf9NHzODFvCQ/vo16TGYk4oMCZrwFegGNzMTRNgOpEIuXm\n\trWMuzSXXk7Rb7wCmB+/OeuFx02EcZFI5+1wFqdWxHktuDQC/4M0cDXfDr1LdV0WyANbGr3OMS\n\t0cWUEYr2C4BbjjZE6fpYRCdIQpw22+qcr1+Op6NJTeLjQoJPHopoj3oTpsktC9mfY5D7AnmMZ\n\tAnSCTb63dyw5aXwLl9JzRdi+7j4/vb3ivXeB5iwfAsxmoPzR7nDG4aYAKS8XE1uTi0cNr2L0M\n\tA/HPWfcfEyCriJWFZZCqL+7VoIwBjoD/+HnCMcyWPTBjSvd1H50mNc1adtkHkdDn0HyKJg7Hd\n\tBtNtAPVNM5qSpPxMIoKiZ1PvFUt9GcrRMI33Stgk5X6RoK92KEv6VX577lDjLWDnMcXSPcxOy\n\tlryjNkgMCwZCNcou9NgtKh+Jno2JWX92WDtJdrn/mFrZqN+tpMksTbZt5IDVJjh48pDE4j1pZ\n\tl2gGpUiBc9II+XYY00RKEXh5UsmeKYHovpA6DHiXf9G3ORTcoBxtkiN8qf2zGkfGQ6KiNGVUQ\n\tERq9MySjVGiJ6xOZ8x6OFJMDcp8r1I18O72lEuzYaYReWz3Eo1iaWhruWqitAkr3JdplCmErN\n\tjl2Ik0B8O4cO64w7FbdH8Jz7JkRLh6MQHkCWAMy5sO7XGPJ8RIFrDfyoZOxuksiovG+8FUYka\n\tbpMmB9X9u5VU3I+xeAap0wVE1ODtj2vHxNsJPvOCWEHN6zA+lFbwarpwiZ+hiTCUuF3nEC64S\n\tzTS0Kq4+VzJmospyahxPpTIHGJSyhSecPOt/0AILh6B762snCacxiuovjbxIP1RbdlcpceAks\n\tPUCDTIEWCScV/kq0teJg/YKd20CIHIGFmsd1riIyLt5sHpIf2JR4saoBEAwLCMtYLD+BBP3Gk\n\t+E8SBkSkukkBH+FQnNPpvP8d2y3ZdC4QTlhD0b4j2TRIuPFp8LNLeq/yex036Bj4EGw138Fe2\n\tW0OQ7FuJ1BfkK2u1YS06f+q6RU1HHxMktj/H/aDln1bmY/29sTb4yP3dIy78l14pCqUU6UWNW\n\t003h5Zuztdzrl2xM/WSB/eV6K2xu0kypyU/bIMCFZndXHE8vA8HLX/FpH1+2sfE3HEWp9Xws0\n\tMcsVRP42q5Oe9wXwcxShKJ5wcmVDE0uAIh6FbcXgYpt8cZM3lTiw0uo/QODnAa9pAKJlf5uoo\n\t/3tpzKsx0yW++rHYfr4DtzTxkWYtzys0ft/3F+8GZ3jz3T0mIhRTIPuM4v4I8Di7OMMEIIBcG\n\tQD5UCQ5uO3w2f6Ze8CK8AYgPMbUdefYo+73rDqQjWpgAZLZ0XCooB0Opc5cwQlWhknkL7acHZ\n\tSMFWOxF4e0+sHmASgCNKC50WD8LcRVeH/goQT2SyhvqVz4rrfUOcwjeVkx9UxoVr5urrij52h\n\tYBEaKGfJABeW3EN13CAnXK8sgrn4Yvwi/lEsOod2M3MWG", "Subject": "[libcamera-devel] [PATCH] libcamera: Release all devices on shutdown", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some devices may not be released via their 'PipelineHandler'. This results\nin these devices still being acquired or busy on shutdown. Make sure that\nall devices are released when DeviceEnumerator is deconstructed.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n src/libcamera/device_enumerator.cpp | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex f2e055de..d0968a0a 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -161,12 +161,8 @@ std::unique_ptr<DeviceEnumerator> DeviceEnumerator::create()\n\n DeviceEnumerator::~DeviceEnumerator()\n {\n-\tfor (const std::shared_ptr<MediaDevice> &media : devices_) {\n-\t\tif (media->busy())\n-\t\t\tLOG(DeviceEnumerator, Error)\n-\t\t\t\t<< \"Removing media device \" << media->deviceNode()\n-\t\t\t\t<< \" while still in use\";\n-\t}\n+\tfor (const std::shared_ptr<MediaDevice> &media : devices_)\n+\t\tmedia->release();\n }\n\n /**\n", "prefixes": [ "libcamera-devel" ] }