Patch Detail
Show a patch.
GET /api/patches/17508/?format=api
{ "id": 17508, "url": "https://patchwork.libcamera.org/api/patches/17508/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17508/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221003190706.19816-2-laurent.pinchart@ideasonboard.com>", "date": "2022-10-03T19:07:05", "name": "[libcamera-devel,1/2] test: v4l2_m2mdevice: Test control enumeration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f18d0cbab599dc5618dccc0bd4ac2b9e2112a44f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17508/mbox/", "series": [ { "id": 3527, "url": "https://patchwork.libcamera.org/api/series/3527/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3527", "date": "2022-10-03T19:07:04", "name": "libcamera: v4l2_device: Fix control enumeration for M2M devices", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3527/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17508/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17508/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C65EBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Oct 2022 19:07:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 170BB601CC;\n\tMon, 3 Oct 2022 21:07:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB87E601C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Oct 2022 21:07:10 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45CB5519;\n\tMon, 3 Oct 2022 21:07:10 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664824034;\n\tbh=TXo14gQcgUcTpEPRDEYAh+LzXKS8k4ffaBrsnA1fkDg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=a0N6/IZ4D6vPKmRMmEEeNcVSG6Xh6xAFL6ldwNgD6JeDKFBqsLK69/sByJEmZnv6L\n\t7p9ZmRFMfqcLeW9OoftBnPsFw7FNk1hoYDUNOTrhyi7SWeMrerBwzG5Ihl/0pEqhBO\n\tbVIhYQ9rDI2ZNNqIPuixzIV2nISy1U6oi7wYYiiVRu+yv6hogjfWiydXk5j7zIZvvE\n\txFjQjtyz1zeeGiBK0DK6Km5wj2Gwx1Jt3MKfHdErCbBi/K0hdgMTkonK4odQYP9dw7\n\to8x6etBqMdc/FmnhIeVTJkqC5cAoOhGTNekVVcS/QcX0gpAAthYHAnGtdK+BsES8gE\n\tFHb0VP6u+sJRg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664824030;\n\tbh=TXo14gQcgUcTpEPRDEYAh+LzXKS8k4ffaBrsnA1fkDg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VYCdKh74SXgGdCOtCxKHaKBv3+XZrbzvBqdOgNZduhai97/tufghjtBaDQnFRALK5\n\tgu6RosebsBqkrOKShDUr+gvIFLR8R/L9Id8iJysnDRWKyl1khka5J0h2agnw3Iywc5\n\tvsQT/RujgYQm7z/RBcVacRGaUtTAPoAtc+AO+qPc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VYCdKh74\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 Oct 2022 22:07:05 +0300", "Message-Id": "<20221003190706.19816-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221003190706.19816-1-laurent.pinchart@ideasonboard.com>", "References": "<20221003190706.19816-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] test: v4l2_m2mdevice: Test control\n\tenumeration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Verify that the V4L2M2MDevice correctly enumerates controls supported by\nthe device. The test currently fails, and will be fixed by a subsequent\npatch.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/v4l2_m2mdevice.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\nindex 852b853fa81a..c45f581a8653 100644\n--- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n+++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n@@ -95,6 +95,11 @@ protected:\n \t\tV4L2VideoDevice *capture = vim2m_->capture();\n \t\tV4L2VideoDevice *output = vim2m_->output();\n \n+\t\tif (capture->controls().empty() || output->controls().empty()) {\n+\t\t\tcerr << \"VIM2M device has no control\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\tV4L2DeviceFormat format = {};\n \t\tif (capture->getFormat(&format)) {\n \t\t\tcerr << \"Failed to get capture format\" << endl;\n", "prefixes": [ "libcamera-devel", "1/2" ] }