Patch Detail
Show a patch.
GET /api/patches/1748/?format=api
{ "id": 1748, "url": "https://patchwork.libcamera.org/api/patches/1748/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1748/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190808000404.10841-5-niklas.soderlund@ragnatech.se>", "date": "2019-08-08T00:04:04", "name": "[libcamera-devel,v3,4/4] tests: camera-sensor: Test using invalid media bus format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f4d658e8abc4f7e07646a43d8cad1f335ae1bb4", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1748/mbox/", "series": [ { "id": 448, "url": "https://patchwork.libcamera.org/api/series/448/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=448", "date": "2019-08-08T00:04:00", "name": "libcamera: Fix issues with vimc and Linux v5.2", "version": 3, "mbox": "https://patchwork.libcamera.org/series/448/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1748/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1748/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 792E561623\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Aug 2019 02:04:11 +0200 (CEST)", "from bismarck.berto.se (unknown [145.14.112.32])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 07b99d47-b970-11e9-bdc3-005056917a89;\n\tThu, 08 Aug 2019 02:04:03 +0200 (CEST)" ], "X-Halon-ID": "07b99d47-b970-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Aug 2019 02:04:04 +0200", "Message-Id": "<20190808000404.10841-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20190808000404.10841-1-niklas.soderlund@ragnatech.se>", "References": "<20190808000404.10841-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 4/4] tests: camera-sensor: Test using\n\tinvalid media bus format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 08 Aug 2019 00:04:12 -0000" }, "content": "Linux commit b6c61a6c37317efd (\"media: vimc: propagate pixel format in\nthe stream\") changes the sensor in the vimc media graph to accept all\nmedia bus format currently described in Linux. This prevents the\ncamera-sensor test case to verify that a supported media bus format is\nselected from a list of defined formats, fix this by using an invalid\nmedia bus format in the test case.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/camera-sensor.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\nindex 092cbdd8111ce70d..9fe59cc98d79ccab 100644\n--- a/test/camera-sensor.cpp\n+++ b/test/camera-sensor.cpp\n@@ -83,7 +83,8 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tV4L2SubdeviceFormat format = sensor_->getFormat({ MEDIA_BUS_FMT_UYVY8_2X8,\n+\t\t/* Use an invalid format and make sure it's not selected. */\n+\t\tV4L2SubdeviceFormat format = sensor_->getFormat({ 0xdeadbeef,\n \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_SBGGR10_1X10,\n \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_BGR888_1X24 },\n \t\t\t\t\t\t\t\tSize(1024, 768));\n", "prefixes": [ "libcamera-devel", "v3", "4/4" ] }