Patch Detail
Show a patch.
GET /api/patches/17423/?format=api
{ "id": 17423, "url": "https://patchwork.libcamera.org/api/patches/17423/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17423/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220927023642.12341-13-laurent.pinchart@ideasonboard.com>", "date": "2022-09-27T02:36:21", "name": "[libcamera-devel,v5,12/33] ipa: rkisp1: Remove unused class member", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1f94afbb2da0ac399820dae4385d59a5cd23fe0e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17423/mbox/", "series": [ { "id": 3506, "url": "https://patchwork.libcamera.org/api/series/3506/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3506", "date": "2022-09-27T02:36:09", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3506/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17423/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17423/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67A8FC327F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Sep 2022 02:37:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1999262269;\n\tTue, 27 Sep 2022 04:37:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D81562262\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:17 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1C2BE5;\n\tTue, 27 Sep 2022 04:37:16 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664246239;\n\tbh=m3T2sQgADx/UNRwg4tib9LD5+5I1OEq0ssZTCj9Ak40=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vcyzp4C6VrNDc8mPL0n1J4LaLF2ZauRHXYKNaXma4VN4wLjk6qJs9kP7p5hH3uYjY\n\tlnTA2WBgIW1cGSsGM+956M4sMYZSLoeYRRxL7hdhuyhj1JuJ/6tWCAU+OIhnYs1IHN\n\tY02GGjR/VrjqFRBaCitLkIzcpjWLed6iKTWlQGe0gvpMz1RSBcUHgVafnZYd8pBOOU\n\tLO4cX/NjX9jqMWmDWZqCzgOHU8LpTvxdha4FCbxKo35QEv0dzV1wqpBEmLw3T58LuD\n\tsPCXsGZwTY/zj3yYslJVBUFImhIF89RK36d/cOYLcG9n9L5hUmh3TnIIr9aPqEWiIf\n\t24LCgw/4ibDgg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664246237;\n\tbh=m3T2sQgADx/UNRwg4tib9LD5+5I1OEq0ssZTCj9Ak40=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JNAMZDcdqcLHIUAO2GEx9fsj6MAigFDCswQBICvdLuZSjPOOTjvkCLHFzC75sRPEd\n\tDaMRvESQPjTVeUh5studINSZHRcZ39vOnIM6JSwwhMLrEyTAIYNh8YRdMSYzoGZizq\n\tsYUKKKg8Eo/EEGlobiV+m64r20/qjTBxaQUqHKx4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JNAMZDcd\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 27 Sep 2022 05:36:21 +0300", "Message-Id": "<20220927023642.12341-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "References": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 12/33] ipa: rkisp1: Remove unused class\n\tmember", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nThe \"autoExposure\" class member is not used.\n\nRemove it.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 5 -----\n 1 file changed, 5 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 07210d16b5b5..f7a17459b6c3 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -71,9 +71,6 @@ private:\n \n \tControlInfoMap ctrls_;\n \n-\t/* Camera sensor controls. */\n-\tbool autoExposure_;\n-\n \t/* revision-specific data */\n \trkisp1_cif_isp_version hwRevision_;\n \tunsigned int hwHistBinNMax_;\n@@ -216,8 +213,6 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n \t\treturn -EINVAL;\n \t}\n \n-\tautoExposure_ = true;\n-\n \tint32_t minExposure = itExp->second.min().get<int32_t>();\n \tint32_t maxExposure = itExp->second.max().get<int32_t>();\n \n", "prefixes": [ "libcamera-devel", "v5", "12/33" ] }