Patch Detail
Show a patch.
GET /api/patches/17413/?format=api
{ "id": 17413, "url": "https://patchwork.libcamera.org/api/patches/17413/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17413/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220927023642.12341-3-laurent.pinchart@ideasonboard.com>", "date": "2022-09-27T02:36:11", "name": "[libcamera-devel,v5,02/33] ipa: ipu3: af: Pass context reference to afIsOutOfFocus()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce52d6d562bd79f449c1e46cf349722da95c7bde", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17413/mbox/", "series": [ { "id": 3506, "url": "https://patchwork.libcamera.org/api/series/3506/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3506", "date": "2022-09-27T02:36:09", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3506/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17413/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17413/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B97EC327E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Sep 2022 02:37:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6C9A6226B;\n\tTue, 27 Sep 2022 04:37:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 110AC6225C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:03 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 756C9E5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:02 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664246225;\n\tbh=IgPj/hYSSVv10M89+TU/t0ubOGRQoRKP/Tzn90mvxxg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wK83TBhyZ37ao8F1Lkb+7NcpM6V7Y1WZ/GDnf1wq9Z/RGkQ3PjOp5y/bfrveLVESE\n\tzbVtIrwXrg3uBhA0hgc3v5sPThqGZeWXmu4LLtF1cszlbptux19dLOTDLyRFzidS5I\n\tXjecL8h8w1PD0oqsN/fsdQyhl2lO0q0yiyXenZhWFiQ8PL4g+fXT2cmn5eUuSKsd51\n\tCvHlOlBgcFmQ+FU7iVr8x5gQUczTa5gTEs5LLz4F89DGcuC5RTg7CHFOGNy9dwhBD3\n\tGi1ALCzwz9lBx0zsCkj9YJdN4GBx6Ff4r/VbpKVTupF2K55RVw2wSjxKKePicMyC4h\n\t4oHTurHewwlYQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664246222;\n\tbh=IgPj/hYSSVv10M89+TU/t0ubOGRQoRKP/Tzn90mvxxg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=EOdkiwnynJwP5eFU+nDcIfmnlFmIf7OhorXw29Tz2wz7bylmVhMN1Ger2fLM6/iq+\n\tM0R8RvGbSZ0A5mBFziAzzsQJ60nuYnjCkRJ8QJ7Gyg4mtxDKjM6F7jmd8nIIdvEJfQ\n\t14SGNJXKqa/y3v4HyE8v1JKWtOwKEbwLkrnjL6+8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EOdkiwny\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 27 Sep 2022 05:36:11 +0300", "Message-Id": "<20220927023642.12341-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "References": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 02/33] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Avoid copying the whole IPA context by passing a reference to the\nAf::afIsOutOfFocus() function.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/ipu3/algorithms/af.cpp | 2 +-\n src/ipa/ipu3/algorithms/af.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex 106a7614e2c7..9127c24f1287 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -383,7 +383,7 @@ double Af::afEstimateVariance(Span<const y_table_item_t> y_items, bool isY1)\n * \\return True if the variance threshold is crossed indicating lost focus,\n * false otherwise\n */\n-bool Af::afIsOutOfFocus(IPAContext context)\n+bool Af::afIsOutOfFocus(IPAContext &context)\n {\n \tconst uint32_t diff_var = std::abs(currentVariance_ -\n \t\t\t\t\t context.activeState.af.maxVariance);\ndiff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\nindex ccf015f3f8f5..9b93594898bb 100644\n--- a/src/ipa/ipu3/algorithms/af.h\n+++ b/src/ipa/ipu3/algorithms/af.h\n@@ -44,7 +44,7 @@ private:\n \tvoid afIgnoreFrameReset();\n \tdouble afEstimateVariance(Span<const y_table_item_t> y_items, bool isY1);\n \n-\tbool afIsOutOfFocus(IPAContext context);\n+\tbool afIsOutOfFocus(IPAContext &context);\n \n \t/* VCM step configuration. It is the current setting of the VCM step. */\n \tuint32_t focus_;\n", "prefixes": [ "libcamera-devel", "v5", "02/33" ] }