Patch Detail
Show a patch.
GET /api/patches/17402/?format=api
{ "id": 17402, "url": "https://patchwork.libcamera.org/api/patches/17402/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17402/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220926095737.30506-6-naush@raspberrypi.com>", "date": "2022-09-26T09:57:35", "name": "[libcamera-devel,v3,5/7] ipa: raspberrypi: Use an array of RPiController::Metadata objects", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b8b8f7fcecb3711e066d8426d6957c8cb50cbe89", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17402/mbox/", "series": [ { "id": 3503, "url": "https://patchwork.libcamera.org/api/series/3503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3503", "date": "2022-09-26T09:57:30", "name": "Raspberry Pi AGC digital gain fixes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17402/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17402/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2535BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Sep 2022 09:58:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A781A6225E;\n\tMon, 26 Sep 2022 11:58:12 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 887476224C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Sep 2022 11:58:11 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\tn35-20020a05600c502300b003b4924c6868so7778695wmr.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Sep 2022 02:58:11 -0700 (PDT)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tp22-20020a05600c419600b003a4efb794d7sm10160671wmh.36.2022.09.26.02.58.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 26 Sep 2022 02:58:09 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664186292;\n\tbh=FdO+0iW6DgkgyYw5e18qWIoV4tuve6nHlsQNyOBKS0o=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0Y8vCAlol3tzdGYxqiPDVCdyX2tr5VZjJ2pKk5lQ8DfCcMrTAy+5+DeK5RJrkI8SS\n\tBkad2JkaY7OXn6IQeISHY2vsdxw14EUIcbARJ6b2lmpx6MlOf8ZYsdXBQcF8L5yIHQ\n\tNRt8hkwwpOmhrTos1Qe+ilFVnKZWeoS9Ck+GLg08zyOpX2PpHRJdOyuGUbklFqunZi\n\tdP3UGA1a/VYjQNEt6Ww6zWiYfL3Z6kAx0pHWu/9DWAEH4QxH9Fn/gmXOCGopn8Y+RP\n\t/To2/pYtMBMjCm/x4OqrsrKZ1niKTyd3di+XPE5SCRheTkgGyj5tne3WYB27OkUvNO\n\trfXn2nAoTUJiQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date;\n\tbh=J0rP7W+kbeDPc1Be4ITqwvmzGhcrPvfbVLStz8XRHTA=;\n\tb=MIDXOyEmRzvpQBI7ffCYsGeTnwA7mf5DhfEttHLPQA6Wr4jXYw+TGACcROptQMcuo/\n\t0+O6/ThG5BZWn9bd3UvDaAVTE8e14G2PW2zdT4poYTeRGAMBFKtdFf7opv1r7Xpdzrvc\n\thDSaWgUhPGs/Hn3aAuj1Wt5VkkRUTt8CNwf46KWjjR0J4AjFrAMnFp2sF6HtOwZkEoev\n\t3v8cffMoRyEWbC/0AUDFQo9dS3Tl6tSNctI/xtExaRK2eCpMHexb1yXGoGeNSg5GQuHv\n\tBDJxS+NUonVf7O8jPxrnirqY7XAUuXlWUqpAOtxJgy3BxvwhdjrLapAtjfrevaiIekSH\n\t6Mag==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"MIDXOyEm\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date;\n\tbh=J0rP7W+kbeDPc1Be4ITqwvmzGhcrPvfbVLStz8XRHTA=;\n\tb=cW+dhUrAj2tN7NTrSvJ1u3kYRRVTrMQGJRemXZm4fxfr8Aeer0B8c6XOAJS0gxV3iX\n\tAITQddZ2xC/tmcD3Sp2NmoacwI5SRW7L0qtXZ4Vb3RZD3Ih/3PIHNZ16VdWI6ZeEEH1N\n\t81QOMWppnRDQulAUE+e+jIslrXipbCqzRd65xWlOWexrirBNrW6EbVeRV04M3K1zQWF7\n\tWRiLlZ5DSbcm4DcLOnkEjRy20Pw8UWDMt+Sv49nXq2LKfRf+RyLXSR/yQojbW2Zmqk7S\n\twYIEtA2Ee1WLffj7+51Mu176lSOEdAu4G0lwP5xuIlBD7HgqE1bgEi9gNcQ3bGwDzK9L\n\t5AHw==", "X-Gm-Message-State": "ACrzQf3RhBLWflH6+mnpqIwPM/0SgNxz4iTWMxYgCayTxfOfYmQjsTaB\n\t2YdcGxPkGnr97Bwbb4W0fhVE2gF2jrgHy6fk", "X-Google-Smtp-Source": "AMsMyM5awHHv0roMXulIIth7KaspwmyoCNVPwGwkCAjnNS7dMAQLzCJIh57R6LlfNeRx4cZyKSVOmA==", "X-Received": "by 2002:a05:600c:1906:b0:3b4:c979:e686 with SMTP id\n\tj6-20020a05600c190600b003b4c979e686mr14742722wmq.107.1664186290836; \n\tMon, 26 Sep 2022 02:58:10 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 26 Sep 2022 10:57:35 +0100", "Message-Id": "<20220926095737.30506-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220926095737.30506-1-naush@raspberrypi.com>", "References": "<20220926095737.30506-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 5/7] ipa: raspberrypi: Use an array of\n\tRPiController::Metadata objects", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Cycle through an array of RPiController::Metadata objects, one per\nprepare()/process() invocation, when running the controller algorithms. This\nallows historical metadata objects to be retained, and subsequently passed into\nthe controller algorithms on future frames.\n\nThis change provides a route to fixing a problem with the AGC algorithm, where\nif a manual shutter/gain is requested, the algorithm does not currently retain\nany context of the total exposure that it has calculated. As a result, the\nwrong digital gain would be applied when the frame with the manual shutter/gain\nis processed by the ISP.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 69 +++++++++++++++++------------\n 1 file changed, 40 insertions(+), 29 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8d731435764e..63cccda901c1 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -57,6 +57,9 @@ namespace libcamera {\n using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n+/* Number of metadata objects available in the context list. */\n+constexpr unsigned int numMetadataContexts = 16;\n+\n /* Configure the sensor with these values initially. */\n constexpr double defaultAnalogueGain = 1.0;\n constexpr Duration defaultExposureTime = 20.0ms;\n@@ -163,7 +166,8 @@ private:\n \t/* Raspberry Pi controller specific defines. */\n \tstd::unique_ptr<RPiController::CamHelper> helper_;\n \tRPiController::Controller controller_;\n-\tRPiController::Metadata rpiMetadata_;\n+\tstd::array<RPiController::Metadata, numMetadataContexts> rpiMetadata_;\n+\tunsigned int metadataIdx_;\n \n \t/*\n \t * We count frames to decide if the frame must be hidden (e.g. from\n@@ -319,6 +323,7 @@ void IPARPi::start(const ControlList &controls, StartConfig *startConfig)\n \n \tfirstStart_ = false;\n \tlastRunTimestamp_ = 0;\n+\tmetadataIdx_ = 0;\n }\n \n void IPARPi::setMode(const IPACameraSensorInfo &sensorInfo)\n@@ -513,6 +518,7 @@ void IPARPi::signalStatReady(uint32_t bufferId)\n \treportMetadata();\n \n \tstatsMetadataComplete.emit(bufferId & MaskID, libcameraMetadata_);\n+\tmetadataIdx_ = (metadataIdx_ + 1) % rpiMetadata_.size();\n }\n \n void IPARPi::signalQueueRequest(const ControlList &controls)\n@@ -536,14 +542,15 @@ void IPARPi::signalIspPrepare(const ISPConfig &data)\n \n void IPARPi::reportMetadata()\n {\n-\tstd::unique_lock<RPiController::Metadata> lock(rpiMetadata_);\n+\tRPiController::Metadata &rpiMetadata = rpiMetadata_[metadataIdx_];\n+\tstd::unique_lock<RPiController::Metadata> lock(rpiMetadata);\n \n \t/*\n \t * Certain information about the current frame and how it will be\n \t * processed can be extracted and placed into the libcamera metadata\n \t * buffer, where an application could query it.\n \t */\n-\tDeviceStatus *deviceStatus = rpiMetadata_.getLocked<DeviceStatus>(\"device.status\");\n+\tDeviceStatus *deviceStatus = rpiMetadata.getLocked<DeviceStatus>(\"device.status\");\n \tif (deviceStatus) {\n \t\tlibcameraMetadata_.set(controls::ExposureTime,\n \t\t\t\t deviceStatus->shutterSpeed.get<std::micro>());\n@@ -554,17 +561,17 @@ void IPARPi::reportMetadata()\n \t\t\tlibcameraMetadata_.set(controls::SensorTemperature, *deviceStatus->sensorTemperature);\n \t}\n \n-\tAgcStatus *agcStatus = rpiMetadata_.getLocked<AgcStatus>(\"agc.status\");\n+\tAgcStatus *agcStatus = rpiMetadata.getLocked<AgcStatus>(\"agc.status\");\n \tif (agcStatus) {\n \t\tlibcameraMetadata_.set(controls::AeLocked, agcStatus->locked);\n \t\tlibcameraMetadata_.set(controls::DigitalGain, agcStatus->digitalGain);\n \t}\n \n-\tLuxStatus *luxStatus = rpiMetadata_.getLocked<LuxStatus>(\"lux.status\");\n+\tLuxStatus *luxStatus = rpiMetadata.getLocked<LuxStatus>(\"lux.status\");\n \tif (luxStatus)\n \t\tlibcameraMetadata_.set(controls::Lux, luxStatus->lux);\n \n-\tAwbStatus *awbStatus = rpiMetadata_.getLocked<AwbStatus>(\"awb.status\");\n+\tAwbStatus *awbStatus = rpiMetadata.getLocked<AwbStatus>(\"awb.status\");\n \tif (awbStatus) {\n \t\tlibcameraMetadata_.set(controls::ColourGains,\n \t\t\t\t Span<const float, 2>({ static_cast<float>(awbStatus->gainR),\n@@ -572,7 +579,7 @@ void IPARPi::reportMetadata()\n \t\tlibcameraMetadata_.set(controls::ColourTemperature, awbStatus->temperatureK);\n \t}\n \n-\tBlackLevelStatus *blackLevelStatus = rpiMetadata_.getLocked<BlackLevelStatus>(\"black_level.status\");\n+\tBlackLevelStatus *blackLevelStatus = rpiMetadata.getLocked<BlackLevelStatus>(\"black_level.status\");\n \tif (blackLevelStatus)\n \t\tlibcameraMetadata_.set(controls::SensorBlackLevels,\n \t\t\t\t Span<const int32_t, 4>({ static_cast<int32_t>(blackLevelStatus->blackLevelR),\n@@ -580,7 +587,7 @@ void IPARPi::reportMetadata()\n \t\t\t\t\t\t\t\tstatic_cast<int32_t>(blackLevelStatus->blackLevelG),\n \t\t\t\t\t\t\t\tstatic_cast<int32_t>(blackLevelStatus->blackLevelB) }));\n \n-\tFocusStatus *focusStatus = rpiMetadata_.getLocked<FocusStatus>(\"focus.status\");\n+\tFocusStatus *focusStatus = rpiMetadata.getLocked<FocusStatus>(\"focus.status\");\n \tif (focusStatus && focusStatus->num == 12) {\n \t\t/*\n \t\t * We get a 4x3 grid of regions by default. Calculate the average\n@@ -591,7 +598,7 @@ void IPARPi::reportMetadata()\n \t\tlibcameraMetadata_.set(controls::FocusFoM, focusFoM);\n \t}\n \n-\tCcmStatus *ccmStatus = rpiMetadata_.getLocked<CcmStatus>(\"ccm.status\");\n+\tCcmStatus *ccmStatus = rpiMetadata.getLocked<CcmStatus>(\"ccm.status\");\n \tif (ccmStatus) {\n \t\tfloat m[9];\n \t\tfor (unsigned int i = 0; i < 9; i++)\n@@ -1002,10 +1009,10 @@ void IPARPi::returnEmbeddedBuffer(unsigned int bufferId)\n void IPARPi::prepareISP(const ISPConfig &data)\n {\n \tint64_t frameTimestamp = data.controls.get(controls::SensorTimestamp).value_or(0);\n-\tRPiController::Metadata lastMetadata;\n+\tRPiController::Metadata &rpiMetadata = rpiMetadata_[metadataIdx_];\n \tSpan<uint8_t> embeddedBuffer;\n \n-\tlastMetadata = std::move(rpiMetadata_);\n+\trpiMetadata.clear();\n \tfillDeviceStatus(data.controls);\n \n \tif (data.embeddedBufferPresent) {\n@@ -1022,7 +1029,7 @@ void IPARPi::prepareISP(const ISPConfig &data)\n \t * This may overwrite the DeviceStatus using values from the sensor\n \t * metadata, and may also do additional custom processing.\n \t */\n-\thelper_->prepare(embeddedBuffer, rpiMetadata_);\n+\thelper_->prepare(embeddedBuffer, rpiMetadata);\n \n \t/* Done with embedded data now, return to pipeline handler asap. */\n \tif (data.embeddedBufferPresent)\n@@ -1038,7 +1045,9 @@ void IPARPi::prepareISP(const ISPConfig &data)\n \t\t * current frame, or any other bits of metadata that were added\n \t\t * in helper_->Prepare().\n \t\t */\n-\t\trpiMetadata_.merge(lastMetadata);\n+\t\tRPiController::Metadata &lastMetadata =\n+\t\t\trpiMetadata_[metadataIdx_ == 0 ? rpiMetadata_.size() - 1 : metadataIdx_ - 1];\n+\t\trpiMetadata.mergeCopy(lastMetadata);\n \t\tprocessPending_ = false;\n \t\treturn;\n \t}\n@@ -1048,48 +1057,48 @@ void IPARPi::prepareISP(const ISPConfig &data)\n \n \tControlList ctrls(ispCtrls_);\n \n-\tcontroller_.prepare(&rpiMetadata_);\n+\tcontroller_.prepare(&rpiMetadata);\n \n \t/* Lock the metadata buffer to avoid constant locks/unlocks. */\n-\tstd::unique_lock<RPiController::Metadata> lock(rpiMetadata_);\n+\tstd::unique_lock<RPiController::Metadata> lock(rpiMetadata);\n \n-\tAwbStatus *awbStatus = rpiMetadata_.getLocked<AwbStatus>(\"awb.status\");\n+\tAwbStatus *awbStatus = rpiMetadata.getLocked<AwbStatus>(\"awb.status\");\n \tif (awbStatus)\n \t\tapplyAWB(awbStatus, ctrls);\n \n-\tCcmStatus *ccmStatus = rpiMetadata_.getLocked<CcmStatus>(\"ccm.status\");\n+\tCcmStatus *ccmStatus = rpiMetadata.getLocked<CcmStatus>(\"ccm.status\");\n \tif (ccmStatus)\n \t\tapplyCCM(ccmStatus, ctrls);\n \n-\tAgcStatus *dgStatus = rpiMetadata_.getLocked<AgcStatus>(\"agc.status\");\n+\tAgcStatus *dgStatus = rpiMetadata.getLocked<AgcStatus>(\"agc.status\");\n \tif (dgStatus)\n \t\tapplyDG(dgStatus, ctrls);\n \n-\tAlscStatus *lsStatus = rpiMetadata_.getLocked<AlscStatus>(\"alsc.status\");\n+\tAlscStatus *lsStatus = rpiMetadata.getLocked<AlscStatus>(\"alsc.status\");\n \tif (lsStatus)\n \t\tapplyLS(lsStatus, ctrls);\n \n-\tContrastStatus *contrastStatus = rpiMetadata_.getLocked<ContrastStatus>(\"contrast.status\");\n+\tContrastStatus *contrastStatus = rpiMetadata.getLocked<ContrastStatus>(\"contrast.status\");\n \tif (contrastStatus)\n \t\tapplyGamma(contrastStatus, ctrls);\n \n-\tBlackLevelStatus *blackLevelStatus = rpiMetadata_.getLocked<BlackLevelStatus>(\"black_level.status\");\n+\tBlackLevelStatus *blackLevelStatus = rpiMetadata.getLocked<BlackLevelStatus>(\"black_level.status\");\n \tif (blackLevelStatus)\n \t\tapplyBlackLevel(blackLevelStatus, ctrls);\n \n-\tGeqStatus *geqStatus = rpiMetadata_.getLocked<GeqStatus>(\"geq.status\");\n+\tGeqStatus *geqStatus = rpiMetadata.getLocked<GeqStatus>(\"geq.status\");\n \tif (geqStatus)\n \t\tapplyGEQ(geqStatus, ctrls);\n \n-\tDenoiseStatus *denoiseStatus = rpiMetadata_.getLocked<DenoiseStatus>(\"denoise.status\");\n+\tDenoiseStatus *denoiseStatus = rpiMetadata.getLocked<DenoiseStatus>(\"denoise.status\");\n \tif (denoiseStatus)\n \t\tapplyDenoise(denoiseStatus, ctrls);\n \n-\tSharpenStatus *sharpenStatus = rpiMetadata_.getLocked<SharpenStatus>(\"sharpen.status\");\n+\tSharpenStatus *sharpenStatus = rpiMetadata.getLocked<SharpenStatus>(\"sharpen.status\");\n \tif (sharpenStatus)\n \t\tapplySharpen(sharpenStatus, ctrls);\n \n-\tDpcStatus *dpcStatus = rpiMetadata_.getLocked<DpcStatus>(\"dpc.status\");\n+\tDpcStatus *dpcStatus = rpiMetadata.getLocked<DpcStatus>(\"dpc.status\");\n \tif (dpcStatus)\n \t\tapplyDPC(dpcStatus, ctrls);\n \n@@ -1111,11 +1120,13 @@ void IPARPi::fillDeviceStatus(const ControlList &sensorControls)\n \n \tLOG(IPARPI, Debug) << \"Metadata - \" << deviceStatus;\n \n-\trpiMetadata_.set(\"device.status\", deviceStatus);\n+\trpiMetadata_[metadataIdx_].set(\"device.status\", deviceStatus);\n }\n \n void IPARPi::processStats(unsigned int bufferId)\n {\n+\tRPiController::Metadata &rpiMetadata = rpiMetadata_[metadataIdx_];\n+\n \tauto it = buffers_.find(bufferId);\n \tif (it == buffers_.end()) {\n \t\tLOG(IPARPI, Error) << \"Could not find stats buffer!\";\n@@ -1125,11 +1136,11 @@ void IPARPi::processStats(unsigned int bufferId)\n \tSpan<uint8_t> mem = it->second.planes()[0];\n \tbcm2835_isp_stats *stats = reinterpret_cast<bcm2835_isp_stats *>(mem.data());\n \tRPiController::StatisticsPtr statistics = std::make_shared<bcm2835_isp_stats>(*stats);\n-\thelper_->process(statistics, rpiMetadata_);\n-\tcontroller_.process(statistics, &rpiMetadata_);\n+\thelper_->process(statistics, rpiMetadata);\n+\tcontroller_.process(statistics, &rpiMetadata);\n \n \tstruct AgcStatus agcStatus;\n-\tif (rpiMetadata_.get(\"agc.status\", agcStatus) == 0) {\n+\tif (rpiMetadata.get(\"agc.status\", agcStatus) == 0) {\n \t\tControlList ctrls(sensorCtrls_);\n \t\tapplyAGC(&agcStatus, ctrls);\n \n", "prefixes": [ "libcamera-devel", "v3", "5/7" ] }