Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1728,
    "url": "https://patchwork.libcamera.org/api/patches/1728/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/1728/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20190805155133.11335-2-niklas.soderlund@ragnatech.se>",
    "date": "2019-08-05T15:51:30",
    "name": "[libcamera-devel,1/4] libcamera: pipeline: vimc: Initialize device pointers",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "f57bccc2a6a31485033b33e3589d71233558e25b",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/1728/mbox/",
    "series": [
        {
            "id": 445,
            "url": "https://patchwork.libcamera.org/api/series/445/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=445",
            "date": "2019-08-05T15:51:29",
            "name": "libcamera: Fix issues with vimc and Linux v5.2",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/445/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/1728/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/1728/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60C81615FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  5 Aug 2019 17:51:40 +0200 (CEST)",
            "from bismarck.berto.se (unknown [145.14.112.32])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid e907f936-b798-11e9-903a-005056917f90;\n\tMon, 05 Aug 2019 17:51:38 +0200 (CEST)"
        ],
        "X-Halon-ID": "e907f936-b798-11e9-903a-005056917f90",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Mon,  5 Aug 2019 17:51:30 +0200",
        "Message-Id": "<20190805155133.11335-2-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.22.0",
        "In-Reply-To": "<20190805155133.11335-1-niklas.soderlund@ragnatech.se>",
        "References": "<20190805155133.11335-1-niklas.soderlund@ragnatech.se>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH 1/4] libcamera: pipeline: vimc: Initialize\n\tdevice pointers",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.23",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Mon, 05 Aug 2019 15:51:40 -0000"
    },
    "content": "As the device pointers are deleted in the pipelines destructor it's not\na good idea to have them uninitialized.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/vimc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 61b68a32ea508af8..3d6808222a8a2c5d 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -35,7 +35,7 @@ class VimcCameraData : public CameraData\n {\n public:\n \tVimcCameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe)\n+\t\t: CameraData(pipe), video_(nullptr), sensor_(nullptr)\n \t{\n \t}\n \n",
    "prefixes": [
        "libcamera-devel",
        "1/4"
    ]
}