Patch Detail
Show a patch.
GET /api/patches/17239/?format=api
{ "id": 17239, "url": "https://patchwork.libcamera.org/api/patches/17239/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17239/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220829185849.1884517-4-marvin.schmidt1987@gmail.com>", "date": "2022-08-29T18:58:49", "name": "[libcamera-devel,3/3] ipa: rkisp1: Remove redundant call of std::string::c_str()", "commit_ref": "372621352de4b201568b03b51970b1f72e886fa6", "pull_url": null, "state": "accepted", "archived": false, "hash": "59ad2b3f972203af79c2aaaf2f2d356a69762708", "submitter": { "id": 51, "url": "https://patchwork.libcamera.org/api/people/51/?format=api", "name": "Marvin Schmidt", "email": "marvin.schmidt1987@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17239/mbox/", "series": [ { "id": 3449, "url": "https://patchwork.libcamera.org/api/series/3449/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3449", "date": "2022-08-29T18:58:46", "name": "Remove redundant calls to std::string::c_str()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3449/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17239/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17239/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B94DCC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Aug 2022 18:59:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5953C61FC3;\n\tMon, 29 Aug 2022 20:59:07 +0200 (CEST)", "from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F110161FC8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 20:59:03 +0200 (CEST)", "by mail-ed1-x52d.google.com with SMTP id z2so11369955edc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 11:59:03 -0700 (PDT)", "from pythagoras.local\n\t(dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111])\n\tby smtp.gmail.com with ESMTPSA id\n\t17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Aug 2022 11:59:02 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661799547;\n\tbh=mZ5A/dwYqBmwO3GkG6MkqTcH1a0m6fVilpgJJXRMbbs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IYBaXfP2vpcB95maiDrHdtmvPbV75yjw9zab87f8WMz9vQDVpScEucaGsBcjKPD3G\n\tQ4aVQFanccDBM503ZD/AVqtaOSoY1xNT8GOC7SBvliG4jICczwGziMZqPwu/JRaHPg\n\tY3S7YZsJsF9CTS0eTaFdg6dIpgQKMfk3vznPEk7e3ZjQOVf+6PBaJPtfcCjgOYxNVB\n\tifKFqgcFRdsa5uLRkIgcpReq7rNESz+njmUeyEy8diTz5Ig6Zmc0MW7VXGala8MotT\n\t8j/VId61Hqqj/guKyYdJhj8+rH4tMfBYvIC3Uz2XlVg6BeMAfPKuWWFoq2jmWuJG6E\n\tcOzgPkznqSMLQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=P5yH+Wui4qN59uyPB7PWWHAyvw0tGsqkJtFMBz+cyKI=;\n\tb=HmeHBIyNkilSXNKAX6wXNqENvd87b8rS/qwvAMYTbQ8E2jJ2VcPg0UVRH4rUxOyEKq\n\tEjCSvHPKwcgNTlki4Q6OD+HBIl00lFUvETb0KcsRYl7xGjqfBs0YKcfJwFphGo3pdSWV\n\tdhIM6TEU9gO+/Wa21vVyeYvfsxablgK4hqb0AJn2rnnu/nPI8sngoin3qByvtBlNnpKk\n\t7haDGkJ3fofl18RynleaPnOBO8Y7bWfzVwcOfMMe+tP3/qN2+tczBCOg/1bx8I2dBBng\n\ttsQxRamb2Ha634+R4tJGqKKmyqHyqGIc/4yeZOpH8m58+V9Qegxz2xJS8aISwXdj1BJm\n\tBFpg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HmeHBIyN\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=P5yH+Wui4qN59uyPB7PWWHAyvw0tGsqkJtFMBz+cyKI=;\n\tb=FxSzCdB9DUh/2HdvX0myFb5lnGRFAhvEesGC5TRZTu4KgFa9Oy+ZE6zR0RFAIyAMPc\n\tGAuKwE1Wuehqn4lG+lrmOqUPgpC61Y5OT+IukHSMIle4+ux7VPwJl7DCGLFGibuZJ/lG\n\tz15r/flwwFscLPxY2jRmniWdA9OxoLZgwKpRDgRvcsHzy8Nw2yFhntPP4dhlH/e87AOD\n\t016Q+ZZ1bLCwtba3ozMivgzn8xcEePqXOhol2LJW6ot90jLW/JKKEDIaQuUQF6vOPT68\n\thm+08DSYK7p4QGU1pxYFgMWaFKeTBT6TvkGJmQziFpCU8eDHwcli0BDYtTALLZYS8vMC\n\tJUcA==", "X-Gm-Message-State": "ACgBeo0Rv2DCuJFuGLYH9wUUHkAS7QrTjpkhy7Wk0buKAqqMVeqg24NT\n\tStce4JT9cnazpcMBtHYlcHcgv9W9q+A=", "X-Google-Smtp-Source": "AA6agR5ZthJ+hAhrvI0EETuYJauUN1jwkzADYS2Xm7j/FKSZ9MQV3zPqSSBcP5U8dAZy8G/zPspQ3w==", "X-Received": "by 2002:a05:6402:1d4e:b0:43d:9822:b4d1 with SMTP id\n\tdz14-20020a0564021d4e00b0043d9822b4d1mr17649679edb.212.1661799543153; \n\tMon, 29 Aug 2022 11:59:03 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Aug 2022 20:58:49 +0200", "Message-Id": "<20220829185849.1884517-4-marvin.schmidt1987@gmail.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>", "References": "<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] ipa: rkisp1: Remove redundant call of\n\tstd::string::c_str()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Marvin Schmidt via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Marvin Schmidt <marvin.schmidt1987@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The constructor of libcamera::File takes a const reference to a std::string\nand clang-tidy's readability-redundant-string-cstr check warns about it:\n\n> ../src/ipa/rkisp1/rkisp1.cpp:147:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr]\n> File file(settings.configurationFile.c_str());\n> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> settings.configurationFile\n\nSigned-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 27b4212b..9e3eb7fb 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -144,7 +144,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \t}\n \n \t/* Load the tuning data file. */\n-\tFile file(settings.configurationFile.c_str());\n+\tFile file(settings.configurationFile);\n \tif (!file.open(File::OpenModeFlag::ReadOnly)) {\n \t\tint ret = file.error();\n \t\tLOG(IPARkISP1, Error)\n", "prefixes": [ "libcamera-devel", "3/3" ] }