Patch Detail
Show a patch.
GET /api/patches/17226/?format=api
{ "id": 17226, "url": "https://patchwork.libcamera.org/api/patches/17226/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17226/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220829135950.1271098-1-marvin.schmidt1987@gmail.com>", "date": "2022-08-29T13:59:50", "name": "[libcamera-devel] libcamera: media_device: Fix \\sa tags for MediaDevice::link", "commit_ref": "18764a15c7062e241df3ffb587bf44d0c14c898d", "pull_url": null, "state": "accepted", "archived": false, "hash": "82998eaf7d3750176799898b215fae9e54c5846c", "submitter": { "id": 51, "url": "https://patchwork.libcamera.org/api/people/51/?format=api", "name": "Marvin Schmidt", "email": "marvin.schmidt1987@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17226/mbox/", "series": [ { "id": 3446, "url": "https://patchwork.libcamera.org/api/series/3446/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3446", "date": "2022-08-29T13:59:50", "name": "[libcamera-devel] libcamera: media_device: Fix \\sa tags for MediaDevice::link", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3446/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17226/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17226/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCBFCC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Aug 2022 13:59:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 261B661FC0;\n\tMon, 29 Aug 2022 15:59:57 +0200 (CEST)", "from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n\t[IPv6:2a00:1450:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92C8A61FBA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 15:59:56 +0200 (CEST)", "by mail-ej1-x62e.google.com with SMTP id w19so15873952ejc.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 06:59:56 -0700 (PDT)", "from pythagoras.local\n\t(dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111])\n\tby smtp.gmail.com with ESMTPSA id\n\ta71-20020a509ecd000000b00446639c01easm5785527edf.44.2022.08.29.06.59.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Aug 2022 06:59:55 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661781597;\n\tbh=yOcotqSmJSAdpQPlQuCCGehmuIwgQ6sMo/McP7zTF3I=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Vz7nmTnAq3zIGgzmJ6oeBM4aVyjWXL7vqCGkLP+X4qpe97N3SFxTOSTR/zVlHvfmR\n\t8pYCZt6YSCAFjKDYJJAbGg/6Ugle+EO9c8r2TvO2mlaRhUFX8YE0VU7faevm5NpslW\n\tggK3IiTDkNFYAe1OK3oWAa9/piZ37B53PdfDAKytFcmJq/F0CqY5CPJm5Np3SCRmVV\n\tyeZh1qg8Ls1RLDEUXqSuKETA11urKZM+uw3V31wma9OvDXvQQMjDchU13clJc/9ZPf\n\t4nxLomgc4Wze1JmrmQFvT2d5gikTy2y+9znhJI8318P9JAcX/RhnsuOvr1I2J2vasl\n\tyoF1//q6zMqzw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc;\n\tbh=Hh7M6UE0oNRA6ORmP5ohomPNt0cHcBnLPkLQ2S1RZUE=;\n\tb=ijP7o4XaqrcPcX52mqgjsAXfUMFPRya2F9v4LGsOeHMki/bmRaqernNN+JY7fuOIA9\n\tItkQ9Tud5Ne/Seu0ozPa0Ymv9LFxX1g+uCsbYzMUprGmGmkdntO1GP1D58GO1mc7XHTC\n\tRw2T3UF5w2uxRjndVkjEt6md6tr8LSrrkSggP1lvlXzfVpOOfIwcQcV1q+greMxvoCzb\n\tc2gf+iH/M6IqmacThoElqdBU7i2vN804kkw/wh2s3I+JDZ7pIYBneL4uci0FJa0+9J4r\n\tMQ8fV7KlaES8rzzCPl/TWb5CxryHpXhKh8IgLw4LpCcAlM+onyuQaZfYHOMmnADlCpmC\n\trE3A==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ijP7o4Xa\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc;\n\tbh=Hh7M6UE0oNRA6ORmP5ohomPNt0cHcBnLPkLQ2S1RZUE=;\n\tb=cdKKaGo1ByNMKcn9mAPEGAvfPp7h517p+4hW9ZQ3Yx0cXiLv947FeTeke960shXmdI\n\t5rXq++3j9swTU9sIga+e0Lb/bFI7JZSBxwTGC93TY7ETwelbvckOo2DeVQbJqxcIPm61\n\tNJx+dhiOB2Df0W0lT4SpCjUkQMq/m7g7pcBOoQLRZRAFoW1idSL243/xeyHZluj8MabO\n\tYf9UkNLpghtX48Py6GbFTifMEW0rLeQgjaXnN7oHu/gPmYe3luA+iCGwsO/28Zg6tR3A\n\tMlFm6nuzOwHo3AAxQWu8Y6w9/v5gxugiA96JBgGVcg7/GVb8zU2GBOShFs9DZ+TUHLYz\n\t1FpQ==", "X-Gm-Message-State": "ACgBeo0HxdPmlhnuarDKylUMryI2tEdm50cmSD/i///mb8n6xb7KMnNL\n\tRvTAA42unoeCEF+tIvn7px9tedkF7Gc=", "X-Google-Smtp-Source": "AA6agR75lTnBWwstq8gHEMBlNbB3JfqgC14rl3/0w9cJoJhk66hCjn2JbkR9HC3A8URtK2JzSMiIsg==", "X-Received": "by 2002:a17:907:7da0:b0:741:a1c5:bfa0 with SMTP id\n\toz32-20020a1709077da000b00741a1c5bfa0mr1440643ejc.555.1661781595783; \n\tMon, 29 Aug 2022 06:59:55 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Aug 2022 15:59:50 +0200", "Message-Id": "<20220829135950.1271098-1-marvin.schmidt1987@gmail.com>", "X-Mailer": "git-send-email 2.37.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: media_device: Fix \\sa tags for\n\tMediaDevice::link", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Marvin Schmidt via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Marvin Schmidt <marvin.schmidt1987@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "doxygen didn't create proper links to the overloads of\nMediaDevice::link because the signatures didn't match due to an\nadditional 'const'\n\nWhile at it remove the unnecessary `MediaDevice::` and wrap the lines\n\nFixes: b65feafe (\"libcamera: media_device: Add functions to get a MediaLink\")\n\nSigned-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com>\n---\n src/libcamera/media_device.cpp | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex 7c94da9e..52c8e66e 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -352,8 +352,9 @@ MediaEntity *MediaDevice::getEntityByName(const std::string &name) const\n * entity with name \\a sourceName, to the pad at index \\a sinkIdx of the\n * sink entity with name \\a sinkName, if any.\n *\n- * \\sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const\n- * \\sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const\n+ * \\sa link(const MediaEntity *source, unsigned int sourceIdx,\n+ * const MediaEntity *sink, unsigned int sinkIdx)\n+ * \\sa link(const MediaPad *source, const MediaPad *sink)\n *\n * \\return The link that connects the two pads, or nullptr if no such a link\n * exists\n@@ -381,8 +382,9 @@ MediaLink *MediaDevice::link(const std::string &sourceName, unsigned int sourceI\n * entity \\a source, to the pad at index \\a sinkIdx of the sink entity \\a\n * sink, if any.\n *\n- * \\sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const\n- * \\sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const\n+ * \\sa link(const std::string &sourceName, unsigned int sourceIdx,\n+ * const std::string &sinkName, unsigned int sinkIdx)\n+ * \\sa link(const MediaPad *source, const MediaPad *sink)\n *\n * \\return The link that connects the two pads, or nullptr if no such a link\n * exists\n@@ -404,8 +406,10 @@ MediaLink *MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx,\n * \\param[in] source The source pad\n * \\param[in] sink The sink pad\n *\n- * \\sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const\n- * \\sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const\n+ * \\sa link(const std::string &sourceName, unsigned int sourceIdx,\n+ * const std::string &sinkName, unsigned int sinkIdx)\n+ * \\sa link(const MediaEntity *source, unsigned int sourceIdx,\n+ * const MediaEntity *sink, unsigned int sinkIdx)\n *\n * \\return The link that connects the two pads, or nullptr if no such a link\n * exists\n", "prefixes": [ "libcamera-devel" ] }