Patch Detail
Show a patch.
GET /api/patches/172/?format=api
{ "id": 172, "url": "https://patchwork.libcamera.org/api/patches/172/?format=api", "web_url": "https://patchwork.libcamera.org/patch/172/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190107231151.23291-10-laurent.pinchart@ideasonboard.com>", "date": "2019-01-07T23:11:49", "name": "[libcamera-devel,v2,09/11] test: Add signal/slot test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8ad69bdb995eb0f9ee5bd0f319d5c77a45ae4f4d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/172/mbox/", "series": [ { "id": 56, "url": "https://patchwork.libcamera.org/api/series/56/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=56", "date": "2019-01-07T23:11:40", "name": "libcamera: Add event notification and timers", "version": 2, "mbox": "https://patchwork.libcamera.org/series/56/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/172/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/172/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B17760B41\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Jan 2019 00:10:51 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 755D7E51\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Jan 2019 00:10:50 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546902650;\n\tbh=IU6XMvY5UCWwLLrR458LSJmrgzXqYmdrBFGJZp+ZtZQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=H+MPVXaHzh/eIno7+hctn+RcZsgLhZem3jw4N3/OkhEFkAnZld6rfpey2vQFJsdBb\n\twijjTJoT6tj76GsjFkSohty9E6n2yFF+L6hsr2ZDCU+/nzDw8VYnuqiI2LDaeMKvwP\n\tBt8GkoYSDg96jq07Of/Wc+Jmewg9abodDYmq5Tkg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 8 Jan 2019 01:11:49 +0200", "Message-Id": "<20190107231151.23291-10-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190107231151.23291-1-laurent.pinchart@ideasonboard.com>", "References": "<20190107231151.23291-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 09/11] test: Add signal/slot test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 07 Jan 2019 23:10:51 -0000" }, "content": "Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n test/meson.build | 1 +\n test/signal.cpp | 159 +++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 160 insertions(+)\n create mode 100644 test/signal.cpp", "diff": "diff --git a/test/meson.build b/test/meson.build\nindex 30350d2219a1..4000bd51808a 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -4,6 +4,7 @@ subdir('media_device')\n \n public_tests = [\n ['list-cameras', 'list-cameras.cpp'],\n+ ['signal', 'signal.cpp'],\n ]\n \n internal_tests = [\ndiff --git a/test/signal.cpp b/test/signal.cpp\nnew file mode 100644\nindex 000000000000..ab69ca1b663d\n--- /dev/null\n+++ b/test/signal.cpp\n@@ -0,0 +1,159 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * signal.cpp - Signal test\n+ */\n+\n+#include <iostream>\n+#include <string.h>\n+\n+#include <libcamera/signal.h>\n+\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+static int valueStatic_ = 0;\n+\n+static void slotStatic(int value)\n+{\n+\tvalueStatic_ = value;\n+}\n+\n+class SignalTest : public Test\n+{\n+protected:\n+\tvoid slotVoid()\n+\t{\n+\t\tcalled_ = true;\n+\t}\n+\n+\tvoid slotDisconnect()\n+\t{\n+\t\tcalled_ = true;\n+\t\tsignalVoid_.disconnect(this, &SignalTest::slotDisconnect);\n+\t}\n+\n+\tvoid slotInteger1(int value)\n+\t{\n+\t\tvalues_[0] = value;\n+\t}\n+\n+\tvoid slotInteger2(int value)\n+\t{\n+\t\tvalues_[1] = value;\n+\t}\n+\n+\tvoid slotMultiArgs(int value, const std::string &name)\n+\t{\n+\t\tvalues_[2] = value;\n+\t\tname_ = name;\n+\t}\n+\n+\tint init()\n+\t{\n+\t\treturn 0;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\t/* Test signal emission and reception. */\n+\t\tcalled_ = false;\n+\t\tsignalVoid_.connect(this, &SignalTest::slotVoid);\n+\t\tsignalVoid_.emit();\n+\n+\t\tif (!called_) {\n+\t\t\tcout << \"Signal emission test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test signal with parameters. */\n+\t\tvalues_[2] = 0;\n+\t\tname_.clear();\n+\t\tsignalMultiArgs_.connect(this, &SignalTest::slotMultiArgs);\n+\t\tsignalMultiArgs_.emit(42, \"H2G2\");\n+\n+\t\tif (values_[2] != 42 || name_ != \"H2G2\") {\n+\t\t\tcout << \"Signal parameters test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test signal connected to multiple slots. */\n+\t\tmemset(values_, 0, sizeof(values_));\n+\t\tvalueStatic_ = 0;\n+\t\tsignalInt_.connect(this, &SignalTest::slotInteger1);\n+\t\tsignalInt_.connect(this, &SignalTest::slotInteger2);\n+\t\tsignalInt_.connect(&slotStatic);\n+\t\tsignalInt_.emit(42);\n+\n+\t\tif (values_[0] != 42 || values_[1] != 42 || values_[2] != 0 ||\n+\t\t valueStatic_ != 42) {\n+\t\t\tcout << \"Signal multi slot test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test disconnection of a single slot. */\n+\t\tmemset(values_, 0, sizeof(values_));\n+\t\tsignalInt_.disconnect(this, &SignalTest::slotInteger2);\n+\t\tsignalInt_.emit(42);\n+\n+\t\tif (values_[0] != 42 || values_[1] != 0 || values_[2] != 0) {\n+\t\t\tcout << \"Signal slot disconnection test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test disconnection of a whole object. */\n+\t\tmemset(values_, 0, sizeof(values_));\n+\t\tsignalInt_.disconnect(this);\n+\t\tsignalInt_.emit(42);\n+\n+\t\tif (values_[0] != 0 || values_[1] != 0 || values_[2] != 0) {\n+\t\t\tcout << \"Signal object disconnection test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test disconnection of a whole signal. */\n+\t\tmemset(values_, 0, sizeof(values_));\n+\t\tsignalInt_.connect(this, &SignalTest::slotInteger1);\n+\t\tsignalInt_.connect(this, &SignalTest::slotInteger2);\n+\t\tsignalInt_.disconnect();\n+\t\tsignalInt_.emit(42);\n+\n+\t\tif (values_[0] != 0 || values_[1] != 0 || values_[2] != 0) {\n+\t\t\tcout << \"Signal object disconnection test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test disconnection from slot. */\n+\t\tsignalVoid_.disconnect();\n+\t\tsignalVoid_.connect(this, &SignalTest::slotDisconnect);\n+\n+\t\tsignalVoid_.emit();\n+\t\tcalled_ = false;\n+\t\tsignalVoid_.emit();\n+\n+\t\tif (called_) {\n+\t\t\tcout << \"Signal disconnection from slot test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup()\n+\t{\n+\t}\n+\n+private:\n+\tSignal<> signalVoid_;\n+\tSignal<int> signalInt_;\n+\tSignal<int, const std::string &> signalMultiArgs_;\n+\n+\tbool called_;\n+\tint values_[3];\n+\tstd::string name_;\n+};\n+\n+TEST_REGISTER(SignalTest)\n", "prefixes": [ "libcamera-devel", "v2", "09/11" ] }