Patch Detail
Show a patch.
GET /api/patches/17176/?format=api
{ "id": 17176, "url": "https://patchwork.libcamera.org/api/patches/17176/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17176/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220819111615.39814-2-tomi.valkeinen@ideasonboard.com>", "date": "2022-08-19T11:16:10", "name": "[libcamera-devel,v4,1/6] py: meson: Use libcamera_private dependency", "commit_ref": "418cbde04b8b21a7b9392808a0144dadcd56d268", "pull_url": null, "state": "accepted", "archived": false, "hash": "a9ed1a68a02d51a0af5fa5f462c22c85cb916f3a", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17176/mbox/", "series": [ { "id": 3428, "url": "https://patchwork.libcamera.org/api/series/3428/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3428", "date": "2022-08-19T11:16:09", "name": "Python bindings: PyCameraManager and non-blocking eventfd", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3428/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17176/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17176/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92A25BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Aug 2022 11:16:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 023D961FC6;\n\tFri, 19 Aug 2022 13:16:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE98761FA5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Aug 2022 13:16:30 +0200 (CEST)", "from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AD5D576;\n\tFri, 19 Aug 2022 13:16:30 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660907794;\n\tbh=fRRMCVBoNG8Bc6PNJEDWJE/dhM/dWtpWrWuxVQ6kOj4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IDxikQgk5EYPQg46S4JHqKeZ+oQ+4VjK3ixO8Xr2UJL5kKiGLeju5CQiNc0IKySEd\n\tu/L73Z7aYuNJfICwcIjjD2VVdknu115QtQhsUyQ9fCoc//pz0QWp++bIt+tvHbZdea\n\tCNOBqAog2rt31u6to1G4g/Hx4h7XROtvdwRn446maWPhoqPOa1jg4f2Tgq3YyI1lCP\n\trSIz1A93r76pDhIVV6x3Z3cXKViMzw1kvYM06oDO/GitBI/ZAFKKcRbiTGXlWJw8y/\n\tcBJKKAxh9sVzPHXZWWakkoTpYQBLQDjab+YCoDbsgcQzF/x+QJkILMDigaeI3lYKcu\n\tRLHq5JNA9jpUw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660907790;\n\tbh=fRRMCVBoNG8Bc6PNJEDWJE/dhM/dWtpWrWuxVQ6kOj4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AGBsq8c61CBS93XsYh+/XKj62+hzi5as3yAN8UOOUz21xLjCOoi1LFnqRxWdsME4h\n\tunTjOv4dP9C9nTbgy8TAVMrP4cJNSqBVsT/QXRgbF0JNVN6Wg/ukxzb0AJNCAM2Ouh\n\ttj8YnCwret1K4XgYvhefcPOSK8DHcBsjo/iV4Kcc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AGBsq8c6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 19 Aug 2022 14:16:10 +0300", "Message-Id": "<20220819111615.39814-2-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220819111615.39814-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220819111615.39814-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 1/6] py: meson: Use libcamera_private\n\tdependency", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We define -DLIBCAMERA_BASE_PRIVATE to get access to libcamera private\nheaders, but the correct way to do this is to have a meson dependency to\nlibcamera_private.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/libcamera/meson.build | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 04578bac..99c2a8c0 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -60,7 +60,7 @@ pycamera_sources += custom_target('py_gen_formats',\n command : [gen_py_formats, '-o', '@OUTPUT@', '@INPUT@'])\n \n pycamera_deps = [\n- libcamera_public,\n+ libcamera_private,\n py3_dep,\n pybind11_dep,\n ]\n@@ -69,7 +69,6 @@ pycamera_args = [\n '-fvisibility=hidden',\n '-Wno-shadow',\n '-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT',\n- '-DLIBCAMERA_BASE_PRIVATE',\n ]\n \n destdir = get_option('libdir') / ('python' + py3_dep.version()) / 'site-packages' / 'libcamera'\n", "prefixes": [ "libcamera-devel", "v4", "1/6" ] }