Patch Detail
Show a patch.
GET /api/patches/1710/?format=api
{ "id": 1710, "url": "https://patchwork.libcamera.org/api/patches/1710/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1710/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190716070508.24589-4-paul.elder@ideasonboard.com>", "date": "2019-07-16T07:05:08", "name": "[libcamera-devel,v2,4/4] test: logging: move logging tests to a subdirectory", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7eecdcfe2c6866ead8d0853f165fee9237d5f000", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1710/mbox/", "series": [ { "id": 435, "url": "https://patchwork.libcamera.org/api/series/435/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=435", "date": "2019-07-16T07:05:05", "name": "[libcamera-devel,v2,1/4] libcamera: logging: add syslog, stream, and nowhere logging targets", "version": 2, "mbox": "https://patchwork.libcamera.org/series/435/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1710/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1710/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0A6C61AC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jul 2019 09:05:24 +0200 (CEST)", "from emerald.amanokami.net (unknown\n\t[IPv6:2a00:79e1:abc:3602:b57a:2dda:be67:ac6e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91E6F564;\n\tTue, 16 Jul 2019 09:05:23 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563260724;\n\tbh=sJiOclYpNmyTcwbor8cfXt0467JFUMamxaau7g2iDCM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RvU49q9RsCWrNss/lEUfEB5i7Bdck0iNSnSSOztYVJzdqZ03b75L4tixvHmSnaTBO\n\txW4W6p39x1QLtYRJNHRx+0xLyyxLSKSTq5hOGJDss/cuwXCcwEqey5RFy9z/2UM4G8\n\tSd0WsxE8yXRQjhpM9PaJlgPorzcxeR8jRpJBYXAI=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Jul 2019 16:05:08 +0900", "Message-Id": "<20190716070508.24589-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190716070508.24589-1-paul.elder@ideasonboard.com>", "References": "<20190716070508.24589-1-paul.elder@ideasonboard.com>", "Subject": "[libcamera-devel] [PATCH v2 4/4] test: logging: move logging tests\n\tto a subdirectory", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 16 Jul 2019 07:05:25 -0000" }, "content": "Since there are two logging tests now, move them to their own\nsubdirectory. Update meson as necessary.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nNo changes in v2\n\n test/{log.cpp => log/log_api.cpp} | 0\n test/{ => log}/log_process.cpp | 0\n test/log/meson.build | 13 +++++++++++++\n test/meson.build | 3 +--\n 4 files changed, 14 insertions(+), 2 deletions(-)\n rename test/{log.cpp => log/log_api.cpp} (100%)\n rename test/{ => log}/log_process.cpp (100%)\n create mode 100644 test/log/meson.build", "diff": "diff --git a/test/log.cpp b/test/log/log_api.cpp\nsimilarity index 100%\nrename from test/log.cpp\nrename to test/log/log_api.cpp\ndiff --git a/test/log_process.cpp b/test/log/log_process.cpp\nsimilarity index 100%\nrename from test/log_process.cpp\nrename to test/log/log_process.cpp\ndiff --git a/test/log/meson.build b/test/log/meson.build\nnew file mode 100644\nindex 0000000..95f6c1a\n--- /dev/null\n+++ b/test/log/meson.build\n@@ -0,0 +1,13 @@\n+log_test = [\n+ ['log_api', 'log_api.cpp'],\n+ ['log_process', 'log_process.cpp'],\n+]\n+\n+foreach t : log_test\n+ exe = executable(t[0], t[1],\n+ dependencies : libcamera_dep,\n+ link_with : test_libraries,\n+ include_directories : test_includes_internal)\n+\n+ test(t[0], exe, suite : 'log')\n+endforeach\ndiff --git a/test/meson.build b/test/meson.build\nindex 658f283..b2f809e 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -4,6 +4,7 @@ subdir('camera')\n subdir('controls')\n subdir('ipa')\n subdir('ipc')\n+subdir('log')\n subdir('media_device')\n subdir('pipeline')\n subdir('process')\n@@ -22,8 +23,6 @@ public_tests = [\n \n internal_tests = [\n ['camera-sensor', 'camera-sensor.cpp'],\n- ['log', 'log.cpp'],\n- ['log_process', 'log_process.cpp'],\n ['message', 'message.cpp'],\n ['signal-threads', 'signal-threads.cpp'],\n ['threads', 'threads.cpp'],\n", "prefixes": [ "libcamera-devel", "v2", "4/4" ] }