Patch Detail
Show a patch.
GET /api/patches/17043/?format=api
{ "id": 17043, "url": "https://patchwork.libcamera.org/api/patches/17043/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17043/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220809144617.27983-2-laurent.pinchart@ideasonboard.com>", "date": "2022-08-09T14:46:14", "name": "[libcamera-devel,v2,1/4] pipeline: ipu3: Support IPA tuning file", "commit_ref": "56555b22c3b0f7d2cba398fb1adfd026abf11617", "pull_url": null, "state": "accepted", "archived": false, "hash": "72e6c2e76fb82a0bc0efee75dfe9118de58b7d7f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17043/mbox/", "series": [ { "id": 3397, "url": "https://patchwork.libcamera.org/api/series/3397/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3397", "date": "2022-08-09T14:46:13", "name": "Add tuning data file support to the IPU3 IPA modul", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3397/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17043/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17043/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0784C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 9 Aug 2022 14:46:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D810161FAA;\n\tTue, 9 Aug 2022 16:46:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEEA663326\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Aug 2022 16:46:30 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 656FC481\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Aug 2022 16:46:30 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660056391;\n\tbh=IqgwJzWwZmG+4h3hxWE+ufUyPyrffDUg3JgClKRlfzM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=KYhG3QCrreUe3EJr4Q2r9jEIXTppTkKR4rqZq/DyZwGyViFEuNYlUnfxutspH5YdW\n\t3NjF9oZf8YnGIXXUfX9a5zq3ZmfPy8RHqEUR4t5q4zjt7X50asWppr24tbEd/6fCTL\n\tBQWWR6jtpAoz4GZmcpJ4k4Al+Vbh1JQtYVnwTcHq7hYRUCWD+fvTugOossbAyGaeaI\n\tLNeMx5xVxT3rjSJsVdViETh0Z/GSDexpg2/emOcV5lCFChNHjrwC/A9KjTOLwUBfIQ\n\tRKIz+ZdYyb12V1gvTxUvUQyljh62PvXeFccqPf9RAC1D9M5KxlkXqaam6Qged95jzh\n\txAvew/IcJKr/A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660056390;\n\tbh=IqgwJzWwZmG+4h3hxWE+ufUyPyrffDUg3JgClKRlfzM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=VkAhZr/Dr9QZHlEDiTHCEGGMnaAdA4JW0g/a9XPldE1fXrqqIjrprgFAA4QNJRnsX\n\tzc96VZcIBOpsckkWmmMU6UW57sUxqBz45bq2ALDrtH+Lq8X0NpP2+Q5AHA0wNx97C7\n\tgOGY4B/lo+chzYDw/rCIn5qZOOw88WDA/M5iEGOU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VkAhZr/D\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 9 Aug 2022 17:46:14 +0300", "Message-Id": "<20220809144617.27983-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220809144617.27983-1-laurent.pinchart@ideasonboard.com>", "References": "<20220809144617.27983-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/4] pipeline: ipu3: Support IPA tuning\n\tfile", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Pass the path name of the YAML IPA tuning file to the IPA module. The\nfile name is derived from the sensor name (\"${sensor_name}.yaml\"), with\na fallback to \"uncalibrated.yaml\".\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v1:\n\n- Drop LIBCAMERA_IPU3_TUNING_FILE\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 4fe52f74a68c..9df2460323c1 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1243,8 +1243,16 @@ int IPU3CameraData::loadIPA()\n \tif (ret)\n \t\treturn ret;\n \n-\tret = ipa_->init(IPASettings{ \"\", sensor->model() }, sensorInfo,\n-\t\t\t sensor->controls(), &ipaControls_);\n+\t/*\n+\t * The API tuning file is made from the sensor name. If the tuning file\n+\t * isn't found, fall back to the 'uncalibrated' file.\n+\t */\n+\tstd::string ipaTuningFile = ipa_->configurationFile(sensor->model() + \".yaml\");\n+\tif (ipaTuningFile.empty())\n+\t\tipaTuningFile = ipa_->configurationFile(\"uncalibrated.yaml\");\n+\n+\tret = ipa_->init(IPASettings{ ipaTuningFile, sensor->model() },\n+\t\t\t sensorInfo, sensor->controls(), &ipaControls_);\n \tif (ret) {\n \t\tLOG(IPU3, Error) << \"Failed to initialise the IPU3 IPA\";\n \t\treturn ret;\n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }