Patch Detail
Show a patch.
GET /api/patches/17029/?format=api
{ "id": 17029, "url": "https://patchwork.libcamera.org/api/patches/17029/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17029/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220808203026.2515013-1-kieran.bingham@ideasonboard.com>", "date": "2022-08-08T20:30:26", "name": "[libcamera-devel] libcamera: yaml_parser: Report filename on failures", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bffa19960f72e38ec81019f36e0c6f10d6818c14", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/17029/mbox/", "series": [ { "id": 3390, "url": "https://patchwork.libcamera.org/api/series/3390/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3390", "date": "2022-08-08T20:30:26", "name": "[libcamera-devel] libcamera: yaml_parser: Report filename on failures", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3390/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17029/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17029/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52FFBC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Aug 2022 20:30:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD0AF6332B;\n\tMon, 8 Aug 2022 22:30:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 054A363315\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Aug 2022 22:30:35 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C7C5481;\n\tMon, 8 Aug 2022 22:30:34 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659990636;\n\tbh=E9oCWosy+n6yL6UPh2kbPoaGyoguSB+zQTmlQ04snSw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=LxlD5HxYZPb675wMHWVchlOz18sRRmXNU1XTm2xRsmLivFt/D3AfYe8LPPgcN6loG\n\tUHEk8GlVGOgggZy2mXoqRNaQofBjQLHho6Lsn5DusyJs026hHzgwLFzb6o4UYUsm+w\n\tXbs7effP1Bpkj5suIoIeGCql+4SGznfQ7iWLRWy2qzzX8mt1FHjIHQpf1Bd9GlgQaM\n\tv0k55cqKJbwjs1RjVUbwBcN/lAGZoxOkmf1QHaZ8rG/EQ2i2K1zEzq6WvDNEMaEhy7\n\tiZ4rJfuzNKhGfrwyx+XHAvbMK3/1YUzcki9ehkEhLlEsjRSJEVUo7xT6UHwoFgMI2G\n\tt0r8InEbiFE8w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659990634;\n\tbh=E9oCWosy+n6yL6UPh2kbPoaGyoguSB+zQTmlQ04snSw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TRlvtmG6aztd1JpF1w3uFmnTRg95JmW2HKcwEPpLkYcBf5C6s2+yZhOiUzLYEn9LQ\n\t7n4A3biKiSztk0Vw7bgn93YQA/pW+n/Sq3JA3UCKgT/IJl6q6MfFRH5vWnfftvUdHl\n\tQUaxlDpseXTvT+qdXpPHWyNJlVHviOHn4kyuLS6Q=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TRlvtmG6\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 8 Aug 2022 21:30:26 +0100", "Message-Id": "<20220808203026.2515013-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: yaml_parser: Report filename\n\ton failures", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It can be helpful to know 'which' file failed to parse if there is a\nfailure.\n\nReport it to the user in the error message.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nThis was failing for me while adding an IPU3 tuning file - with no\nindication as to where to look.\n\n src/libcamera/yaml_parser.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex c96e99e1317c..dfbfac304d3d 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -807,7 +807,7 @@ std::unique_ptr<YamlObject> YamlParser::parse(File &file)\n \tstd::unique_ptr<YamlObject> root(new YamlObject());\n \n \tif (context.parseContent(*root)) {\n-\t\tLOG(YamlParser, Error) << \"Failed to parse YAML content\";\n+\t\tLOG(YamlParser, Error) << \"Failed to parse YAML content from \" << file.fileName();\n \t\treturn nullptr;\n \t}\n \n", "prefixes": [ "libcamera-devel" ] }