Patch Detail
Show a patch.
GET /api/patches/16999/?format=api
{ "id": 16999, "url": "https://patchwork.libcamera.org/api/patches/16999/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16999/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220807021456.9578-2-laurent.pinchart@ideasonboard.com>", "date": "2022-08-07T02:14:52", "name": "[libcamera-devel,1/5] Revert \"libcamera: Make IPA module signing mandatory for the meantime\"", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "aefbc3cc77c09f68a486cdb8ba7fc4b7d74eb896", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16999/mbox/", "series": [ { "id": 3380, "url": "https://patchwork.libcamera.org/api/series/3380/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3380", "date": "2022-08-07T02:14:51", "name": "libcamera: Support openssl as an alternative to gnutls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3380/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16999/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16999/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2A77BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 7 Aug 2022 02:15:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E7156332F;\n\tSun, 7 Aug 2022 04:15:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 592C761FAA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 7 Aug 2022 04:15:07 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3DFA56D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 7 Aug 2022 04:15:06 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659838509;\n\tbh=J1Nu6wYo9mW9A9gT4PKiF93bUbRKLqJlJKNzkExSJyA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=RPtduUVB/8u3ep245vM5+fog0jqVnmVSGdJ0drpyqZntZJNVy0VRguUYizhTZwLqu\n\tz9L0EX5sOLhm67FBRFkpt8hZ/pZvL2AjtoJ000W7w0llHXw8zx92L407fxOUciYK/6\n\tIAdWPprsTIyP0+szEAgMbuF97HAhgLOb2ero72F1RNMR0JItukz2yIl6inlYBPlnfH\n\tCUOewxQt++Y8gZ3vyIRRP2cahi/11zimkI1FXJk9fR7DGcGuwsI1sEsD8OXtDA3NKT\n\txVRmqgiZXVD/ZLE+aClXm5RH5TlbVymB5A7Vp2FklN+3sSAFbCLSc8q64PUGDOI0n0\n\ty4ZjNf3VkRmiQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659838507;\n\tbh=J1Nu6wYo9mW9A9gT4PKiF93bUbRKLqJlJKNzkExSJyA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=IDLvJpOdCWyeM5q8vKY+MtBso7KYD7FhlIHal8AhSOtHu7QA9A9XQykNC2mSFp4xY\n\t2m1P0Rg6gDn8gaaIWcDgZ8roWMjCqmqsGHxtqBaiU6ZcbCvNhHZRGpuPn5YfU7a92c\n\tx8VYmUmcHB0sKOdDaUOxgRA/tPhhpFmyz3+qin8U=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IDLvJpOd\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 7 Aug 2022 05:14:52 +0300", "Message-Id": "<20220807021456.9578-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220807021456.9578-1-laurent.pinchart@ideasonboard.com>", "References": "<20220807021456.9578-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/5] Revert \"libcamera: Make IPA module\n\tsigning mandatory for the meantime\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Commit b382f67c833d (\"libcamera: Make IPA module signing mandatory for\nthe meantime\") made openssl and gnutls dependencies mandatory to work\naround the lack of proper IPA module isolation support, which broke\noperation without module signatures. Now that this has been fixed, we\ncan make the dependencies optional again.\n\nThis reverts commit b382f67c833de08717cfec19273b95f5819cab27.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n README.rst | 2 +-\n src/libcamera/meson.build | 2 +-\n src/meson.build | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/README.rst b/README.rst\nindex 77374c6a72b1..ffecd5bc6552 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -60,7 +60,7 @@ Meson Build system: [required]\n for the libcamera core: [required]\n libyaml-dev python3-yaml python3-ply python3-jinja2\n \n-for IPA module signing: [required]\n+for IPA module signing: [optional]\n libgnutls28-dev openssl\n \n for improved debugging: [optional]\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex b57bee7ef6ca..ff0e31ebcb63 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -65,7 +65,7 @@ subdir('pipeline')\n subdir('proxy')\n \n libdl = cc.find_library('dl')\n-libgnutls = cc.find_library('gnutls', required : true)\n+libgnutls = cc.find_library('gnutls', required : false)\n libudev = dependency('libudev', required : false)\n libyaml = dependency('yaml-0.1', required : false)\n \ndiff --git a/src/meson.build b/src/meson.build\nindex 34663a6f134d..65276fc74606 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -14,7 +14,7 @@ summary({\n }, section : 'Paths')\n \n # Module Signing\n-openssl = find_program('openssl', required : true)\n+openssl = find_program('openssl', required : false)\n if openssl.found()\n ipa_priv_key = custom_target('ipa-priv-key',\n output : ['ipa-priv-key.pem'],\n", "prefixes": [ "libcamera-devel", "1/5" ] }