Patch Detail
Show a patch.
GET /api/patches/16966/?format=api
{ "id": 16966, "url": "https://patchwork.libcamera.org/api/patches/16966/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16966/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220804132112.17604-3-laurent.pinchart@ideasonboard.com>", "date": "2022-08-04T13:21:12", "name": "[libcamera-devel,2/2] libcamera: Switch internal YAML files to YAML 1.1", "commit_ref": "73570c06371306fe3e75d04149626b6827751854", "pull_url": null, "state": "accepted", "archived": false, "hash": "542300065ae0fec0427ca0647df15e8ebecaa68d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16966/mbox/", "series": [ { "id": 3373, "url": "https://patchwork.libcamera.org/api/series/3373/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3373", "date": "2022-08-04T13:21:10", "name": "Use YAML 1.1 for the time being", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3373/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16966/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16966/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BD3AC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Aug 2022 13:21:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0098E6332D;\n\tThu, 4 Aug 2022 15:21:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50EDB6332F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Aug 2022 15:21:22 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C98956BD;\n\tThu, 4 Aug 2022 15:21:21 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659619285;\n\tbh=5BIJqtpRNphTxpOdz1YKoDvfHEhXKO+dboprbhwo2ns=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DxT8kKIUvo/GLOdINrS4Ny9qV/mbwTxCvDOzZBYG1xHFescJQV8OzXm+5XOiGGMSK\n\tWRR+9pLjYvXsPMZSHLEhudHOyOCSaNcIdcd0GQRfymVaMtLKxqR+TnSRRIxITZ3ziS\n\txBbaS1rqNqefQ6u/n+r4lRCs0FBsXPbLG/bCRbeGogu/WC9EGOly+DF0EPZkzwiddD\n\tDAy8qN2aDLuigSAkfeliaLqh3XKRMgmtQhOuHN4NUzTgWCSsENDPp3F9VaEQBwUNJm\n\tMWE70EG5+W9LlS1Rt6XimJuRZPbkvHUcBBpS4uSFrtNWubl3xfVkFN5rtGXad8gynS\n\tXQZosBDQsYpdQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659619282;\n\tbh=5BIJqtpRNphTxpOdz1YKoDvfHEhXKO+dboprbhwo2ns=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XbLC7p/L81dia0PRi4hCO6kO+wimrFCzCQh1tDBDlOBePavLcXKq4ye9b6UI5KOkf\n\tC5Yv/1gVGUgoU3OOfW/mZzlmLCsSWMpILQeIGDQnNLUeVdrC6DEV4jWbufdImi8RwJ\n\tx0ozZN0jJWMZG9DMJ0BZL06Lpg7ad0ywB9u5s4RA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XbLC7p/L\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Aug 2022 16:21:12 +0300", "Message-Id": "<20220804132112.17604-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220804132112.17604-1-laurent.pinchart@ideasonboard.com>", "References": "<20220804132112.17604-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: Switch internal YAML files\n\tto YAML 1.1", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The python3-yaml package shipped by Debian is based on libyaml 0.2.2,\nwhich doesn't support YAML 1.2. It is documented as such:\n\n Python3-yaml is a complete YAML 1.1 parser and emitter for Python3.\n\nFor some reasons the internal YAML files used to generate format- and\ncontrol-related source files still parse correctly, despite the YAML 1.2\ndirective at the beginning. Still, given that we don't use any feature\nof YAML 1.2, and that the tuning data files now use YAML 1.1, switch the\ninternal YAML files to version 1.1 as well for consistency.\n\nThe main drawback of YAML 1.1 is that the unquoted literal strings Yes,\nNo, On and Off will be parsed as booleans. We need to be careful to\navoid those values in YAML files, until libcamera can switch to YAML 1.2\nonce more recent versions of libyaml get shipped by the distributions we\nwant to support.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/control_ids.yaml | 2 +-\n src/libcamera/formats.yaml | 2 +-\n src/libcamera/property_ids.yaml | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex ecab3ae97260..5510feefdfeb 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -2,7 +2,7 @@\n #\n # Copyright (C) 2019, Google Inc.\n #\n-%YAML 1.2\n+%YAML 1.1\n ---\n # Unless otherwise stated, all controls are bi-directional, i.e. they can be\n # set through Request::controls() and returned out through Request::metadata().\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex d3fbf5f47211..e586cde1d705 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -2,7 +2,7 @@\n #\n # Copyright (C) 2020, Google Inc.\n #\n-%YAML 1.2\n+%YAML 1.1\n ---\n formats:\n - R8:\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 11b7ebdc3105..cb55e0ed2283 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -2,7 +2,7 @@\n #\n # Copyright (C) 2019, Google Inc.\n #\n-%YAML 1.2\n+%YAML 1.1\n ---\n controls:\n - Location:\n", "prefixes": [ "libcamera-devel", "2/2" ] }