Patch Detail
Show a patch.
GET /api/patches/16939/?format=api
{ "id": 16939, "url": "https://patchwork.libcamera.org/api/patches/16939/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16939/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220803112150.3040287-5-paul.elder@ideasonboard.com>", "date": "2022-08-03T11:21:45", "name": "[libcamera-devel,4/9] libcamera: ipa_data_serializer: Add serializer for Flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8fa09a720c589907be6e7d2e4181c17b57e03878", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16939/mbox/", "series": [ { "id": 3367, "url": "https://patchwork.libcamera.org/api/series/3367/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3367", "date": "2022-08-03T11:21:41", "name": "utils: ipc: Add support for enums and Flags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3367/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16939/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16939/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DDCFC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Aug 2022 11:22:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D83063321;\n\tWed, 3 Aug 2022 13:22:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9858663319\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Aug 2022 13:22:06 +0200 (CEST)", "from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EBEF8B;\n\tWed, 3 Aug 2022 13:22:05 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659525728;\n\tbh=6RkYVuiwILJ4ss1QUppUyratAS0rhzobzLXSzzLlTRk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Js1771umRzf6HupnpYjzjzmjKFfitPWJCDmPljs0B7KABsJpei+6Zfw3do8dBNU4w\n\tjSnE2nrKV6gD6B+vWQcwrl7/TCLjEzLf96Q7biaxCBS2xAJ6TEgkdm+zJxaHoIAB3N\n\tIAFa+XI0FhDRSKvo39QDa+x5ev2YWm+l9XdliGPWJ+FuAIt/i/y/rFwFRAsgyEaCow\n\tfwmZJP2FmQ4e6Y49iJYNh8/OeGLLQdCizOzZWUXJ1XHAzEJQOrUHp9xX+HxwhjVzh+\n\tS330MArJrBOVQ8U8ntjH8T8C/CsC5nNG7jfTCEnuVTjoz4RaS6FEhch2kQtx/9iGNY\n\td1IH5SF+3Mv2g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659525726;\n\tbh=6RkYVuiwILJ4ss1QUppUyratAS0rhzobzLXSzzLlTRk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QcT3HPtlVWyHyUh3IERnFpXcpFuZ/K3+xuocD3UD9GlhSg5OalYdYmPnxYM1rUrEg\n\tC9NTU4S5jHzwWigFYIBWismcVTcoVcYFdERgdmHeNXUrFB28rqD80CHio3zMgvMQZN\n\t+fZ0jv+XV9IdtEcOM4KSVcKWQixRlbMxM6rRJNtI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QcT3HPtl\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 3 Aug 2022 20:21:45 +0900", "Message-Id": "<20220803112150.3040287-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220803112150.3040287-1-paul.elder@ideasonboard.com>", "References": "<20220803112150.3040287-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/9] libcamera: ipa_data_serializer: Add\n\tserializer for Flags", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement an IPADataSerializer for Flags.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n .../libcamera/internal/ipa_data_serializer.h | 48 +++++++++++++++++++\n 1 file changed, 48 insertions(+)", "diff": "diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 30bdaebc..3645da4c 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -14,6 +14,7 @@\n #include <type_traits>\n #include <vector>\n \n+#include <libcamera/base/flags.h>\n #include <libcamera/base/log.h>\n \n #include <libcamera/control_ids.h>\n@@ -301,6 +302,53 @@ public:\n \t}\n };\n \n+/* Serialization format for Flags is same as for PODs */\n+template<typename E>\n+class IPADataSerializer<Flags<E>>\n+{\n+public:\n+\tstatic std::tuple<std::vector<uint8_t>, std::vector<SharedFD>>\n+\tserialize(const Flags<E> &data, [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\tstd::vector<uint8_t> dataVec;\n+\t\tdataVec.reserve(sizeof(Flags<E>));\n+\t\tappendPOD<uint32_t>(dataVec, data.value_);\n+\n+\t\treturn { dataVec, {} };\n+\t}\n+\n+\tstatic Flags<E> deserialize(std::vector<uint8_t> &data,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(data.cbegin(), data.end());\n+\t}\n+\n+\tstatic Flags<E> deserialize(std::vector<uint8_t>::const_iterator dataBegin,\n+\t\t\t\t std::vector<uint8_t>::const_iterator dataEnd,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\tFlags<E> ret;\n+\t\tret.value_ = readPOD<uint32_t>(dataBegin, 0, dataEnd);\n+\t\treturn ret;\n+\t}\n+\n+\tstatic Flags<E> deserialize(std::vector<uint8_t> &data,\n+\t\t\t\t [[maybe_unused]] std::vector<SharedFD> &fds,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(data.cbegin(), data.end());\n+\t}\n+\n+\tstatic Flags<E> deserialize(std::vector<uint8_t>::const_iterator dataBegin,\n+\t\t\t\t std::vector<uint8_t>::const_iterator dataEnd,\n+\t\t\t\t [[maybe_unused]] std::vector<SharedFD>::const_iterator fdsBegin,\n+\t\t\t\t [[maybe_unused]] std::vector<SharedFD>::const_iterator fdsEnd,\n+\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n+\t{\n+\t\treturn deserialize(dataBegin, dataEnd);\n+\t}\n+};\n+\n #endif /* __DOXYGEN__ */\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "4/9" ] }