Patch Detail
Show a patch.
GET /api/patches/16900/?format=api
{ "id": 16900, "url": "https://patchwork.libcamera.org/api/patches/16900/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16900/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220802102943.3221109-2-chenghaoyang@google.com>", "date": "2022-08-02T10:29:35", "name": "[libcamera-devel,v4,1/9] Add StreamRole in StreamConfiguration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "77274a45be57fe9a38fa6f5d91bf767c83814527", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16900/mbox/", "series": [ { "id": 3357, "url": "https://patchwork.libcamera.org/api/series/3357/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3357", "date": "2022-08-02T10:29:34", "name": "Use two imgus in ipu3 pipeline handler", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3357/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16900/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16900/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85B2AC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Aug 2022 10:29:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5059163317;\n\tTue, 2 Aug 2022 12:29:54 +0200 (CEST)", "from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com\n\t[IPv6:2607:f8b0:4864:20::102f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36A8463317\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Aug 2022 12:29:52 +0200 (CEST)", "by mail-pj1-x102f.google.com with SMTP id\n\t15-20020a17090a098f00b001f305b453feso18037577pjo.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Aug 2022 03:29:52 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(231.137.80.34.bc.googleusercontent.com. [34.80.137.231])\n\tby smtp.gmail.com with ESMTPSA id\n\tt15-20020a170902e84f00b0016db88f69a2sm1955128plg.141.2022.08.02.03.29.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Aug 2022 03:29:49 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659436194;\n\tbh=tw4t1Vhx/4aMCyf9lekQ1nSSMUPqSV40jp//wFh1paw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=r1C6BsFjmSxynS2cgTJYPb0Bjp6u8aZZbR/AUUms8XpPx+lfyINFnzlY5veHTDvz2\n\tSFL2MtsAgRBmNclOJA6IN+LE7hOteMY9H0r4t86W7QSzPSxKO03Ky31Y66BwXYFv8l\n\t3AkR4xSl3dLeoMg949zlvGn7AGew+N33lVQgF5M/ATd7L0pyepPmNEzlz+4VxbXjYw\n\tSDaTyGmhQkEpix43vG3iuiCNbeEoGnlcKKz5y1sfbY1UdBPHkVdynXXUozgBaNziNq\n\tf9Q2pIFyOCccftyDGzW8cA5ehDzYzEn8TfI5aauYxbd9ev7I6H8Y2AU/a2JnDDE7Lx\n\tDe7awZo7Yixjg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=SDLw6TYV7tOVe7A+8xUir38x5u4H1X4D+n4cs03UeJ0=;\n\tb=O+PVqQBQKjX66ndwqEMSBmpbSi3FOWE1B6QexGA7ga9BZ8y85ALZTajAs3GoyzbuJC\n\tdi4A+uZwS30X4e0bCbjCK7zT3Dk7Y8VlhTLl3cirtEQzD4oGO8VvHUZ4xCCKgNQWcHJU\n\tBatfkGg5UeCghfMvWVXx+L/kFl2mho+Zl/gnk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"O+PVqQBQ\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=SDLw6TYV7tOVe7A+8xUir38x5u4H1X4D+n4cs03UeJ0=;\n\tb=agg26YfOG2zNA4BZ6h7bjHJHrHH5o1DT3iyzaDzWwo8qdhX2Bbpglq61elaOgoGtB1\n\tHEDVgtYLkD8CBzWPlxt8b2AiT4E+rLVqkbAXAQcEvGA7kUukcQ6nJFp6H+lzSsErPR6F\n\tCdWdKdDXAMKsxS9tc+tsRGN4PjTHwShr6NqHVB18bWY5x1+fuChjcUgKBLmQF0Q2SrHB\n\tAASp3jp12/xqxKQs8jQV6U3Q95cEGH+CJqKlVw3qN/iTrtTzGtn2JPdNdVfp06/wmIj0\n\taPgJFMWdlpkSeioBlvVl6FsNazVoqd+85vfCnJHTVJXhG8XZsDNtYSfj14LnTGBt7o5h\n\t7XdQ==", "X-Gm-Message-State": "ACgBeo0y4KtyxEksX0v2S4GQJo1oaeoFGmAadLgeDnzScTszKbHL8pmH\n\ti+H2AKN8DZh8ZXYND96lj00gyfq9n+wLvg==", "X-Google-Smtp-Source": "AA6agR76rIugt/sPCiwM1TLYgm/TX249QnZdR+nElsmPWJReK/xAiUmVQhvnU++l/lDu9I38tBYB6g==", "X-Received": "by 2002:a17:90b:3887:b0:1f2:cc6a:500d with SMTP id\n\tmu7-20020a17090b388700b001f2cc6a500dmr23475846pjb.56.1659436190379; \n\tTue, 02 Aug 2022 03:29:50 -0700 (PDT)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Aug 2022 10:29:35 +0000", "Message-Id": "<20220802102943.3221109-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.37.1.455.g008518b4e5-goog", "In-Reply-To": "<20220802102943.3221109-1-chenghaoyang@google.com>", "References": "<20220802102943.3221109-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 1/9] Add StreamRole in\n\tStreamConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo let ipu3 pipeline handler understand the usage of streams, this patch\nadds StreamRole member variable in StreamConfiguration, which should be\nset by the (Android) adapter.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/stream.h | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex f0ae7e62..c9e79226 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -22,6 +22,15 @@ namespace libcamera {\n class Camera;\n class Stream;\n \n+enum StreamRole {\n+\tRaw,\n+\tStillCapture,\n+\tVideoRecording,\n+\tViewfinder,\n+};\n+\n+using StreamRoles = std::vector<StreamRole>;\n+\n class StreamFormats\n {\n public:\n@@ -50,6 +59,8 @@ struct StreamConfiguration {\n \n \tstd::optional<ColorSpace> colorSpace;\n \n+\tStreamRole streamRole;\n+\n \tStream *stream() const { return stream_; }\n \tvoid setStream(Stream *stream) { stream_ = stream; }\n \tconst StreamFormats &formats() const { return formats_; }\n@@ -61,15 +72,6 @@ private:\n \tStreamFormats formats_;\n };\n \n-enum StreamRole {\n-\tRaw,\n-\tStillCapture,\n-\tVideoRecording,\n-\tViewfinder,\n-};\n-\n-using StreamRoles = std::vector<StreamRole>;\n-\n class Stream\n {\n public:\n", "prefixes": [ "libcamera-devel", "v4", "1/9" ] }