Patch Detail
Show a patch.
GET /api/patches/1689/?format=api
{ "id": 1689, "url": "https://patchwork.libcamera.org/api/patches/1689/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1689/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190713172351.25452-9-laurent.pinchart@ideasonboard.com>", "date": "2019-07-13T17:23:43", "name": "[libcamera-devel,v2,08/16] libcamera: pipeline: ipu3: Use stream configuration to get buffers count", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a1e90692c06247d0d1500e82d2b13cf01c9a364d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1689/mbox/", "series": [ { "id": 430, "url": "https://patchwork.libcamera.org/api/series/430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=430", "date": "2019-07-13T17:23:35", "name": "Add support for external buffers", "version": 2, "mbox": "https://patchwork.libcamera.org/series/430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1689/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1689/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 659E86175D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Jul 2019 19:24:38 +0200 (CEST)", "from pendragon.ideasonboard.com (softbank126209254147.bbtec.net\n\t[126.209.254.147])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2277C443\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Jul 2019 19:24:36 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563038678;\n\tbh=okmAxtUruVB8pinmiOgzJjtkfvoBMrA2UCfcIicLLKc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=SLgwLZj8A9DjQdLhFPqRrg2CnMh98LoD92SA8E84vrbDDhaU7px1y51z3XeEDJgYC\n\tztMjBG/4WJACxoc8Z8fYOA2GTOha46lzpCcMvFsFRR0KhU1PWYIpzRTdnhMqRdeR76\n\t7fU2lu72SUiNoqa48OzXIXW8kLWzPCegKJ9Mi+Lc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 13 Jul 2019 20:23:43 +0300", "Message-Id": "<20190713172351.25452-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190713172351.25452-1-laurent.pinchart@ideasonboard.com>", "References": "<20190713172351.25452-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 08/16] libcamera: pipeline: ipu3: Use\n\tstream configuration to get buffers count", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 13 Jul 2019 17:24:38 -0000" }, "content": "Access the number of allocated buffer for the streams through the stream\nconfiguration instead of the stream's buffers pool.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex ffc066a15ae9..488e89f25c5e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -635,7 +635,7 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera,\n \t * of buffers as the active ones.\n \t */\n \tif (!outStream->active_) {\n-\t\tbufferCount = vfStream->bufferPool().count();\n+\t\tbufferCount = vfStream->configuration().bufferCount;\n \t\toutStream->device_->pool->createBuffers(bufferCount);\n \t\tret = imgu->exportBuffers(outStream->device_,\n \t\t\t\t\t outStream->device_->pool);\n@@ -644,7 +644,7 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera,\n \t}\n \n \tif (!vfStream->active_) {\n-\t\tbufferCount = outStream->bufferPool().count();\n+\t\tbufferCount = outStream->configuration().bufferCount;\n \t\tvfStream->device_->pool->createBuffers(bufferCount);\n \t\tret = imgu->exportBuffers(vfStream->device_,\n \t\t\t\t\t vfStream->device_->pool);\n", "prefixes": [ "libcamera-devel", "v2", "08/16" ] }