Patch Detail
Show a patch.
GET /api/patches/16861/?format=api
{ "id": 16861, "url": "https://patchwork.libcamera.org/api/patches/16861/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16861/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220728120439.4109-1-naush@raspberrypi.com>", "date": "2022-07-28T12:04:39", "name": "[libcamera-devel] ipa: raspberrypi: Remove unused Controller constructor", "commit_ref": "c19150ea94ac095de63fe878282caf3b23dd461f", "pull_url": null, "state": "accepted", "archived": false, "hash": "ff2d8b1452db46686c5e434cb9e2082ed1251b2f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16861/mbox/", "series": [ { "id": 3342, "url": "https://patchwork.libcamera.org/api/series/3342/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3342", "date": "2022-07-28T12:04:39", "name": "[libcamera-devel] ipa: raspberrypi: Remove unused Controller constructor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3342/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16861/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16861/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C718FBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 28 Jul 2022 12:04:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3092763312;\n\tThu, 28 Jul 2022 14:04:44 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAE916330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Jul 2022 14:04:42 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id l4so1882253wrm.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Jul 2022 05:04:42 -0700 (PDT)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\td3-20020adffbc3000000b0021e297d6850sm686531wrs.110.2022.07.28.05.04.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Jul 2022 05:04:41 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659009884;\n\tbh=0t5K11BgVW2Vl7fuyB2H5B3oFysoskwssOfkg0NQb5g=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=PC+JugG7QZ9kkCgPEjUiZN8TrCI/spiarmNypgp1rGg1Q5PJ37bbLn5BBuIWi50Ny\n\tdUhg7mC7mWmhWn2nU4V+AsmpKcYr+w2qHUiN/h5TKnPwaOF0uheBE5fZgDvpCt1o00\n\toxFY39ar6vMPZEGr9WABoIy3sBmpfk8az32P66MUOtyzvLNbbPzEHGU26cKPE52U31\n\tP98zpcY/1KRZ5YM7fDNA4S6vZ5sl+BwxNCINpiW3WGBCwHB4chK9JITT17Q0IEmJIA\n\tFGJ55WuuJFamevbTImAFoH8YQ6ziwnxFp31INqOn1BrK7FDHFH9/kkFzCFASpj/BLw\n\t1yeBflCp48aTw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=HhIv6k0CHJvTBvoaKGV0JcjDyNE1CjTk33FdaEsfZX0=;\n\tb=JQuvz3uxA1x2TRzeuFFmAAXL7MMB6uqv+9OX2yivSEBjvJfehZWMjgdLggU4Law8OM\n\tZGJg2An8kpBpx8HUtAEGRKLAOpHVw70Nh17t6cAw/Uf+YXdEd+gSdjHIsVEabThhXAwk\n\t5KCy7ccbJ6DogrET6UVJFH4J1LldXgJjUKurE35TWOGRlN8uic7qczNsZPie9T9jTVRy\n\tWjEDXvct2JVam+jM/p8hrOKE3ROezUyGCr88opEm+42y6kxhwKiciP6u581wIQzm2JAE\n\ttqnvYU6V1SN3VHeto9IlJc7fTpvmWgvNCxYZFVuzDYE1GfDZd9bRki222T2GKBcyncpR\n\tTc2Q==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"JQuvz3ux\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=HhIv6k0CHJvTBvoaKGV0JcjDyNE1CjTk33FdaEsfZX0=;\n\tb=XvYsuUrG9HqA20zK20fjws+7LJxE42ziwqVwHUgTB+2HBK1r3D0TI04QrZQU5nQ+HV\n\tg7gP7OnhrjOgH9oemjImKHE8565JBejKzYWP8Tx+IgkZyChDYKlodVOXiMfYxRzMo9t4\n\t6qXVJFWVcLMFvPwBVHsAY0LpA0O8xDo8bN9XcxdJunCSLnJuPlXJt29mQC6+Rd1hyrhB\n\tvkTEgs2FWdSV58vGPMgwbsFd2NnCUob0YE45VCowp+WkRqHl0NnuKiSv9LsTOG27dxMf\n\tF8xlWYmkIOLOiRMRX/u+0NVDGvo+jKwvUpbRygD4Xc1ct+N7Ljs909n8X7lrL7/YlGW5\n\tbkgA==", "X-Gm-Message-State": "AJIora+cX/oUih0vuQyO6JCQO4GPuLdmOoVZV8/YFJ0X0HXxuZHdaZGZ\n\tCobr5/qeRbjjo4jvbv6xFGuwyllb9h8RKg==", "X-Google-Smtp-Source": "AGRyM1uaCrYjFxkj0f6wflQ/y/hHbRT9DgXKiukhD1CNIidtAwsb1LDcvAw68rlZWHXQDPApA52JEQ==", "X-Received": "by 2002:a5d:6d04:0:b0:21f:877:e2ef with SMTP id\n\te4-20020a5d6d04000000b0021f0877e2efmr1139136wrq.131.1659009882098; \n\tThu, 28 Jul 2022 05:04:42 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 Jul 2022 13:04:39 +0100", "Message-Id": "<20220728120439.4109-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tController constructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Controller(char const *jsonFilename) is not valid anymore since\nController::read() can now return an error on a failure. Additionally, this\nconstructure is not actually used, so remove it.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/controller.cpp | 7 -------\n src/ipa/raspberrypi/controller/controller.h | 1 -\n 2 files changed, 8 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp\nindex bbd382bce3ab..f489278668ef 100644\n--- a/src/ipa/raspberrypi/controller/controller.cpp\n+++ b/src/ipa/raspberrypi/controller/controller.cpp\n@@ -25,13 +25,6 @@ Controller::Controller()\n {\n }\n \n-Controller::Controller(char const *jsonFilename)\n-\t: switchModeCalled_(false)\n-{\n-\tread(jsonFilename);\n-\tinitialise();\n-}\n-\n Controller::~Controller() {}\n \n int Controller::read(char const *filename)\ndiff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h\nindex 6be1e3cfa156..3e1e051703b3 100644\n--- a/src/ipa/raspberrypi/controller/controller.h\n+++ b/src/ipa/raspberrypi/controller/controller.h\n@@ -40,7 +40,6 @@ class Controller\n {\n public:\n \tController();\n-\tController(char const *jsonFilename);\n \t~Controller();\n \tint read(char const *filename);\n \tvoid initialise();\n", "prefixes": [ "libcamera-devel" ] }