Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 16775,
    "url": "https://patchwork.libcamera.org/api/patches/16775/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/16775/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20220726124549.1646-3-naush@raspberrypi.com>",
    "date": "2022-07-26T12:45:34",
    "name": "[libcamera-devel,02/17] DNI: ipa: raspberrypi: Code refactoring to match style guidelines",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "32281058057ff5d911b822ec061326f793e290d4",
    "submitter": {
        "id": 34,
        "url": "https://patchwork.libcamera.org/api/people/34/?format=api",
        "name": "Naushir Patuck",
        "email": "naush@raspberrypi.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/16775/mbox/",
    "series": [
        {
            "id": 3325,
            "url": "https://patchwork.libcamera.org/api/series/3325/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3325",
            "date": "2022-07-26T12:45:32",
            "name": "Raspberry Pi IPA code refactor",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/3325/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/16775/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/16775/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 047CFC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Jul 2022 12:46:03 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5CD36331F;\n\tTue, 26 Jul 2022 14:46:02 +0200 (CEST)",
            "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9B0963312\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jul 2022 14:45:57 +0200 (CEST)",
            "by mail-wr1-x432.google.com with SMTP id v13so12214167wru.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jul 2022 05:45:57 -0700 (PDT)",
            "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ty17-20020adfd091000000b0021e87ec980bsm5948460wrh.84.2022.07.26.05.45.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Jul 2022 05:45:55 -0700 (PDT)"
        ],
        "DKIM-Signature": [
            "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658839562;\n\tbh=dPOimGnTSzz/eKoPIhQcmpHg0127fFMO6dznMhco1vk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Bb7QFnLV6m8O3ExYnlWrdMEXloVutPJ9yGG2nHNup5qgaKxwSJr88j/bP+YVyjKLc\n\tjawSqjj1JkkLgExsBmit1pE7lErBNAKmxbGOuZEHZ2ACY1spGdXdWpCL3na7gDQBg8\n\tKTE3sI5jxHj3YaKKwmPSOlNykXnxN84v0tAEOU5/9FCCRSPyvVKDoypXbEiv2KTd4l\n\tm2hkgXyt+emPyAxKJ/QmYmGe4kziaIrPr3yXoYmlVcxkVsKruANi+6etwYcd3YPUtr\n\t3Pd0X1+uEI38KIe9S9AZADlK8hC4CVs5oh0TcnO0C7pIsp3oW49oe8o7ZiPc8qNMtH\n\thAGIbPgbL/frA==",
            "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=YmyNbZSPij4ypdh0/SHaeqrjh6STaRheTpjix6rLStw=;\n\tb=XsqNyfWw29mEmDwnwqt74lxHMf32l88B7YAbD7UaRNJwJwQazTxc4lwWsvx5Aw0wd5\n\tGe2ykQPW7PpKFLnP9aKho67nsiDwJIsy56FJ2X7ntImZw24ezV2J9bUgJDOrx2lMUYyL\n\t431pQHWJHMwSKs6YUngdE4OPoTwi1Cn38T48eble6bY4VJAhGg0cDQr4usFmqlhqSo6g\n\t4kH6H56+P+b9Xnnl9xb+U2HAu+zNpDHIIWkJlg4Q7nIAof7+OQmIN1RDQ6OGUm0n75+0\n\tMdO3ovvB8z29v8v+15XJnXG/NM1HxPN3IqzUQpOEmSVCzs+D/zgu2AB0p4ZUSGx6TjPh\n\tL2/Q=="
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"XsqNyfWw\"; dkim-atps=neutral",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=YmyNbZSPij4ypdh0/SHaeqrjh6STaRheTpjix6rLStw=;\n\tb=PLJvzkvGVvusB1kfFap7dUXn391Q3zgp+NrXmrf/INE2NzJBvLbAXjgvb5fz6A7A48\n\t08/rRvp2M1zRWa4CqgCQxysN0mZ1HyJdcSyQ5hg+vVYMfIYp2VPVEKfrCGnZtJ4GPxnt\n\tIpCx8SlnLkydlR7oR+fGGmwXOA/Qb+X9l3Kfh1D80VcISReg1E+4hfw03pFbAXbNDgR7\n\tRVWjWEo/ZXyRb6hsdsaBVw8XXBV0LraztUZ7dh49jAYY8mLcSPx1ONW0/DJN3mitxaB6\n\tuxaUCLp1XDbKzKw0yUkDhVDLNBkLhqSXRYHfBo4OrZ6TN8YzG7IHCbwyBhcf4FVJ3NoD\n\tru8A==",
        "X-Gm-Message-State": "AJIora9uF01ZpbRiC0OjJv3BN6tK1Pc0yVZdBUei9ywYs2VhHB6pu7A7\n\tTdXpQD6P0RpUNCqRQUe8F730DfL7JJPSHg==",
        "X-Google-Smtp-Source": "AGRyM1vVevOMdripn/WRTCFbJmLfISXIeVYD3Z1RA+G+A7EugeF+h3MamavgXm927H+gY0gn5fouEA==",
        "X-Received": "by 2002:a05:6000:78b:b0:21e:a0fd:ce with SMTP id\n\tbu11-20020a056000078b00b0021ea0fd00cemr2076827wrb.309.1658839556468; \n\tTue, 26 Jul 2022 05:45:56 -0700 (PDT)",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Tue, 26 Jul 2022 13:45:34 +0100",
        "Message-Id": "<20220726124549.1646-3-naush@raspberrypi.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220726124549.1646-1-naush@raspberrypi.com>",
        "References": "<20220726124549.1646-1-naush@raspberrypi.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH 02/17] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>",
        "Reply-To": "Naushir Patuck <naush@raspberrypi.com>",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "Refactor the source files src/ipa/raspberrypi/cam_helper* to match the\nrecommended formatting guidelines for the libcamera project. The vast majority\nof changes in this commit comprise of switching from snake_case to CamelCase,\nand starting class member functions with a lower case character.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/cam_helper.cpp        | 88 +++++++++++------------\n src/ipa/raspberrypi/cam_helper.hpp        | 40 +++++------\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 34 ++++-----\n src/ipa/raspberrypi/cam_helper_imx290.cpp | 32 ++++-----\n src/ipa/raspberrypi/cam_helper_imx296.cpp | 24 +++----\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 72 +++++++++----------\n src/ipa/raspberrypi/cam_helper_imx519.cpp | 70 +++++++++---------\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 44 ++++++------\n src/ipa/raspberrypi/cam_helper_ov9281.cpp | 28 ++++----\n 9 files changed, 216 insertions(+), 216 deletions(-)",
    "diff": "diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/raspberrypi/cam_helper.cpp\nindex 3f81d4187d4d..45db39506937 100644\n--- a/src/ipa/raspberrypi/cam_helper.cpp\n+++ b/src/ipa/raspberrypi/cam_helper.cpp\n@@ -24,16 +24,16 @@ namespace libcamera {\n LOG_DECLARE_CATEGORY(IPARPI)\n }\n \n-static std::map<std::string, CamHelperCreateFunc> cam_helpers;\n+static std::map<std::string, CamHelperCreateFunc> camHelpers;\n \n-CamHelper *CamHelper::Create(std::string const &cam_name)\n+CamHelper *CamHelper::create(std::string const &camName)\n {\n \t/*\n \t * CamHelpers get registered by static RegisterCamHelper\n \t * initialisers.\n \t */\n-\tfor (auto &p : cam_helpers) {\n-\t\tif (cam_name.find(p.first) != std::string::npos)\n+\tfor (auto &p : camHelpers) {\n+\t\tif (camName.find(p.first) != std::string::npos)\n \t\t\treturn p.second();\n \t}\n \n@@ -50,35 +50,35 @@ CamHelper::~CamHelper()\n {\n }\n \n-void CamHelper::Prepare(Span<const uint8_t> buffer,\n+void CamHelper::prepare(Span<const uint8_t> buffer,\n \t\t\tMetadata &metadata)\n {\n \tparseEmbeddedData(buffer, metadata);\n }\n \n-void CamHelper::Process([[maybe_unused]] StatisticsPtr &stats,\n+void CamHelper::process([[maybe_unused]] StatisticsPtr &stats,\n \t\t\t[[maybe_unused]] Metadata &metadata)\n {\n }\n \n-uint32_t CamHelper::ExposureLines(const Duration exposure) const\n+uint32_t CamHelper::exposureLines(const Duration exposure) const\n {\n \tassert(initialized_);\n-\treturn exposure / mode_.line_length;\n+\treturn exposure / mode_.lineLength;\n }\n \n-Duration CamHelper::Exposure(uint32_t exposure_lines) const\n+Duration CamHelper::exposure(uint32_t exposureLines) const\n {\n \tassert(initialized_);\n-\treturn exposure_lines * mode_.line_length;\n+\treturn exposureLines * mode_.lineLength;\n }\n \n-uint32_t CamHelper::GetVBlanking(Duration &exposure,\n+uint32_t CamHelper::getVBlanking(Duration &exposure,\n \t\t\t\t Duration minFrameDuration,\n \t\t\t\t Duration maxFrameDuration) const\n {\n \tuint32_t frameLengthMin, frameLengthMax, vblank;\n-\tuint32_t exposureLines = ExposureLines(exposure);\n+\tuint32_t exposureLines = CamHelper::exposureLines(exposure);\n \n \tassert(initialized_);\n \n@@ -86,15 +86,15 @@ uint32_t CamHelper::GetVBlanking(Duration &exposure,\n \t * minFrameDuration and maxFrameDuration are clamped by the caller\n \t * based on the limits for the active sensor mode.\n \t */\n-\tframeLengthMin = minFrameDuration / mode_.line_length;\n-\tframeLengthMax = maxFrameDuration / mode_.line_length;\n+\tframeLengthMin = minFrameDuration / mode_.lineLength;\n+\tframeLengthMax = maxFrameDuration / mode_.lineLength;\n \n \t/*\n \t * Limit the exposure to the maximum frame duration requested, and\n \t * re-calculate if it has been clipped.\n \t */\n \texposureLines = std::min(frameLengthMax - frameIntegrationDiff_, exposureLines);\n-\texposure = Exposure(exposureLines);\n+\texposure = CamHelper::exposure(exposureLines);\n \n \t/* Limit the vblank to the range allowed by the frame length limits. */\n \tvblank = std::clamp(exposureLines + frameIntegrationDiff_,\n@@ -102,34 +102,34 @@ uint32_t CamHelper::GetVBlanking(Duration &exposure,\n \treturn vblank;\n }\n \n-void CamHelper::SetCameraMode(const CameraMode &mode)\n+void CamHelper::setCameraMode(const CameraMode &mode)\n {\n \tmode_ = mode;\n \tif (parser_) {\n-\t\tparser_->SetBitsPerPixel(mode.bitdepth);\n-\t\tparser_->SetLineLengthBytes(0); /* We use SetBufferSize. */\n+\t\tparser_->setBitsPerPixel(mode.bitdepth);\n+\t\tparser_->setLineLengthBytes(0); /* We use SetBufferSize. */\n \t}\n \tinitialized_ = true;\n }\n \n-void CamHelper::GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t  int &vblank_delay) const\n+void CamHelper::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t  int &vblankDelay) const\n {\n \t/*\n \t * These values are correct for many sensors. Other sensors will\n \t * need to over-ride this function.\n \t */\n-\texposure_delay = 2;\n-\tgain_delay = 1;\n-\tvblank_delay = 2;\n+\texposureDelay = 2;\n+\tgainDelay = 1;\n+\tvblankDelay = 2;\n }\n \n-bool CamHelper::SensorEmbeddedDataPresent() const\n+bool CamHelper::sensorEmbeddedDataPresent() const\n {\n \treturn false;\n }\n \n-double CamHelper::GetModeSensitivity([[maybe_unused]] const CameraMode &mode) const\n+double CamHelper::getModeSensitivity([[maybe_unused]] const CameraMode &mode) const\n {\n \t/*\n \t * Most sensors have the same sensitivity in every mode, but this\n@@ -140,7 +140,7 @@ double CamHelper::GetModeSensitivity([[maybe_unused]] const CameraMode &mode) co\n \treturn 1.0;\n }\n \n-unsigned int CamHelper::HideFramesStartup() const\n+unsigned int CamHelper::hideFramesStartup() const\n {\n \t/*\n \t * The number of frames when a camera first starts that shouldn't be\n@@ -149,19 +149,19 @@ unsigned int CamHelper::HideFramesStartup() const\n \treturn 0;\n }\n \n-unsigned int CamHelper::HideFramesModeSwitch() const\n+unsigned int CamHelper::hideFramesModeSwitch() const\n {\n \t/* After a mode switch, many sensors return valid frames immediately. */\n \treturn 0;\n }\n \n-unsigned int CamHelper::MistrustFramesStartup() const\n+unsigned int CamHelper::mistrustFramesStartup() const\n {\n \t/* Many sensors return a single bad frame on start-up. */\n \treturn 1;\n }\n \n-unsigned int CamHelper::MistrustFramesModeSwitch() const\n+unsigned int CamHelper::mistrustFramesModeSwitch() const\n {\n \t/* Many sensors return valid metadata immediately. */\n \treturn 0;\n@@ -176,13 +176,13 @@ void CamHelper::parseEmbeddedData(Span<const uint8_t> buffer,\n \tif (buffer.empty())\n \t\treturn;\n \n-\tif (parser_->Parse(buffer, registers) != MdParser::Status::OK) {\n+\tif (parser_->parse(buffer, registers) != MdParser::Status::OK) {\n \t\tLOG(IPARPI, Error) << \"Embedded data buffer parsing failed\";\n \t\treturn;\n \t}\n \n-\tPopulateMetadata(registers, parsedMetadata);\n-\tmetadata.Merge(parsedMetadata);\n+\tpopulateMetadata(registers, parsedMetadata);\n+\tmetadata.merge(parsedMetadata);\n \n \t/*\n \t * Overwrite the exposure/gain, frame length and sensor temperature values\n@@ -190,30 +190,30 @@ void CamHelper::parseEmbeddedData(Span<const uint8_t> buffer,\n \t * Fetch it first in case any other fields were set meaningfully.\n \t */\n \tDeviceStatus deviceStatus, parsedDeviceStatus;\n-\tif (metadata.Get(\"device.status\", deviceStatus) ||\n-\t    parsedMetadata.Get(\"device.status\", parsedDeviceStatus)) {\n+\tif (metadata.get(\"device.status\", deviceStatus) ||\n+\t    parsedMetadata.get(\"device.status\", parsedDeviceStatus)) {\n \t\tLOG(IPARPI, Error) << \"DeviceStatus not found\";\n \t\treturn;\n \t}\n \n-\tdeviceStatus.shutter_speed = parsedDeviceStatus.shutter_speed;\n-\tdeviceStatus.analogue_gain = parsedDeviceStatus.analogue_gain;\n-\tdeviceStatus.frame_length = parsedDeviceStatus.frame_length;\n-\tif (parsedDeviceStatus.sensor_temperature)\n-\t\tdeviceStatus.sensor_temperature = parsedDeviceStatus.sensor_temperature;\n+\tdeviceStatus.shutterSpeed = parsedDeviceStatus.shutterSpeed;\n+\tdeviceStatus.analogueGain = parsedDeviceStatus.analogueGain;\n+\tdeviceStatus.frameLength = parsedDeviceStatus.frameLength;\n+\tif (parsedDeviceStatus.sensorTemperature)\n+\t\tdeviceStatus.sensorTemperature = parsedDeviceStatus.sensorTemperature;\n \n \tLOG(IPARPI, Debug) << \"Metadata updated - \" << deviceStatus;\n \n-\tmetadata.Set(\"device.status\", deviceStatus);\n+\tmetadata.set(\"device.status\", deviceStatus);\n }\n \n-void CamHelper::PopulateMetadata([[maybe_unused]] const MdParser::RegisterMap &registers,\n+void CamHelper::populateMetadata([[maybe_unused]] const MdParser::RegisterMap &registers,\n \t\t\t\t [[maybe_unused]] Metadata &metadata) const\n {\n }\n \n-RegisterCamHelper::RegisterCamHelper(char const *cam_name,\n-\t\t\t\t     CamHelperCreateFunc create_func)\n+RegisterCamHelper::RegisterCamHelper(char const *camName,\n+\t\t\t\t     CamHelperCreateFunc createFunc)\n {\n-\tcam_helpers[std::string(cam_name)] = create_func;\n+\tcamHelpers[std::string(camName)] = createFunc;\n }\ndiff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex 300f8f8a2d3b..0cd718c4bc4e 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -69,33 +69,33 @@ namespace RPiController {\n class CamHelper\n {\n public:\n-\tstatic CamHelper *Create(std::string const &cam_name);\n+\tstatic CamHelper *create(std::string const &camName);\n \tCamHelper(std::unique_ptr<MdParser> parser, unsigned int frameIntegrationDiff);\n \tvirtual ~CamHelper();\n-\tvoid SetCameraMode(const CameraMode &mode);\n-\tvirtual void Prepare(libcamera::Span<const uint8_t> buffer,\n+\tvoid setCameraMode(const CameraMode &mode);\n+\tvirtual void prepare(libcamera::Span<const uint8_t> buffer,\n \t\t\t     Metadata &metadata);\n-\tvirtual void Process(StatisticsPtr &stats, Metadata &metadata);\n-\tvirtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n-\tvirtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n-\tvirtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n+\tvirtual void process(StatisticsPtr &stats, Metadata &metadata);\n+\tvirtual uint32_t exposureLines(libcamera::utils::Duration exposure) const;\n+\tvirtual libcamera::utils::Duration exposure(uint32_t exposureLines) const;\n+\tvirtual uint32_t getVBlanking(libcamera::utils::Duration &exposure,\n \t\t\t\t      libcamera::utils::Duration minFrameDuration,\n \t\t\t\t      libcamera::utils::Duration maxFrameDuration) const;\n-\tvirtual uint32_t GainCode(double gain) const = 0;\n-\tvirtual double Gain(uint32_t gain_code) const = 0;\n-\tvirtual void GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t       int &vblank_delay) const;\n-\tvirtual bool SensorEmbeddedDataPresent() const;\n-\tvirtual double GetModeSensitivity(const CameraMode &mode) const;\n-\tvirtual unsigned int HideFramesStartup() const;\n-\tvirtual unsigned int HideFramesModeSwitch() const;\n-\tvirtual unsigned int MistrustFramesStartup() const;\n-\tvirtual unsigned int MistrustFramesModeSwitch() const;\n+\tvirtual uint32_t gainCode(double gain) const = 0;\n+\tvirtual double gain(uint32_t gainCode) const = 0;\n+\tvirtual void getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t       int &vblankDelay) const;\n+\tvirtual bool sensorEmbeddedDataPresent() const;\n+\tvirtual double getModeSensitivity(const CameraMode &mode) const;\n+\tvirtual unsigned int hideFramesStartup() const;\n+\tvirtual unsigned int hideFramesModeSwitch() const;\n+\tvirtual unsigned int mistrustFramesStartup() const;\n+\tvirtual unsigned int mistrustFramesModeSwitch() const;\n \n protected:\n \tvoid parseEmbeddedData(libcamera::Span<const uint8_t> buffer,\n \t\t\t       Metadata &metadata);\n-\tvirtual void PopulateMetadata(const MdParser::RegisterMap &registers,\n+\tvirtual void populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t\t      Metadata &metadata) const;\n \n \tstd::unique_ptr<MdParser> parser_;\n@@ -116,8 +116,8 @@ private:\n typedef CamHelper *(*CamHelperCreateFunc)();\n struct RegisterCamHelper\n {\n-\tRegisterCamHelper(char const *cam_name,\n-\t\t\t  CamHelperCreateFunc create_func);\n+\tRegisterCamHelper(char const *camName,\n+\t\t\t  CamHelperCreateFunc createFunc);\n };\n \n } // namespace RPi\ndiff --git a/src/ipa/raspberrypi/cam_helper_imx219.cpp b/src/ipa/raspberrypi/cam_helper_imx219.cpp\nindex a3caab714602..17c35143923a 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx219.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx219.cpp\n@@ -39,10 +39,10 @@ class CamHelperImx219 : public CamHelper\n {\n public:\n \tCamHelperImx219();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tunsigned int MistrustFramesModeSwitch() const override;\n-\tbool SensorEmbeddedDataPresent() const override;\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tunsigned int mistrustFramesModeSwitch() const override;\n+\tbool sensorEmbeddedDataPresent() const override;\n \n private:\n \t/*\n@@ -51,7 +51,7 @@ private:\n \t */\n \tstatic constexpr int frameIntegrationDiff = 4;\n \n-\tvoid PopulateMetadata(const MdParser::RegisterMap &registers,\n+\tvoid populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t      Metadata &metadata) const override;\n };\n \n@@ -64,17 +64,17 @@ CamHelperImx219::CamHelperImx219()\n {\n }\n \n-uint32_t CamHelperImx219::GainCode(double gain) const\n+uint32_t CamHelperImx219::gainCode(double gain) const\n {\n \treturn (uint32_t)(256 - 256 / gain);\n }\n \n-double CamHelperImx219::Gain(uint32_t gain_code) const\n+double CamHelperImx219::gain(uint32_t gainCode) const\n {\n-\treturn 256.0 / (256 - gain_code);\n+\treturn 256.0 / (256 - gainCode);\n }\n \n-unsigned int CamHelperImx219::MistrustFramesModeSwitch() const\n+unsigned int CamHelperImx219::mistrustFramesModeSwitch() const\n {\n \t/*\n \t * For reasons unknown, we do occasionally get a bogus metadata frame\n@@ -84,26 +84,26 @@ unsigned int CamHelperImx219::MistrustFramesModeSwitch() const\n \treturn 1;\n }\n \n-bool CamHelperImx219::SensorEmbeddedDataPresent() const\n+bool CamHelperImx219::sensorEmbeddedDataPresent() const\n {\n \treturn ENABLE_EMBEDDED_DATA;\n }\n \n-void CamHelperImx219::PopulateMetadata(const MdParser::RegisterMap &registers,\n+void CamHelperImx219::populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t\t       Metadata &metadata) const\n {\n \tDeviceStatus deviceStatus;\n \n-\tdeviceStatus.shutter_speed = Exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg));\n-\tdeviceStatus.analogue_gain = Gain(registers.at(gainReg));\n-\tdeviceStatus.frame_length = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg);\n+\tdeviceStatus.shutterSpeed = exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg));\n+\tdeviceStatus.analogueGain = gain(registers.at(gainReg));\n+\tdeviceStatus.frameLength = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg);\n \n-\tmetadata.Set(\"device.status\", deviceStatus);\n+\tmetadata.set(\"device.status\", deviceStatus);\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperImx219();\n }\n \n-static RegisterCamHelper reg(\"imx219\", &Create);\n+static RegisterCamHelper reg(\"imx219\", &create);\ndiff --git a/src/ipa/raspberrypi/cam_helper_imx290.cpp b/src/ipa/raspberrypi/cam_helper_imx290.cpp\nindex 871c1f8eaec4..0d9a94d8d3f6 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx290.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx290.cpp\n@@ -15,11 +15,11 @@ class CamHelperImx290 : public CamHelper\n {\n public:\n \tCamHelperImx290();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tvoid GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t       int &vblank_delay) const override;\n-\tunsigned int HideFramesModeSwitch() const override;\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t       int &vblankDelay) const override;\n+\tunsigned int hideFramesModeSwitch() const override;\n \n private:\n \t/*\n@@ -34,34 +34,34 @@ CamHelperImx290::CamHelperImx290()\n {\n }\n \n-uint32_t CamHelperImx290::GainCode(double gain) const\n+uint32_t CamHelperImx290::gainCode(double gain) const\n {\n \tint code = 66.6667 * log10(gain);\n \treturn std::max(0, std::min(code, 0xf0));\n }\n \n-double CamHelperImx290::Gain(uint32_t gain_code) const\n+double CamHelperImx290::gain(uint32_t gainCode) const\n {\n-\treturn pow(10, 0.015 * gain_code);\n+\treturn pow(10, 0.015 * gainCode);\n }\n \n-void CamHelperImx290::GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t\tint &vblank_delay) const\n+void CamHelperImx290::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay) const\n {\n-\texposure_delay = 2;\n-\tgain_delay = 2;\n-\tvblank_delay = 2;\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 2;\n }\n \n-unsigned int CamHelperImx290::HideFramesModeSwitch() const\n+unsigned int CamHelperImx290::hideFramesModeSwitch() const\n {\n \t/* After a mode switch, we seem to get 1 bad frame. */\n \treturn 1;\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperImx290();\n }\n \n-static RegisterCamHelper reg(\"imx290\", &Create);\n+static RegisterCamHelper reg(\"imx290\", &create);\ndiff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/raspberrypi/cam_helper_imx296.cpp\nindex a1a771cb96d5..15674335fa75 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx296.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n@@ -19,10 +19,10 @@ class CamHelperImx296 : public CamHelper\n {\n public:\n \tCamHelperImx296();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tuint32_t ExposureLines(Duration exposure) const override;\n-\tDuration Exposure(uint32_t exposure_lines) const override;\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tuint32_t exposureLines(Duration exposure) const override;\n+\tDuration exposure(uint32_t exposureLines) const override;\n \n private:\n \tstatic constexpr uint32_t maxGainCode = 239;\n@@ -40,30 +40,30 @@ CamHelperImx296::CamHelperImx296()\n {\n }\n \n-uint32_t CamHelperImx296::GainCode(double gain) const\n+uint32_t CamHelperImx296::gainCode(double gain) const\n {\n \tuint32_t code = 20 * std::log10(gain) * 10;\n \treturn std::min(code, maxGainCode);\n }\n \n-double CamHelperImx296::Gain(uint32_t gain_code) const\n+double CamHelperImx296::gain(uint32_t gainCode) const\n {\n-\treturn std::pow(10.0, gain_code / 200.0);\n+\treturn std::pow(10.0, gainCode / 200.0);\n }\n \n-uint32_t CamHelperImx296::ExposureLines(Duration exposure) const\n+uint32_t CamHelperImx296::exposureLines(Duration exposure) const\n {\n \treturn (exposure - 14.26us) / timePerLine;\n }\n \n-Duration CamHelperImx296::Exposure(uint32_t exposure_lines) const\n+Duration CamHelperImx296::exposure(uint32_t exposureLines) const\n {\n-\treturn exposure_lines * timePerLine + 14.26us;\n+\treturn exposureLines * timePerLine + 14.26us;\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperImx296();\n }\n \n-static RegisterCamHelper reg(\"imx296\", &Create);\n+static RegisterCamHelper reg(\"imx296\", &create);\ndiff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\nindex 0e1c0dbd142f..0767a5e1dcc5 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n@@ -43,14 +43,14 @@ class CamHelperImx477 : public CamHelper\n {\n public:\n \tCamHelperImx477();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tvoid Prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata) override;\n-\tuint32_t GetVBlanking(Duration &exposure, Duration minFrameDuration,\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata) override;\n+\tuint32_t getVBlanking(Duration &exposure, Duration minFrameDuration,\n \t\t\t      Duration maxFrameDuration) const override;\n-\tvoid GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t       int &vblank_delay) const override;\n-\tbool SensorEmbeddedDataPresent() const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t       int &vblankDelay) const override;\n+\tbool sensorEmbeddedDataPresent() const override;\n \n private:\n \t/*\n@@ -63,7 +63,7 @@ private:\n \t/* Largest long exposure scale factor given as a left shift on the frame length. */\n \tstatic constexpr int longExposureShiftMax = 7;\n \n-\tvoid PopulateMetadata(const MdParser::RegisterMap &registers,\n+\tvoid populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t      Metadata &metadata) const override;\n };\n \n@@ -72,22 +72,22 @@ CamHelperImx477::CamHelperImx477()\n {\n }\n \n-uint32_t CamHelperImx477::GainCode(double gain) const\n+uint32_t CamHelperImx477::gainCode(double gain) const\n {\n \treturn static_cast<uint32_t>(1024 - 1024 / gain);\n }\n \n-double CamHelperImx477::Gain(uint32_t gain_code) const\n+double CamHelperImx477::gain(uint32_t gainCode) const\n {\n-\treturn 1024.0 / (1024 - gain_code);\n+\treturn 1024.0 / (1024 - gainCode);\n }\n \n-void CamHelperImx477::Prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata)\n+void CamHelperImx477::prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata)\n {\n \tMdParser::RegisterMap registers;\n \tDeviceStatus deviceStatus;\n \n-\tif (metadata.Get(\"device.status\", deviceStatus)) {\n+\tif (metadata.get(\"device.status\", deviceStatus)) {\n \t\tLOG(IPARPI, Error) << \"DeviceStatus not found from DelayedControls\";\n \t\treturn;\n \t}\n@@ -105,27 +105,27 @@ void CamHelperImx477::Prepare(libcamera::Span<const uint8_t> buffer, Metadata &m\n \t * Otherwise, all values are updated with what is reported in the\n \t * embedded data.\n \t */\n-\tif (deviceStatus.frame_length > frameLengthMax) {\n+\tif (deviceStatus.frameLength > frameLengthMax) {\n \t\tDeviceStatus parsedDeviceStatus;\n \n-\t\tmetadata.Get(\"device.status\", parsedDeviceStatus);\n-\t\tparsedDeviceStatus.shutter_speed = deviceStatus.shutter_speed;\n-\t\tparsedDeviceStatus.frame_length = deviceStatus.frame_length;\n-\t\tmetadata.Set(\"device.status\", parsedDeviceStatus);\n+\t\tmetadata.get(\"device.status\", parsedDeviceStatus);\n+\t\tparsedDeviceStatus.shutterSpeed = deviceStatus.shutterSpeed;\n+\t\tparsedDeviceStatus.frameLength = deviceStatus.frameLength;\n+\t\tmetadata.set(\"device.status\", parsedDeviceStatus);\n \n \t\tLOG(IPARPI, Debug) << \"Metadata updated for long exposure: \"\n \t\t\t\t   << parsedDeviceStatus;\n \t}\n }\n \n-uint32_t CamHelperImx477::GetVBlanking(Duration &exposure,\n+uint32_t CamHelperImx477::getVBlanking(Duration &exposure,\n \t\t\t\t       Duration minFrameDuration,\n \t\t\t\t       Duration maxFrameDuration) const\n {\n \tuint32_t frameLength, exposureLines;\n \tunsigned int shift = 0;\n \n-\tframeLength = mode_.height + CamHelper::GetVBlanking(exposure, minFrameDuration,\n+\tframeLength = mode_.height + CamHelper::getVBlanking(exposure, minFrameDuration,\n \t\t\t\t\t\t\t     maxFrameDuration);\n \t/*\n \t * Check if the frame length calculated needs to be setup for long\n@@ -144,43 +144,43 @@ uint32_t CamHelperImx477::GetVBlanking(Duration &exposure,\n \tif (shift) {\n \t\t/* Account for any rounding in the scaled frame length value. */\n \t\tframeLength <<= shift;\n-\t\texposureLines = ExposureLines(exposure);\n+\t\texposureLines = CamHelperImx477::exposureLines(exposure);\n \t\texposureLines = std::min(exposureLines, frameLength - frameIntegrationDiff);\n-\t\texposure = Exposure(exposureLines);\n+\t\texposure = CamHelperImx477::exposure(exposureLines);\n \t}\n \n \treturn frameLength - mode_.height;\n }\n \n-void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t\tint &vblank_delay) const\n+void CamHelperImx477::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay) const\n {\n-\texposure_delay = 2;\n-\tgain_delay = 2;\n-\tvblank_delay = 3;\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 3;\n }\n \n-bool CamHelperImx477::SensorEmbeddedDataPresent() const\n+bool CamHelperImx477::sensorEmbeddedDataPresent() const\n {\n \treturn true;\n }\n \n-void CamHelperImx477::PopulateMetadata(const MdParser::RegisterMap &registers,\n+void CamHelperImx477::populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t\t       Metadata &metadata) const\n {\n \tDeviceStatus deviceStatus;\n \n-\tdeviceStatus.shutter_speed = Exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg));\n-\tdeviceStatus.analogue_gain = Gain(registers.at(gainHiReg) * 256 + registers.at(gainLoReg));\n-\tdeviceStatus.frame_length = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg);\n-\tdeviceStatus.sensor_temperature = std::clamp<int8_t>(registers.at(temperatureReg), -20, 80);\n+\tdeviceStatus.shutterSpeed = exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg));\n+\tdeviceStatus.analogueGain = gain(registers.at(gainHiReg) * 256 + registers.at(gainLoReg));\n+\tdeviceStatus.frameLength = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg);\n+\tdeviceStatus.sensorTemperature = std::clamp<int8_t>(registers.at(temperatureReg), -20, 80);\n \n-\tmetadata.Set(\"device.status\", deviceStatus);\n+\tmetadata.set(\"device.status\", deviceStatus);\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperImx477();\n }\n \n-static RegisterCamHelper reg(\"imx477\", &Create);\n+static RegisterCamHelper reg(\"imx477\", &create);\ndiff --git a/src/ipa/raspberrypi/cam_helper_imx519.cpp b/src/ipa/raspberrypi/cam_helper_imx519.cpp\nindex eaf24982b37f..1752760e64a2 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx519.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx519.cpp\n@@ -43,14 +43,14 @@ class CamHelperImx519 : public CamHelper\n {\n public:\n \tCamHelperImx519();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tvoid Prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata) override;\n-\tuint32_t GetVBlanking(Duration &exposure, Duration minFrameDuration,\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata) override;\n+\tuint32_t getVBlanking(Duration &exposure, Duration minFrameDuration,\n \t\t\t      Duration maxFrameDuration) const override;\n-\tvoid GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t       int &vblank_delay) const override;\n-\tbool SensorEmbeddedDataPresent() const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t       int &vblankDelay) const override;\n+\tbool sensorEmbeddedDataPresent() const override;\n \n private:\n \t/*\n@@ -63,7 +63,7 @@ private:\n \t/* Largest long exposure scale factor given as a left shift on the frame length. */\n \tstatic constexpr int longExposureShiftMax = 7;\n \n-\tvoid PopulateMetadata(const MdParser::RegisterMap &registers,\n+\tvoid populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t      Metadata &metadata) const override;\n };\n \n@@ -72,22 +72,22 @@ CamHelperImx519::CamHelperImx519()\n {\n }\n \n-uint32_t CamHelperImx519::GainCode(double gain) const\n+uint32_t CamHelperImx519::gainCode(double gain) const\n {\n \treturn static_cast<uint32_t>(1024 - 1024 / gain);\n }\n \n-double CamHelperImx519::Gain(uint32_t gain_code) const\n+double CamHelperImx519::gain(uint32_t gainCode) const\n {\n-\treturn 1024.0 / (1024 - gain_code);\n+\treturn 1024.0 / (1024 - gainCode);\n }\n \n-void CamHelperImx519::Prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata)\n+void CamHelperImx519::prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata)\n {\n \tMdParser::RegisterMap registers;\n \tDeviceStatus deviceStatus;\n \n-\tif (metadata.Get(\"device.status\", deviceStatus)) {\n+\tif (metadata.get(\"device.status\", deviceStatus)) {\n \t\tLOG(IPARPI, Error) << \"DeviceStatus not found from DelayedControls\";\n \t\treturn;\n \t}\n@@ -105,27 +105,27 @@ void CamHelperImx519::Prepare(libcamera::Span<const uint8_t> buffer, Metadata &m\n \t * Otherwise, all values are updated with what is reported in the\n \t * embedded data.\n \t */\n-\tif (deviceStatus.frame_length > frameLengthMax) {\n+\tif (deviceStatus.frameLength > frameLengthMax) {\n \t\tDeviceStatus parsedDeviceStatus;\n \n-\t\tmetadata.Get(\"device.status\", parsedDeviceStatus);\n-\t\tparsedDeviceStatus.shutter_speed = deviceStatus.shutter_speed;\n-\t\tparsedDeviceStatus.frame_length = deviceStatus.frame_length;\n-\t\tmetadata.Set(\"device.status\", parsedDeviceStatus);\n+\t\tmetadata.get(\"device.status\", parsedDeviceStatus);\n+\t\tparsedDeviceStatus.shutterSpeed = deviceStatus.shutterSpeed;\n+\t\tparsedDeviceStatus.frameLength = deviceStatus.frameLength;\n+\t\tmetadata.set(\"device.status\", parsedDeviceStatus);\n \n \t\tLOG(IPARPI, Debug) << \"Metadata updated for long exposure: \"\n \t\t\t\t   << parsedDeviceStatus;\n \t}\n }\n \n-uint32_t CamHelperImx519::GetVBlanking(Duration &exposure,\n+uint32_t CamHelperImx519::getVBlanking(Duration &exposure,\n \t\t\t\t       Duration minFrameDuration,\n \t\t\t\t       Duration maxFrameDuration) const\n {\n \tuint32_t frameLength, exposureLines;\n \tunsigned int shift = 0;\n \n-\tframeLength = mode_.height + CamHelper::GetVBlanking(exposure, minFrameDuration,\n+\tframeLength = mode_.height + CamHelper::getVBlanking(exposure, minFrameDuration,\n \t\t\t\t\t\t\t     maxFrameDuration);\n \t/*\n \t * Check if the frame length calculated needs to be setup for long\n@@ -144,42 +144,42 @@ uint32_t CamHelperImx519::GetVBlanking(Duration &exposure,\n \tif (shift) {\n \t\t/* Account for any rounding in the scaled frame length value. */\n \t\tframeLength <<= shift;\n-\t\texposureLines = ExposureLines(exposure);\n+\t\texposureLines = CamHelperImx519::exposureLines(exposure);\n \t\texposureLines = std::min(exposureLines, frameLength - frameIntegrationDiff);\n-\t\texposure = Exposure(exposureLines);\n+\t\texposure = CamHelperImx519::exposure(exposureLines);\n \t}\n \n \treturn frameLength - mode_.height;\n }\n \n-void CamHelperImx519::GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t\tint &vblank_delay) const\n+void CamHelperImx519::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay) const\n {\n-\texposure_delay = 2;\n-\tgain_delay = 2;\n-\tvblank_delay = 3;\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 3;\n }\n \n-bool CamHelperImx519::SensorEmbeddedDataPresent() const\n+bool CamHelperImx519::sensorEmbeddedDataPresent() const\n {\n \treturn true;\n }\n \n-void CamHelperImx519::PopulateMetadata(const MdParser::RegisterMap &registers,\n+void CamHelperImx519::populateMetadata(const MdParser::RegisterMap &registers,\n \t\t\t\t       Metadata &metadata) const\n {\n \tDeviceStatus deviceStatus;\n \n-\tdeviceStatus.shutter_speed = Exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg));\n-\tdeviceStatus.analogue_gain = Gain(registers.at(gainHiReg) * 256 + registers.at(gainLoReg));\n-\tdeviceStatus.frame_length = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg);\n+\tdeviceStatus.shutterSpeed = exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg));\n+\tdeviceStatus.analogueGain = gain(registers.at(gainHiReg) * 256 + registers.at(gainLoReg));\n+\tdeviceStatus.frameLength = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg);\n \n-\tmetadata.Set(\"device.status\", deviceStatus);\n+\tmetadata.set(\"device.status\", deviceStatus);\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperImx519();\n }\n \n-static RegisterCamHelper reg(\"imx519\", &Create);\n+static RegisterCamHelper reg(\"imx519\", &create);\ndiff --git a/src/ipa/raspberrypi/cam_helper_ov5647.cpp b/src/ipa/raspberrypi/cam_helper_ov5647.cpp\nindex 702c2d07f73a..9dc3fc44e5e8 100644\n--- a/src/ipa/raspberrypi/cam_helper_ov5647.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_ov5647.cpp\n@@ -15,14 +15,14 @@ class CamHelperOv5647 : public CamHelper\n {\n public:\n \tCamHelperOv5647();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tvoid GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t       int &vblank_delay) const override;\n-\tunsigned int HideFramesStartup() const override;\n-\tunsigned int HideFramesModeSwitch() const override;\n-\tunsigned int MistrustFramesStartup() const override;\n-\tunsigned int MistrustFramesModeSwitch() const override;\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t       int &vblankDelay) const override;\n+\tunsigned int hideFramesStartup() const override;\n+\tunsigned int hideFramesModeSwitch() const override;\n+\tunsigned int mistrustFramesStartup() const override;\n+\tunsigned int mistrustFramesModeSwitch() const override;\n \n private:\n \t/*\n@@ -42,29 +42,29 @@ CamHelperOv5647::CamHelperOv5647()\n {\n }\n \n-uint32_t CamHelperOv5647::GainCode(double gain) const\n+uint32_t CamHelperOv5647::gainCode(double gain) const\n {\n \treturn static_cast<uint32_t>(gain * 16.0);\n }\n \n-double CamHelperOv5647::Gain(uint32_t gain_code) const\n+double CamHelperOv5647::gain(uint32_t gainCode) const\n {\n-\treturn static_cast<double>(gain_code) / 16.0;\n+\treturn static_cast<double>(gainCode) / 16.0;\n }\n \n-void CamHelperOv5647::GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t\tint &vblank_delay) const\n+void CamHelperOv5647::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay) const\n {\n \t/*\n \t * We run this sensor in a mode where the gain delay is bumped up to\n \t * 2. It seems to be the only way to make the delays \"predictable\".\n \t */\n-\texposure_delay = 2;\n-\tgain_delay = 2;\n-\tvblank_delay = 2;\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 2;\n }\n \n-unsigned int CamHelperOv5647::HideFramesStartup() const\n+unsigned int CamHelperOv5647::hideFramesStartup() const\n {\n \t/*\n \t * On startup, we get a couple of under-exposed frames which\n@@ -73,7 +73,7 @@ unsigned int CamHelperOv5647::HideFramesStartup() const\n \treturn 2;\n }\n \n-unsigned int CamHelperOv5647::HideFramesModeSwitch() const\n+unsigned int CamHelperOv5647::hideFramesModeSwitch() const\n {\n \t/*\n \t * After a mode switch, we get a couple of under-exposed frames which\n@@ -82,7 +82,7 @@ unsigned int CamHelperOv5647::HideFramesModeSwitch() const\n \treturn 2;\n }\n \n-unsigned int CamHelperOv5647::MistrustFramesStartup() const\n+unsigned int CamHelperOv5647::mistrustFramesStartup() const\n {\n \t/*\n \t * First couple of frames are under-exposed and are no good for control\n@@ -91,7 +91,7 @@ unsigned int CamHelperOv5647::MistrustFramesStartup() const\n \treturn 2;\n }\n \n-unsigned int CamHelperOv5647::MistrustFramesModeSwitch() const\n+unsigned int CamHelperOv5647::mistrustFramesModeSwitch() const\n {\n \t/*\n \t * First couple of frames are under-exposed even after a simple\n@@ -100,9 +100,9 @@ unsigned int CamHelperOv5647::MistrustFramesModeSwitch() const\n \treturn 2;\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperOv5647();\n }\n \n-static RegisterCamHelper reg(\"ov5647\", &Create);\n+static RegisterCamHelper reg(\"ov5647\", &create);\ndiff --git a/src/ipa/raspberrypi/cam_helper_ov9281.cpp b/src/ipa/raspberrypi/cam_helper_ov9281.cpp\nindex 9de868c31dc0..130450afefc7 100644\n--- a/src/ipa/raspberrypi/cam_helper_ov9281.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_ov9281.cpp\n@@ -15,10 +15,10 @@ class CamHelperOv9281 : public CamHelper\n {\n public:\n \tCamHelperOv9281();\n-\tuint32_t GainCode(double gain) const override;\n-\tdouble Gain(uint32_t gain_code) const override;\n-\tvoid GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t       int &vblank_delay) const override;\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t       int &vblankDelay) const override;\n \n private:\n \t/*\n@@ -38,28 +38,28 @@ CamHelperOv9281::CamHelperOv9281()\n {\n }\n \n-uint32_t CamHelperOv9281::GainCode(double gain) const\n+uint32_t CamHelperOv9281::gainCode(double gain) const\n {\n \treturn static_cast<uint32_t>(gain * 16.0);\n }\n \n-double CamHelperOv9281::Gain(uint32_t gain_code) const\n+double CamHelperOv9281::gain(uint32_t gainCode) const\n {\n-\treturn static_cast<double>(gain_code) / 16.0;\n+\treturn static_cast<double>(gainCode) / 16.0;\n }\n \n-void CamHelperOv9281::GetDelays(int &exposure_delay, int &gain_delay,\n-\t\t\t\tint &vblank_delay) const\n+void CamHelperOv9281::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay) const\n {\n \t/* The driver appears to behave as follows: */\n-\texposure_delay = 2;\n-\tgain_delay = 2;\n-\tvblank_delay = 2;\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 2;\n }\n \n-static CamHelper *Create()\n+static CamHelper *create()\n {\n \treturn new CamHelperOv9281();\n }\n \n-static RegisterCamHelper reg(\"ov9281\", &Create);\n+static RegisterCamHelper reg(\"ov9281\", &create);\n",
    "prefixes": [
        "libcamera-devel",
        "02/17"
    ]
}