Patch Detail
Show a patch.
GET /api/patches/16723/?format=api
{ "id": 16723, "url": "https://patchwork.libcamera.org/api/patches/16723/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16723/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220721121310.1286862-12-kieran.bingham@ideasonboard.com>", "date": "2022-07-21T12:13:09", "name": "[libcamera-devel,RFC,11/12] ipa: rkisp1: Transfer queueRequest() call to each algorithm", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6622f99d3763fb368f3d410afe561982b50b7787", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16723/mbox/", "series": [ { "id": 3313, "url": "https://patchwork.libcamera.org/api/series/3313/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3313", "date": "2022-07-21T12:12:58", "name": "libcamera: Align IPU3 and RKISP1 interfaces", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3313/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16723/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16723/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88C8ABD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 12:13:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4528063330;\n\tThu, 21 Jul 2022 14:13:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A350663310\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 14:13:16 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D00212F3;\n\tThu, 21 Jul 2022 14:13:16 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658405607;\n\tbh=Lu3nDaJ8+ZeFIP/DzBydOoTiShcPM5Lm4EsmHyyJxY8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=SmeC9Pbthqvo5WzgmVkBHHbbCkrUJ9npFdA0DGybPdPPRR/h4PzDjTvcWNOOsxnpi\n\tQFCIeSBf4nJZfUbCeSeQlrjLYZ8muOIFbpRic+hRdz0CwOOskv1gz8VdX4QXNbslfK\n\tvjt6zUamrcaGc1qXGBiMLNptnnTF/OdU/FoMu+YUTQGBQr/s7W9dWFg+yp9NaYb9JV\n\t4bWfD3QXxKpGgRkhFPV/dJGLmVAEpXlAMMX7nG4VtuPvVRR3omJMfcnv9LilktLrFq\n\ttcVm4rIhghlvTyPQ2rE/5cFOrJujv14bGNNZQ4ewcLrnvrxR1o4KNP6Woa51b1/gds\n\t8pmjatAZlcJ7Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658405596;\n\tbh=Lu3nDaJ8+ZeFIP/DzBydOoTiShcPM5Lm4EsmHyyJxY8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HWGDYRNDVcTTlC9gbKujSlhsMT3GWA2BixNA6ZvGg5BTVrJfsLLYPuMPNRKcNQ24Y\n\t5HCxJKkSJRCpy8m0yurW0D6feHWQf5K7KIqODMY4BiIugvwVsPHrocTHu6mc+kKfun\n\t2UFmO2Sgm4XViqKpli1Ox6sVmF7lSLodipMiB8vw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HWGDYRND\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 21 Jul 2022 13:13:09 +0100", "Message-Id": "<20220721121310.1286862-12-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "References": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 11/12] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Florian Sylvestre <fsylvestre@baylibre.com>\n\nImplement rkisp1 queueRequest() function to update each algorithm with user\ncontrols.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv2: (Kieran)\n\n - Provide frame, and frame context to the algorithms.\n - Use RKISP1FrameContext type now\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex b468e08a67fa..c2bd5ef36c1b 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -267,10 +267,13 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)\n \t}\n }\n \n-void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,\n-\t\t\t [[maybe_unused]] const ControlList &controls)\n+void IPARkISP1::queueRequest(const uint32_t frame,\n+\t\t\t const ControlList &controls)\n {\n-\t/* \\todo Start processing for 'frame' based on 'controls'. */\n+\tRKISP1FrameContext &frameContext = context_.frameContexts.initialise(frame);\n+\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->queueRequest(context_, frame, frameContext, controls);\n }\n \n void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n", "prefixes": [ "libcamera-devel", "RFC", "11/12" ] }