Patch Detail
Show a patch.
GET /api/patches/16722/?format=api
{ "id": 16722, "url": "https://patchwork.libcamera.org/api/patches/16722/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16722/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220721121310.1286862-11-kieran.bingham@ideasonboard.com>", "date": "2022-07-21T12:13:08", "name": "[libcamera-devel,RFC,10/12] ipa: libipa: algorithm: Add queueRequest() to the Algorithm class", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2c33e2ef24082c2fce3952b55730886bcff9a1a5", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16722/mbox/", "series": [ { "id": 3313, "url": "https://patchwork.libcamera.org/api/series/3313/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3313", "date": "2022-07-21T12:12:58", "name": "libcamera: Align IPU3 and RKISP1 interfaces", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3313/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16722/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16722/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A7EDC3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 12:13:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B234863317;\n\tThu, 21 Jul 2022 14:13:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 413376331D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 14:13:16 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC1AD9B1;\n\tThu, 21 Jul 2022 14:13:15 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658405606;\n\tbh=Qyt/OUdZg+2y+xNvn48MTOqODy1zqpfhIIuhwHcTC60=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=th3Unazmo73kOsp6oyehcPti4RL4PLzuZtjS170F8Sp7upBLGJzsZYahwmcYOsDRY\n\tT7kxCncdOND4TV09wE+YidLiz0wvpYHRBfL+I31UmkkwBpnW+q5nnO9HN/vdyWx4fZ\n\tqbbsckcJwNkejetHrwIAHr+JozPg8rznP4BSBGwJXvFUIEneSbrqB0FIh5eVoERPZN\n\tG1/Zl+u7bwXvVQTYeC+9sjGH93EhV9AJNgIanEmO5zfOdlhqWIrS8xx2rYf3Q3O1st\n\t+1QLKgeZVxrY+q9E2cbYl1t3YyQZS832Ss8WRp+Ib4Qx1dxjNNttqIWWVfVH1jHomG\n\t+nWcYXaLFqwdg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658405596;\n\tbh=Qyt/OUdZg+2y+xNvn48MTOqODy1zqpfhIIuhwHcTC60=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=khQQI69S10Qirrtntq0n81HM2LSw2yiL9ERvzNu0nzQ7zDcaCMijBc0RisRuUukZH\n\t2TLEyK7mKjGXcce7nbUCPqT6rz65R7UzRpwd56hmd5WwRpiBTfFCcQWUvDxIX3ZKH+\n\tqhfg006bl5vBmO6BRdysb/1P1jXplPL9gOUkEXyY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"khQQI69S\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 21 Jul 2022 13:13:08 +0100", "Message-Id": "<20220721121310.1286862-11-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "References": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 10/12] ipa: libipa: algorithm: Add\n\tqueueRequest() to the Algorithm class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Florian Sylvestre <fsylvestre@baylibre.com>\n\nAdd queueRequest() function to the Algorithm class. The queueRequest() function\nprovides controls values coming from the application to each algorithm.\nEach algorithm is responsible for retrieving the controls associated to them.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv2: (Kieran)\n\n - Adjust function ordering\n - Add FrameContext to queueRequest\n - Removed Module::ControlList and using libcamera::ControlList\n directly\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/algorithm.cpp | 17 +++++++++++++++++\n src/ipa/libipa/algorithm.h | 9 +++++++++\n 2 files changed, 26 insertions(+)", "diff": "diff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nindex 65e9e8a56fc4..020b0b57b632 100644\n--- a/src/ipa/libipa/algorithm.cpp\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -83,6 +83,23 @@ namespace ipa {\n * includes setting fields and flags that enable those processing blocks.\n */\n \n+/**\n+ * \\fn Algorithm::queueRequest()\n+ * \\brief Provide control values to the algorithm\n+ * \\param[in] context The shared IPA context\n+ * \\param[in] frame The frame context sequence number\n+ * \\param[in] frameContext The current frame's context\n+ * \\param[in] controls The list of user controls\n+ *\n+ * This function is called for each request queued to the camera. It provides\n+ * the controls stored in the request to the algorithm. The \\a frame number\n+ * is the Request sequence number and identifies the desired corresponding\n+ * frame to target for the controls to take effect.\n+ *\n+ * Algorithms shall read the applicable controls and store their value for later\n+ * use during frame processing.\n+ */\n+\n /**\n * \\fn Algorithm::process()\n * \\brief Process ISP statistics, and run algorithm operations\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nindex 1d2544a767eb..5ccc640955c4 100644\n--- a/src/ipa/libipa/algorithm.h\n+++ b/src/ipa/libipa/algorithm.h\n@@ -11,6 +11,7 @@\n \n namespace libcamera {\n \n+class ControlList;\n class YamlObject;\n \n namespace ipa {\n@@ -35,6 +36,14 @@ public:\n \t\treturn 0;\n \t}\n \n+\n+\tvirtual void queueRequest([[maybe_unused]] typename Module::Context &context,\n+\t\t\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t\t\t [[maybe_unused]] typename Module::FrameContext &frameContext,\n+\t\t\t\t [[maybe_unused]] const ControlList &controls)\n+\t{\n+\t}\n+\n \tvirtual void prepare([[maybe_unused]] typename Module::Context &context,\n \t\t\t [[maybe_unused]] unsigned int frame,\n \t\t\t [[maybe_unused]] typename Module::FrameContext &frameContext,\n", "prefixes": [ "libcamera-devel", "RFC", "10/12" ] }