Patch Detail
Show a patch.
GET /api/patches/16715/?format=api
{ "id": 16715, "url": "https://patchwork.libcamera.org/api/patches/16715/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16715/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220721121310.1286862-4-kieran.bingham@ideasonboard.com>", "date": "2022-07-21T12:13:01", "name": "[libcamera-devel,RFC,03/12] libcamera: request: Add PFCError flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b305cd48df3b5caaad169f85850e320cbfbf24d3", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16715/mbox/", "series": [ { "id": 3313, "url": "https://patchwork.libcamera.org/api/series/3313/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3313", "date": "2022-07-21T12:12:58", "name": "libcamera: Align IPU3 and RKISP1 interfaces", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3313/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16715/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16715/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3D5FBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 12:13:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65BAB63322;\n\tThu, 21 Jul 2022 14:13:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56F2D6330F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 14:13:14 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0683A825;\n\tThu, 21 Jul 2022 14:13:13 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658405600;\n\tbh=ixIcOvCneuW7zcPdTSGPoMyws/19Hw9cd4rAQBHTbD8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=b9IBjbUAmRa9ZZ8VvH6MdJ4ZXtcPamD1HOkiHUPxGd+h6Gx1ihHCXsKQM2vkZOCOw\n\t2OeBt7gnh0xjZ9rER9VTzaz7/fuyJp1YT1Wkp0YbMsJAR7BI5odTXATxwfsDzx2Qd5\n\tWDuToG0PkHJqjDd2CVWihjVWi/dv0lNhHmwuQz+WzRCL7Y/An9BWqtX5IR1dske+MO\n\tBtKhZPH3Td0f16zUCYRX0SZhmx7xxw97fdpkDi66zNjmr3LY/PaY9vwm3AmxRGVaSW\n\tdvKXyAosIU66Qr9h7G6IrKd5/Wi+yJaHaEk1TWJRgusZRWMzT8/VaoWrgpVQ4CMfo0\n\tlMQ5xexoUdl9g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658405594;\n\tbh=ixIcOvCneuW7zcPdTSGPoMyws/19Hw9cd4rAQBHTbD8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WjvbgqFeVLtpMlyECEZX6GgBwpnK1Ql00aQtC8mJEV9hHpwEC6QrXAtzd5lzCyGD9\n\ttMXobYIysz8okWaQBTacyUEDNBtUrr6pLma1IgSF9b8FW9uVcbs1qvv+aNjtUcPPhv\n\tbmgCpI0IubtFRN/L9hiVo+DllxFz12WgxmkXdC34=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WjvbgqFe\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 21 Jul 2022 13:13:01 +0100", "Message-Id": "<20220721121310.1286862-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "References": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 03/12] libcamera: request: Add\n\tPFCError flag", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a new flag for the Request error state to indicate that a\nper-frame control error has occurred. One or more controls set for this\nrequest could not be guaranteed on this frame.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/request.h | 1 +\n src/libcamera/request.cpp | 5 +++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 992629e11aa4..d6d9f0d214dc 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -47,6 +47,7 @@ public:\n \tenum ErrorFlag {\n \t\tNoError = 0,\n \t\tControlError = (1 << 0),\n+\t\tPFCError = (1 << 1),\n \t};\n \n \tusing ErrorFlags = Flags<ErrorFlag>;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 8b82757ea7e3..509ed4ca6ed5 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -339,10 +339,15 @@ void Request::Private::timeout()\n * Flags to report non-fatal errors\n * \\var Request::NoError\n * No error\n+ *\n * \\var Request::ControlError\n * Control Error. At least on control was not able to be applied to the device.\n * The application should compare the metadata to the requested control values\n * to check which controls weren't applied.\n+ *\n+ * \\var Request::PFCError\n+ * A per-frame-control error has occured. Controls that were expected to be set\n+ * during the processing of this request were not processed in time.\n */\n \n /**\n", "prefixes": [ "libcamera-devel", "RFC", "03/12" ] }