Patch Detail
Show a patch.
GET /api/patches/16703/?format=api
{ "id": 16703, "url": "https://patchwork.libcamera.org/api/patches/16703/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16703/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220720130348.1337-3-laurent.pinchart@ideasonboard.com>", "date": "2022-07-20T13:03:48", "name": "[libcamera-devel,v5,2/2] cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()", "commit_ref": "f6d6181d3c91efa526b5027319331db9ac75f65b", "pull_url": null, "state": "accepted", "archived": false, "hash": "a6d79793fad7ef79c78d3b0d0b3a762c28150a0e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16703/mbox/", "series": [ { "id": 3308, "url": "https://patchwork.libcamera.org/api/series/3308/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3308", "date": "2022-07-20T13:03:46", "name": "cam: Replace dependency on SDL2_image with libjpeg", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3308/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16703/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16703/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13310BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Jul 2022 13:04:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA71C63318;\n\tWed, 20 Jul 2022 15:04:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34BD060489\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Jul 2022 15:04:27 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD450D02;\n\tWed, 20 Jul 2022 15:04:26 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658322271;\n\tbh=dZwyTDWTzsRQ1vjmq/2l08kflkIlUmxOA188SbNDlRY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nMGzQ1+xZlGPA/9548eN5Y4pfaYrqSdStHq1qInpz5VW9CojQUlAue0RbQX1eyJsK\n\t0bCoQeSV/kdC4+YZnAsYtoJiJiD/Y/xgM1YtrbvoN6MRdLU7dDcfhGk5pP1J3+axU2\n\tG23B0YEL+QUBY+xjTU5037NRwtz/UmflN0n2q6NNklvhCWLovWms/VvMRDkrdUrLK1\n\t5HHKVIuvvic2BVs2cq1j7x3/As1sqM52vp92ej+/7ktNEndera/G6L3QBj5kM9jjC6\n\tYa/w4A3z4aKckOMx2PaT2/JOjtC4Uw0sxcVCuu3CibAJOj+tCTb9eKFtUaeu/ayRsb\n\tdDh8YXKasgl3A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658322267;\n\tbh=dZwyTDWTzsRQ1vjmq/2l08kflkIlUmxOA188SbNDlRY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Rnr5FBNA+GQz8nz68jValTMRErQNEWlB1EYmdlWSDm5RYz/+LEYxmyCYA185iteGn\n\tw0rJ/76rTm6FWRbFhyS1LXa/ws+iIyPOOHG52GE0UdzNqXyC3skwDhd6QXHAuhrSFy\n\tBoeO6Nlo7DOLD0mreJXEOE5tLUhOdGoavMWHNOJA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Rnr5FBNA\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Jul 2022 16:03:48 +0300", "Message-Id": "<20220720130348.1337-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>", "References": "<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 2/2] cam: sdl_sink: Pass a Span<const\n\tuint8_t> to SDLTexture::update()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The SDLTexture::update() function isn't meant to modify the data it\nreceives. Make the Span type const to ensure this at compile time. While\nat it, pass the Span by value instead of reference, as a Span is only a\npointer and size, which will fit in registers and will avoid pointer\ndereferences in the callee.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/sdl_texture.h | 2 +-\n src/cam/sdl_texture_mjpg.cpp | 4 ++--\n src/cam/sdl_texture_mjpg.h | 4 ++--\n src/cam/sdl_texture_yuyv.cpp | 2 +-\n src/cam/sdl_texture_yuyv.h | 2 +-\n 5 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\nindex 1d8b09288d50..f523fa5ebf51 100644\n--- a/src/cam/sdl_texture.h\n+++ b/src/cam/sdl_texture.h\n@@ -17,7 +17,7 @@ public:\n \tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat, const int pitch);\n \tvirtual ~SDLTexture();\n \tint create(SDL_Renderer *renderer);\n-\tvirtual void update(const libcamera::Span<uint8_t> &data) = 0;\n+\tvirtual void update(libcamera::Span<const uint8_t> data) = 0;\n \tSDL_Texture *get() const { return ptr_; }\n \n protected:\ndiff --git a/src/cam/sdl_texture_mjpg.cpp b/src/cam/sdl_texture_mjpg.cpp\nindex 7eddc00cd210..7542efd75d96 100644\n--- a/src/cam/sdl_texture_mjpg.cpp\n+++ b/src/cam/sdl_texture_mjpg.cpp\n@@ -43,7 +43,7 @@ SDLTextureMJPG::SDLTextureMJPG(const SDL_Rect &rect)\n {\n }\n \n-int SDLTextureMJPG::decompress(const Span<uint8_t> &data)\n+int SDLTextureMJPG::decompress(Span<const uint8_t> data)\n {\n \tstruct jpeg_decompress_struct cinfo;\n \n@@ -76,7 +76,7 @@ int SDLTextureMJPG::decompress(const Span<uint8_t> &data)\n \treturn 0;\n }\n \n-void SDLTextureMJPG::update(const Span<uint8_t> &data)\n+void SDLTextureMJPG::update(Span<const uint8_t> data)\n {\n \tdecompress(data);\n \tSDL_UpdateTexture(ptr_, nullptr, rgb_.get(), pitch_);\ndiff --git a/src/cam/sdl_texture_mjpg.h b/src/cam/sdl_texture_mjpg.h\nindex 328c45a913c5..5141ed73bf70 100644\n--- a/src/cam/sdl_texture_mjpg.h\n+++ b/src/cam/sdl_texture_mjpg.h\n@@ -14,10 +14,10 @@ class SDLTextureMJPG : public SDLTexture\n public:\n \tSDLTextureMJPG(const SDL_Rect &rect);\n \n-\tvoid update(const libcamera::Span<uint8_t> &data) override;\n+\tvoid update(libcamera::Span<const uint8_t> data) override;\n \n private:\n-\tint decompress(const libcamera::Span<uint8_t> &data);\n+\tint decompress(libcamera::Span<const uint8_t> data);\n \n \tstd::unique_ptr<unsigned char[]> rgb_;\n };\ndiff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuyv.cpp\nindex cc161b2cfa79..637c0900edff 100644\n--- a/src/cam/sdl_texture_yuyv.cpp\n+++ b/src/cam/sdl_texture_yuyv.cpp\n@@ -14,7 +14,7 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect)\n {\n }\n \n-void SDLTextureYUYV::update(const Span<uint8_t> &data)\n+void SDLTextureYUYV::update(Span<const uint8_t> data)\n {\n \tSDL_UpdateTexture(ptr_, &rect_, data.data(), pitch_);\n }\ndiff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuyv.h\nindex 9f7c72f09db2..529a72d6a40e 100644\n--- a/src/cam/sdl_texture_yuyv.h\n+++ b/src/cam/sdl_texture_yuyv.h\n@@ -13,5 +13,5 @@ class SDLTextureYUYV : public SDLTexture\n {\n public:\n \tSDLTextureYUYV(const SDL_Rect &rect);\n-\tvoid update(const libcamera::Span<uint8_t> &data) override;\n+\tvoid update(libcamera::Span<const uint8_t> data) override;\n };\n", "prefixes": [ "libcamera-devel", "v5", "2/2" ] }