Patch Detail
Show a patch.
GET /api/patches/16694/?format=api
{ "id": 16694, "url": "https://patchwork.libcamera.org/api/patches/16694/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16694/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220719210258.5602-2-laurent.pinchart@ideasonboard.com>", "date": "2022-07-19T21:02:58", "name": "[libcamera-devel,2/2] licamera: controls: Update ControlList::get() documentation", "commit_ref": "38136f9e11d1e1af3880bc3382e97e5a7250568d", "pull_url": null, "state": "accepted", "archived": false, "hash": "298f727bf5d9659b6ff958409ec8888377690306", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16694/mbox/", "series": [ { "id": 3304, "url": "https://patchwork.libcamera.org/api/series/3304/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3304", "date": "2022-07-19T21:02:57", "name": "[libcamera-devel,1/2] licamera: controls: Drop unnecessary template qualifiers in documentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3304/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16694/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16694/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85533C3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jul 2022 21:03:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DBA963312;\n\tTue, 19 Jul 2022 23:03:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 945AE603F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jul 2022 23:03:35 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24C66896;\n\tTue, 19 Jul 2022 23:03:35 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658264617;\n\tbh=u5SY/OnBxRRhzFtdPPAPoIOJg06p67BHMAmDkreXsfQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DIwTsF8SBTNqjJ6WfH2wCT8CuogxbxOXRBE6FjcivXXZ9DAJCYh4Brh+4A6MuJIqt\n\tqwvhC0yhI7p9hQlaQ4w0/Wb0wZ9anPN+G7eb6Eqnu93vEhwpPKCUVlooOYzrWYLbFr\n\t2VUCUe6W72ydfTB/COkd8V0bKeymEa7GL4w5SLQp+lCDiG2yOl0u7ZgRrRncp5vyd0\n\tMsNAbcYCu1ottDxpooRPl1f9AujCpMRA8mduelM1eoS2bnEVM+Rec64YVNq7Rq4mTL\n\t5jLTQfM1gmBKB3MpY92W9ZvyvhBVZWFYwEsefwV4IwfHWibgbd0IN2bRSYCYOAPY7N\n\tbrxo9cnSX/pOg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658264615;\n\tbh=u5SY/OnBxRRhzFtdPPAPoIOJg06p67BHMAmDkreXsfQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZHEQ6F64xjqssLQUn6cd6FhJBuzgIG/u+fhgK+qZDHsWL641feyJALa4M6zZ/Vp8V\n\tbOBeG3w860iHv0z98jEvbI0yQ3HOqtSsZ+vhhbYT5qOcPEUBDYHXFRJaLoft7hvc4B\n\t4AU0BcWoCouMF5ucl1d76zVXGB840r4tSJWZwPLM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZHEQ6F64\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Jul 2022 00:02:58 +0300", "Message-Id": "<20220719210258.5602-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220719210258.5602-1-laurent.pinchart@ideasonboard.com>", "References": "<20220719210258.5602-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] licamera: controls: Update\n\tControlList::get() documentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ControlList::get(const Control<T> &ctrl) function has been modified\nin commit 1c4d48018505 (\"libcamera: controls: Use std::optional to\nhandle invalid control values\") to return an std::optional<>, but its\ndocumentation wasn't updated. Fix it.\n\nFixes: 1c4d48018505 (\"libcamera: controls: Use std::optional to handle invalid control values\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/controls.cpp | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 3fd535f204b2..20c27e65e725 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -958,14 +958,8 @@ bool ControlList::contains(unsigned int id) const\n * \\brief Get the value of control \\a ctrl\n * \\param[in] ctrl The control\n *\n- * The behaviour is undefined if the control \\a ctrl is not present in the\n- * list. Use ControlList::contains() to test for the presence of a control in\n- * the list before retrieving its value.\n- *\n- * The control value type shall match the type T, otherwise the behaviour is\n- * undefined.\n- *\n- * \\return The control value\n+ * \\return A std::optional<T> containing the control value, or std::nullopt if\n+ * the control \\a ctrl is not present in the list\n */\n \n /**\n", "prefixes": [ "libcamera-devel", "2/2" ] }