Patch Detail
Show a patch.
GET /api/patches/1669/?format=api
{ "id": 1669, "url": "https://patchwork.libcamera.org/api/patches/1669/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1669/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190712082909.3811-1-paul.elder@ideasonboard.com>", "date": "2019-07-12T08:29:08", "name": "[libcamera-devel,1/2] libcamera: process: fix compilation on Chromium OS", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4eeca7cf031edf935f6466e38ab27b000945b359", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1669/mbox/", "series": [ { "id": 422, "url": "https://patchwork.libcamera.org/api/series/422/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=422", "date": "2019-07-12T08:29:08", "name": "[libcamera-devel,1/2] libcamera: process: fix compilation on Chromium OS", "version": 1, "mbox": "https://patchwork.libcamera.org/series/422/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1669/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1669/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5CB760E40\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jul 2019 10:29:21 +0200 (CEST)", "from neptunite.amanokami.net (softbank126209254147.bbtec.net\n\t[126.209.254.147])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6B102B2;\n\tFri, 12 Jul 2019 10:29:16 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562920158;\n\tbh=ZO6MdzW7MdK1g2j91y70WinJ6ciA+Fkk4kC3JirdAHY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=I4+1nPkCCBpwLknVL3d6jnLQRkgqBbyOFuqXQPwgeETqCjk/IfXZwF+hiJ1cqXXDB\n\tIvPC8t8EWu+weqE16O58erEFd4qu6NgL3n46NBswArIrb6w+10NnYDD0+H5aNqot4j\n\to4+EJVAQLEqcUuAcPN6omtslRmuwvCLTmf8ir7xk=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Jul 2019 17:29:08 +0900", "Message-Id": "<20190712082909.3811-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] libcamera: process: fix compilation\n\ton Chromium OS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 12 Jul 2019 08:29:22 -0000" }, "content": "Commit 3d20beca6616 (\"libcamera: Add Process and ProcessManager\nclasses\") causes the build to fail in the Chromium OS build environment,\nbecause the return values of some system calls are ignored. Fix this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/process.cpp | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 9d8829d..eccf1dd 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -69,7 +69,9 @@ namespace {\n void sigact(int signal, siginfo_t *info, void *ucontext)\n {\n \tchar data = 0;\n-\twrite(ProcessManager::instance()->writePipe(), &data, sizeof(data));\n+\t/* We're in a signal handler so we can't log any message,\n+\t * and we need to continue anyway. */\n+\t(void)write(ProcessManager::instance()->writePipe(), &data, sizeof(data));\n \n \tconst struct sigaction &oldsa = ProcessManager::instance()->oldsa();\n \tif (oldsa.sa_flags & SA_SIGINFO) {\n@@ -85,7 +87,11 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n void ProcessManager::sighandler(EventNotifier *notifier)\n {\n \tchar data;\n-\tread(pipe_[0], &data, sizeof(data));\n+\tif (read(pipe_[0], &data, sizeof(data))) {\n+\t\tLOG(Process, Error)\n+\t\t\t<< \"failed to read byte from direct signal handler\";\n+\t\treturn;\n+\t}\n \n \tfor (auto it = processes_.begin(); it != processes_.end(); ) {\n \t\tProcess *process = *it;\n@@ -128,7 +134,9 @@ ProcessManager::ProcessManager()\n \n \tsigaction(SIGCHLD, &sa, NULL);\n \n-\tpipe2(pipe_, O_CLOEXEC | O_DIRECT | O_NONBLOCK);\n+\tif (pipe2(pipe_, O_CLOEXEC | O_DIRECT | O_NONBLOCK))\n+\t\tLOG(Process, Fatal)\n+\t\t\t<< \"Failed to initialize pipe for signal handling\";\n \tsigEvent_ = new EventNotifier(pipe_[0], EventNotifier::Read);\n \tsigEvent_->activated.connect(this, &ProcessManager::sighandler);\n }\n", "prefixes": [ "libcamera-devel", "1/2" ] }