Patch Detail
Show a patch.
GET /api/patches/16670/?format=api
{ "id": 16670, "url": "https://patchwork.libcamera.org/api/patches/16670/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16670/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220718081602.32535-4-naush@raspberrypi.com>", "date": "2022-07-18T08:15:57", "name": "[libcamera-devel,v6,3/8] ipa: raspberrypi: Replace tabs with spaces in tuning data files", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e5ea42059c8f912924c244a2825de92aad5d9d91", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16670/mbox/", "series": [ { "id": 3293, "url": "https://patchwork.libcamera.org/api/series/3293/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3293", "date": "2022-07-18T08:15:54", "name": "Replace boost JSON parser with libyaml in Raspberry Pi IPA", "version": 6, "mbox": "https://patchwork.libcamera.org/series/3293/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16670/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16670/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71930BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Jul 2022 08:16:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 170596331E;\n\tMon, 18 Jul 2022 10:16:12 +0200 (CEST)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C390063315\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Jul 2022 10:16:08 +0200 (CEST)", "by mail-wm1-x32e.google.com with SMTP id a11so518513wmq.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Jul 2022 01:16:08 -0700 (PDT)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ta15-20020adffb8f000000b0021dbac444a7sm10206795wrr.59.2022.07.18.01.16.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Jul 2022 01:16:07 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658132172;\n\tbh=0VsX8zS1TV4woGZ66Yu7QUH0/Sz2R0YuZN0OvQ6ZI7U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Dycn3IdMtnHCazE+ljwr1xmTdpMXuCsLnfWkJ2ACgKR9yXlBaCwSMerzzSbUKMtb4\n\tCu+bIK2AFk4ZrZhieuw011sxTrTBrSWrZDLqUKCQSAHI1HnpAQr37IRVFYbTrmpC0S\n\tgw6pQdvCx0D6hUvZHFXDloOTo1BY1c/4V+pSeF8Zak3rDtOlvnCLm+NR9sWTMCOL89\n\tUjqI4tr1lut6VaPzOeEQ0INlFmVT/6iqQRjLKKd5kdHOUHpUTdEOZNQWsnObIWWv33\n\tUdO4IOlCP5FoHnnEyebQhmK417I7DRHtaTfyyaeUGzjE4iZfZHLNa7Iw2kvvSMtxlO\n\t5e4x9hVcKw89w==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XCiwtG7VvuAf9YF+a6FSlaeIMH3IKq7Wra9RxO0LF7g=;\n\tb=kwt58aFFzApL5e+oXexO9GcsjZNcirQN0IQrjYFo0Dscm+ICLplUIb3E8GTQoRIGnr\n\t3vBkjkXdqoRPTXkuuYG8HwqKEkoMSH5mHGfoMuuUR2cXMsHnW2srIvm0X+Vuzt+pgigS\n\tKtwJCf9Kan1H3geWr5bywgapdM9SgZByzNtd0QkugeWjJgxbyTh1csvJJZ1/JvUzSz3y\n\tTRYf/jKwXuMYcHIZkMzYHZCaBNABUMH2e+EgSWE4PQMKCFzakxPyXkCqsPxtBG08VqJz\n\tlhxWgMXThnvDB7EfQ5DaFewYBcwveilcx5GLXS/CkCf0r0XutBj3OlAyA6TppfeaYYaf\n\t+VZg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"kwt58aFF\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XCiwtG7VvuAf9YF+a6FSlaeIMH3IKq7Wra9RxO0LF7g=;\n\tb=l+wvcZRQRWe8UD/Z/k04l1LMgoVHDFvwMwYknW3uS4j+yKDyb6JkZCiWLRp+bB8jtI\n\tfx304pCVJzavRwKGLQE/ioESXZ9atPhBwAIE/upbK/ey8eO4vu2qOiTWPc/q19oR+9A6\n\tzdMQHIQAjxSXZX2OhQughvHMaIMdqz0ikP+wPj65ob4Z06aDh3+OSel9NBfcJr+9wYRJ\n\tsv94/XYvGomKEal4fhkJB/UX0KA/bIaNVkuqmPgP8Q6Ya8PiknMnhVVBpsrQBzn6VUQ/\n\tMIhq6/stZPI+WtTn4aiL4T8VayEPJpO5+Rj96K7hI/HstWbhYiiMcztKa9xuI3mBevxn\n\t16xw==", "X-Gm-Message-State": "AJIora8DrBZaw8YvlFXW1yJbDaAAB/0/jw3UhAjvsPZ3k4yQZ8mM+yVI\n\tHmRaK40qMcqU3tkFLHOBW5MNPsxmN5Gy/g==", "X-Google-Smtp-Source": "AGRyM1vYMaPeik3Xw+QELmc8Bx23xZwKSeosrrO+TE4DYDURe2XZKLiFlnE5woAM4s+4poCUPY+KQg==", "X-Received": "by 2002:a05:600c:3b91:b0:3a3:1cbe:d531 with SMTP id\n\tn17-20020a05600c3b9100b003a31cbed531mr2155491wms.159.1658132168093; \n\tMon, 18 Jul 2022 01:16:08 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 18 Jul 2022 09:15:57 +0100", "Message-Id": "<20220718081602.32535-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220718081602.32535-1-naush@raspberrypi.com>", "References": "<20220718081602.32535-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 3/8] ipa: raspberrypi: Replace tabs\n\twith spaces in tuning data files", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nTuning data files mostly use spaces for indentation, with occasional\nstray tabs. Use spaces consistently. This allows parsing the tuning\nfiles with libyaml, preparing to replace the dependency on boost.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nTested-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 8 ++++----\n src/ipa/raspberrypi/data/imx219_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/imx290.json | 18 +++++++++---------\n src/ipa/raspberrypi/data/imx477.json | 8 ++++----\n src/ipa/raspberrypi/data/imx477_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647_noir.json | 12 ++++++------\n src/ipa/raspberrypi/data/se327m12.json | 6 +++---\n 8 files changed, 41 insertions(+), 41 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex de59d9363be4..4e24c5d57da1 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/raspberrypi/data/imx219_noir.json\nindex 9a3f03ec86f4..1835ec3df63b 100644\n--- a/src/ipa/raspberrypi/data/imx219_noir.json\n+++ b/src/ipa/raspberrypi/data/imx219_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/raspberrypi/data/imx290.json\nindex 20b45c1684c2..1363bab71340 100644\n--- a/src/ipa/raspberrypi/data/imx290.json\n+++ b/src/ipa/raspberrypi/data/imx290.json\n@@ -29,11 +29,11 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n-\t\"speed\": 0.2,\n+ \"speed\": 0.2,\n \"metering_modes\":\n {\n \"matrix\":\n@@ -150,14 +150,14 @@\n \"rpi.ccm\":\n {\n \"ccms\":\n-\t[\n+ [\n {\n-\t\t\"ct\": 3900, \"ccm\":\n-\t\t[\n-\t\t 1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n-\t\t]\n-\t }\n-\t]\n+ \"ct\": 3900, \"ccm\":\n+ [\n+ 1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n+ ]\n+ }\n+ ]\n },\n \"rpi.focus\":\n {\ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex d07febd283ed..0f389661c246 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/raspberrypi/data/imx477_noir.json\nindex 7d4fc7dab9fd..a379d780d966 100644\n--- a/src/ipa/raspberrypi/data/imx477_noir.json\n+++ b/src/ipa/raspberrypi/data/imx477_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\nindex 24bc06fb6114..e65f9385d970 100644\n--- a/src/ipa/raspberrypi/data/ov5647.json\n+++ b/src/ipa/raspberrypi/data/ov5647.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\n@@ -203,7 +203,7 @@\n [\n 0, 0.16, 1000, 0.165, 10000, 0.17\n ],\n-\t\"base_ev\": 1.25\n+ \"base_ev\": 1.25\n },\n \"rpi.alsc\":\n {\ndiff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/raspberrypi/data/ov5647_noir.json\nindex 1c628ed13f19..dad73a5e8cd9 100644\n--- a/src/ipa/raspberrypi/data/ov5647_noir.json\n+++ b/src/ipa/raspberrypi/data/ov5647_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\n@@ -135,7 +135,7 @@\n [\n 0, 0.16, 1000, 0.165, 10000, 0.17\n ],\n-\t\"base_ev\": 1.25\n+ \"base_ev\": 1.25\n },\n \"rpi.alsc\":\n {\ndiff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/raspberrypi/data/se327m12.json\nindex 94af2239f700..5b1ac2ce3bf8 100644\n--- a/src/ipa/raspberrypi/data/se327m12.json\n+++ b/src/ipa/raspberrypi/data/se327m12.json\n@@ -334,8 +334,8 @@\n },\n \"rpi.sharpen\":\n {\n-\t\"threshold\": 2.0,\n-\t\"strength\": 0.5,\n-\t\"limit\": 0.5\n+ \"threshold\": 2.0,\n+ \"strength\": 0.5,\n+ \"limit\": 0.5\n }\n }\n", "prefixes": [ "libcamera-devel", "v6", "3/8" ] }